From: "Christian König" <christian.koenig@amd.com> To: Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org Cc: "Stephen Bates" <sbates@raithlin.com>, "Christoph Hellwig" <hch@lst.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Jonathan Corbet" <corbet@lwn.net>, "Ingo Molnar" <mingo@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Christoffer Dall" <cdall@linaro.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, "Marc Zyngier" <marc.zyngier@arm.com>, "Kai-Heng Feng" <kai.heng.feng@canonical.com>, "Frederic Weisbecker" <frederic@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "Alex Williamson" <alex.williamson@redhat.com> Subject: Re: [PATCH 0/3] Add parameter for disabling ACS redirection for P2P Date: Fri, 25 May 2018 10:28:31 +0200 [thread overview] Message-ID: <2aec7435-e59b-9ef8-825f-029188f6e549@amd.com> (raw) In-Reply-To: <20180524214816.14485-1-logang@deltatee.com> Am 24.05.2018 um 23:48 schrieb Logan Gunthorpe: > Hi, > > As discussed in our PCI P2PDMA series, we'd like to add a kernel > parameter for selectively disabling ACS redirection for select > bridges. Seeing this turned out to be a small series in itself, we've > decided to send this separately from the P2P work. > > This series generalizes the code already done for the resource_alignment > option that already exists. The first patch creates a helper function > to match PCI devices against strings based on the code that already > existed in pci_specified_resource_alignment(). > > The second patch expands the new helper to optionally take a path of > PCI devfns. This is to address Alex's renumbering concern when using > simple bus-devfns. The implementation is essentially how he described it and > similar to the Intel VT-d spec (Section 8.3.1). > > The final patch adds the disable_acs_redir kernel parameter which takes > a list of PCI devices and will disable the ACS P2P Request Redirect, > ACS P2P Completion Redirect and ACS P2P Egress Control bits for the > selected devices. This allows P2P traffic between selected bridges and > seeing it's done at boot, before IOMMU group creating the IOMMU groups > will be created correctly based on the bits. > > Thanks, > > Logan > > > Logan Gunthorpe (3): > PCI: Make specifying PCI devices in kernel parameters reusable > PCI: Allow specifying devices using a base bus and path of devfns > PCI: Introduce the disable_acs_redir parameter Thanks a lot of taking care of it like that. It looks much cleaner to me than just trying to disable ACS without a parameter. Series is Acked-by: Christian König <christian.koenig@amd.com>. Thanks, Christian. > > Documentation/admin-guide/kernel-parameters.txt | 39 ++- > drivers/pci/pci.c | 358 ++++++++++++++++++++---- > 2 files changed, 336 insertions(+), 61 deletions(-) > > -- > 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com> To: Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org Cc: "Stephen Bates" <sbates@raithlin.com>, "Christoph Hellwig" <hch@lst.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Jonathan Corbet" <corbet@lwn.net>, "Ingo Molnar" <mingo@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Christoffer Dall" <cdall@linaro.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, "Marc Zyngier" <marc.zyngier@arm.com>, "Kai-Heng Feng" <kai.heng.feng@canonical.com>, "Frederic Weisbecker" <frederic@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "Alex Williamson" <alex.williamson@redhat.com> Subject: Re: [PATCH 0/3] Add parameter for disabling ACS redirection for P2P Date: Fri, 25 May 2018 10:28:31 +0200 [thread overview] Message-ID: <2aec7435-e59b-9ef8-825f-029188f6e549@amd.com> (raw) In-Reply-To: <20180524214816.14485-1-logang@deltatee.com> Am 24.05.2018 um 23:48 schrieb Logan Gunthorpe: > Hi, > > As discussed in our PCI P2PDMA series, we'd like to add a kernel > parameter for selectively disabling ACS redirection for select > bridges. Seeing this turned out to be a small series in itself, we've > decided to send this separately from the P2P work. > > This series generalizes the code already done for the resource_alignment > option that already exists. The first patch creates a helper function > to match PCI devices against strings based on the code that already > existed in pci_specified_resource_alignment(). > > The second patch expands the new helper to optionally take a path of > PCI devfns. This is to address Alex's renumbering concern when using > simple bus-devfns. The implementation is essentially how he described it and > similar to the Intel VT-d spec (Section 8.3.1). > > The final patch adds the disable_acs_redir kernel parameter which takes > a list of PCI devices and will disable the ACS P2P Request Redirect, > ACS P2P Completion Redirect and ACS P2P Egress Control bits for the > selected devices. This allows P2P traffic between selected bridges and > seeing it's done at boot, before IOMMU group creating the IOMMU groups > will be created correctly based on the bits. > > Thanks, > > Logan > > > Logan Gunthorpe (3): > PCI: Make specifying PCI devices in kernel parameters reusable > PCI: Allow specifying devices using a base bus and path of devfns > PCI: Introduce the disable_acs_redir parameter Thanks a lot of taking care of it like that. It looks much cleaner to me than just trying to disable ACS without a parameter. Series is Acked-by: Christian König <christian.koenig@amd.com>. Thanks, Christian. > > Documentation/admin-guide/kernel-parameters.txt | 39 ++- > drivers/pci/pci.c | 358 ++++++++++++++++++++---- > 2 files changed, 336 insertions(+), 61 deletions(-) > > -- > 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-25 8:28 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-24 21:48 [PATCH 0/3] Add parameter for disabling ACS redirection for P2P Logan Gunthorpe 2018-05-24 21:48 ` Logan Gunthorpe 2018-05-24 21:48 ` [PATCH 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Logan Gunthorpe 2018-05-24 21:48 ` Logan Gunthorpe 2018-05-24 21:48 ` [PATCH 2/3] PCI: Allow specifying devices using a base bus and path of devfns Logan Gunthorpe 2018-05-24 21:48 ` Logan Gunthorpe 2018-05-30 16:23 ` Alex Williamson 2018-05-30 16:23 ` Alex Williamson 2018-05-30 17:36 ` Logan Gunthorpe 2018-05-30 17:36 ` Logan Gunthorpe 2018-05-24 21:48 ` [PATCH 3/3] PCI: Introduce the disable_acs_redir parameter Logan Gunthorpe 2018-05-24 21:48 ` Logan Gunthorpe 2018-05-25 8:28 ` Christian König [this message] 2018-05-25 8:28 ` [PATCH 0/3] Add parameter for disabling ACS redirection for P2P Christian König 2018-05-31 23:50 Logan Gunthorpe 2018-05-31 23:50 ` Logan Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2aec7435-e59b-9ef8-825f-029188f6e549@amd.com \ --to=christian.koenig@amd.com \ --cc=alex.williamson@redhat.com \ --cc=benh@kernel.crashing.org \ --cc=bhelgaas@google.com \ --cc=cdall@linaro.org \ --cc=corbet@lwn.net \ --cc=dan.j.williams@intel.com \ --cc=frederic@kernel.org \ --cc=hch@lst.de \ --cc=jglisse@redhat.com \ --cc=kai.heng.feng@canonical.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=logang@deltatee.com \ --cc=marc.zyngier@arm.com \ --cc=mingo@kernel.org \ --cc=paulmck@linux.vnet.ibm.com \ --cc=sbates@raithlin.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.