Re: [RFC 2/2] media: rkvdec: Add VP8 encoder

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Daniel Almeida <daniel.almeida@collabora.com>,
	linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	kernel@collabora.com
Subject: Re: [RFC 2/2] media: rkvdec: Add VP8 encoder
Date: Mon, 20 Mar 2023 11:34:42 +0100	[thread overview]
Message-ID: <2aecb113-0c69-88ac-a726-66e03d9f0a2e@collabora.com> (raw)
In-Reply-To: <efd18d9b-172a-8978-bb9a-18bb0edda4ee@collabora.com>

Hi Dmitry,

W dniu 19.03.2023 o 00:27, Dmitry Osipenko pisze:
> On 3/19/23 02:23, Daniel Almeida wrote:
>> Hi Andrzej, one thing I noticed while looking at this:
>>
>>> +struct hantro_vp8_entropy {
>>> +	/* TODO: int32_t? */
>>> +	int32_t coeff_prob[4][8][3][11];
>>> +	int32_t coeff_prob_old[4][8][3][11];
>>> +	int32_t mv_prob[2][19];
>>> +	int32_t mv_prob_old[2][19];
>>> +	int32_t y_mode_prob[4];
>>> +	int32_t uv_mode_prob[3];
>>> +};
>>>
>>
>>
>> In VP9, probabilities are coded in the 0..255 range, so if you want to
>> save space here, you can go with uint8_t.
> 
> BTW, there is a mix of int32_t and s32 in the code, the s32 is a correct
> choice. Similar for u8. Checkpatch --strict should warn about it all.
> 

Thanks. Something for a series proper (not RFC) indeed.

Andrzej

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)

From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Daniel Almeida <daniel.almeida@collabora.com>,
	linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	kernel@collabora.com
Subject: Re: [RFC 2/2] media: rkvdec: Add VP8 encoder
Date: Mon, 20 Mar 2023 11:34:42 +0100	[thread overview]
Message-ID: <2aecb113-0c69-88ac-a726-66e03d9f0a2e@collabora.com> (raw)
In-Reply-To: <efd18d9b-172a-8978-bb9a-18bb0edda4ee@collabora.com>

Hi Dmitry,

W dniu 19.03.2023 o 00:27, Dmitry Osipenko pisze:
> On 3/19/23 02:23, Daniel Almeida wrote:
>> Hi Andrzej, one thing I noticed while looking at this:
>>
>>> +struct hantro_vp8_entropy {
>>> +	/* TODO: int32_t? */
>>> +	int32_t coeff_prob[4][8][3][11];
>>> +	int32_t coeff_prob_old[4][8][3][11];
>>> +	int32_t mv_prob[2][19];
>>> +	int32_t mv_prob_old[2][19];
>>> +	int32_t y_mode_prob[4];
>>> +	int32_t uv_mode_prob[3];
>>> +};
>>>
>>
>>
>> In VP9, probabilities are coded in the 0..255 range, so if you want to
>> save space here, you can go with uint8_t.
> 
> BTW, there is a mix of int32_t and s32 in the code, the s32 is a correct
> choice. Similar for u8. Checkpatch --strict should warn about it all.
> 

Thanks. Something for a series proper (not RFC) indeed.

Andrzej

WARNING: multiple messages have this Message-ID (diff)

From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Daniel Almeida <daniel.almeida@collabora.com>,
	linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	kernel@collabora.com
Subject: Re: [RFC 2/2] media: rkvdec: Add VP8 encoder
Date: Mon, 20 Mar 2023 11:34:42 +0100	[thread overview]
Message-ID: <2aecb113-0c69-88ac-a726-66e03d9f0a2e@collabora.com> (raw)
In-Reply-To: <efd18d9b-172a-8978-bb9a-18bb0edda4ee@collabora.com>

Hi Dmitry,

W dniu 19.03.2023 o 00:27, Dmitry Osipenko pisze:
> On 3/19/23 02:23, Daniel Almeida wrote:
>> Hi Andrzej, one thing I noticed while looking at this:
>>
>>> +struct hantro_vp8_entropy {
>>> +	/* TODO: int32_t? */
>>> +	int32_t coeff_prob[4][8][3][11];
>>> +	int32_t coeff_prob_old[4][8][3][11];
>>> +	int32_t mv_prob[2][19];
>>> +	int32_t mv_prob_old[2][19];
>>> +	int32_t y_mode_prob[4];
>>> +	int32_t uv_mode_prob[3];
>>> +};
>>>
>>
>>
>> In VP9, probabilities are coded in the 0..255 range, so if you want to
>> save space here, you can go with uint8_t.
> 
> BTW, there is a mix of int32_t and s32 in the code, the s32 is a correct
> choice. Similar for u8. Checkpatch --strict should warn about it all.
> 

Thanks. Something for a series proper (not RFC) indeed.

Andrzej

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

next prev parent reply	other threads:[~2023-03-20 10:35 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 12:56 [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Andrzej Pietrasiewicz
2023-03-09 12:56 ` Andrzej Pietrasiewicz
2023-03-09 12:56 ` Andrzej Pietrasiewicz
2023-03-09 12:56 ` [RFC 1/2] media: uapi: Add VP8 stateless encoder controls Andrzej Pietrasiewicz
2023-03-09 12:56   ` Andrzej Pietrasiewicz
2023-03-09 12:56   ` Andrzej Pietrasiewicz
2023-03-21 13:39   ` Hans Verkuil
2023-03-21 13:39     ` Hans Verkuil
2023-03-21 13:39     ` Hans Verkuil
2023-03-22 10:06     ` Andrzej Pietrasiewicz
2023-03-22 10:06       ` Andrzej Pietrasiewicz
2023-03-22 10:06       ` Andrzej Pietrasiewicz
2023-03-24 18:49       ` Nicolas Dufresne
2023-03-24 18:49         ` Nicolas Dufresne
2023-03-24 18:49         ` Nicolas Dufresne
2023-03-27 12:53         ` Andrzej Pietrasiewicz
2023-03-27 12:53           ` Andrzej Pietrasiewicz
2023-03-27 12:53           ` Andrzej Pietrasiewicz
2023-03-31 14:59           ` Nicolas Dufresne
2023-03-31 14:59             ` Nicolas Dufresne
2023-03-31 14:59             ` Nicolas Dufresne
2023-03-09 12:56 ` [RFC 2/2] media: rkvdec: Add VP8 encoder Andrzej Pietrasiewicz
2023-03-09 12:56   ` Andrzej Pietrasiewicz
2023-03-09 12:56   ` Andrzej Pietrasiewicz
2023-03-18 23:23   ` Daniel Almeida
2023-03-18 23:23     ` Daniel Almeida
2023-03-18 23:23     ` Daniel Almeida
2023-03-18 23:27     ` Dmitry Osipenko
2023-03-18 23:27       ` Dmitry Osipenko
2023-03-18 23:27       ` Dmitry Osipenko
2023-03-20 10:34       ` Andrzej Pietrasiewicz [this message]
2023-03-20 10:34         ` Andrzej Pietrasiewicz
2023-03-20 10:34         ` Andrzej Pietrasiewicz
2023-03-20 10:33     ` Andrzej Pietrasiewicz
2023-03-20 10:33       ` Andrzej Pietrasiewicz
2023-03-20 10:33       ` Andrzej Pietrasiewicz
2023-05-05 16:33   ` guan wentao
2023-05-05 16:33     ` guan wentao
2023-05-05 16:33     ` guan wentao
2023-05-20 18:57   ` Adam Ford
2023-05-20 18:57     ` Adam Ford
2023-05-20 18:57     ` Adam Ford
2023-05-23  6:42     ` Marco Felsch
2023-05-23  6:42       ` Marco Felsch
2023-05-23  6:42       ` Marco Felsch
2023-05-25 14:20       ` Nicolas Dufresne
2023-05-25 14:20         ` Nicolas Dufresne
2023-05-25 14:20         ` Nicolas Dufresne
2023-03-18  9:20 ` [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Nicolas Frattaroli
2023-03-18  9:20   ` Nicolas Frattaroli
2023-03-18  9:20   ` Nicolas Frattaroli
2023-03-20 10:07   ` Andrzej Pietrasiewicz
2023-03-20 10:07     ` Andrzej Pietrasiewicz
2023-03-20 10:07     ` Andrzej Pietrasiewicz
2023-03-20 14:37     ` Nicolas Frattaroli
2023-03-20 14:37       ` Nicolas Frattaroli
2023-03-20 14:37       ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2aecb113-0c69-88ac-a726-66e03d9f0a2e@collabora.com \
    --to=andrzej.p@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.