All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes
Date: Thu, 4 May 2017 08:16:26 -0500	[thread overview]
Message-ID: <2af99142-4bb8-1fcd-5114-c53b9e1504ff@redhat.com> (raw)
In-Reply-To: <87lgqdnl0f.fsf@dusky.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On 05/04/2017 02:23 AM, Markus Armbruster wrote:

>>> Feel free to suggest something for me to add to the commit message.
>>
>> Maybe change:
>>
>>   "which matches the documented actions that a real QGA client
>>    is supposed to do."
>>
>> to
>>
>>   "which is compatible with the documented actions that a real
>>    QGA client is supposed to do."
>>
>> and add the following comment to test_qga_sync_delimited
>>
>>   /* 
>>    * Note that the full reset sequence would involve checking the
>>    * response of guest-sync-delimited and repeating the loop if
>>    * 'id' field of the response does not match the 'id' field of 
>>    * the request. Testing this fully would require inserting
>>    * garbage in the response stream and is left as a future test
>>    * to implement.
>>    */
> 
> Eric, want me to squash that in?

Yes, those changes are reasonable.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2017-05-04 13:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 21:58 [Qemu-devel] [PATCH v5 00/10] qapi-related cleanups Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 01/10] pci: Use struct instead of QDict to pass back parameters Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 02/10] pci: Reduce scope of error injection Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 03/10] coccinelle: Add script to remove useless QObject casts Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 04/10] qobject: Drop " Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 05/10] qobject: Add helper macros for common scalar insertions Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros Eric Blake
2017-04-28  8:33   ` Markus Armbruster
2017-04-28  8:33   ` Markus Armbruster
2017-05-02 15:56     ` Stefan Hajnoczi
2017-05-02 15:56       ` Stefan Hajnoczi
2017-05-02 16:26       ` Markus Armbruster
2017-05-02 16:26       ` Markus Armbruster
     [not found]     ` <e95da4dd-ae83-ea7b-73bb-849a88e8e049@suse.com>
2017-05-02 17:30       ` [Qemu-devel] [Research] Strato HiDrive as a Dropbox Replacement? Michal Suchánek
2017-05-08 14:48     ` [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros Alberto Garcia
2017-05-08 14:48       ` Alberto Garcia
2017-05-09  7:14       ` Markus Armbruster
2017-05-09  7:14       ` Markus Armbruster
2017-04-27 21:58 ` Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 07/10] block: Simplify bdrv_append_temp_snapshot() logic Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 08/10] QemuOpts: Simplify qemu_opts_to_qdict() Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 09/10] fdc-test: Avoid deprecated 'change' command Eric Blake
2017-04-27 21:58 ` [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes Eric Blake
2017-05-02 16:46   ` Michael Roth
2017-05-02 16:56     ` Michael Roth
2017-05-03  8:57       ` Markus Armbruster
2017-05-03 19:52         ` Michael Roth
2017-05-04  7:23           ` Markus Armbruster
2017-05-04 13:16             ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2af99142-4bb8-1fcd-5114-c53b9e1504ff@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.