Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Alexander Graf" <agraf@suse.de>,
	"Josh Durgin" <jdurgin@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Jeff Cody" <jcody@redhat.com>,
	"Peter Lieven" <pl@kamp.de>,
	qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Fam Zheng" <famz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"open list:X86" <xen-devel@lists.xenproject.org>,
	"Max Reitz" <mreitz@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros
Date: Tue, 02 May 2017 18:26:44 +0200	[thread overview]
Message-ID: <87bmrbcji3.fsf__31053.6874960691$1493742484$gmane$org@dusky.pond.sub.org> (raw)
In-Reply-To: <20170502155620.GB26628@stefanha-x1.localdomain> (Stefan Hajnoczi's message of "Tue, 2 May 2017 16:56:20 +0100")

Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Fri, Apr 28, 2017 at 10:33:36AM +0200, Markus Armbruster wrote:
>> Eric Blake <eblake@redhat.com> writes:
>> 
>> > We now have macros in place to make it less verbose to add a scalar
>> > to QDict and QList, so use them.  To make this patch smaller to
>> > review, a couple of subdirectories were done in earlier patches.
>> 
>> Scratch the last sentence.  Can do on commit.
>> 
>> > Patch created mechanically via:
>> >   spatch --sp-file scripts/coccinelle/qobject.cocci \
>> >     --macro-file scripts/cocci-macro-file.h --dir . --in-place
>> > then touched up manually to fix a couple of '?:' back to original
>> > spacing, as well as avoiding a long line in monitor.c.
>> >
>> > Signed-off-by: Eric Blake <eblake@redhat.com>
>> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
>> >
>> > ---
>> > v5: rebase to master (Coccinelle found a couple new spots), squash 3
>> > patches into 1, adjust R-b to only list Markus (while there were other
>> > reviews on the pre-squashed patches, Markus was the only one on all 3)
>> 
>> The block: part had
>> 
>>     Acked-by: Richard W.M. Jones <rjones@redhat.com>
>>     Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>     Reviewed-by: Alberto Garcia <berto@igalia.com>
>> 
>> The tests and qobject parts had
>> 
>>     Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> 
>> Richard, Stefan, Alberto, Philippe, let me know if you'd like me to
>> convert your R-by of parts to an Acked-by of the combined patch.  Feel
>> free to review the combined patch, of course.
>
> Please keep my R-by, I have reviewed again.

Gladly.  Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel