From: "J, KEERTHY" <j-keerthy@ti.com> To: Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com> Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Amit Kucheria <amit.kucheria@linaro.org> Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Relocate thermal-zones to SoC specific location Date: Fri, 17 Sep 2021 09:13:53 +0530 [thread overview] Message-ID: <2afceb2e-e076-1261-4db4-1afd1f00f78f@ti.com> (raw) In-Reply-To: <20210916181801.32588-1-nm@ti.com> On 9/16/2021 11:48 PM, Nishanth Menon wrote: > When commit 64f9147d914d ("arm64: dts: ti: am654: Add thermal > zones") introduced thermal-zones for am654, it defined as under the > common am65-wakeup bus segment, when it is am654 specific (other SoC > spins can have slightly different thermal characteristics). Futher, > thermal-zones is introduced under simple-bus node, when it has no > actual register or base address. > > So, move it to it's rightful place under am654 SoC dtsi under the base > node. Reviewed-by: Keerthy <j-keerthy@ti.com> > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > > NOTE: > 1. This is a cosmetic fixup, so skip the "Fixes" tag. > 2. This fixes up noisy dtbs_check warning around thermal. > > arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 4 ---- > arch/arm64/boot/dts/ti/k3-am654.dtsi | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > index 9d21cdf6fce8..9c69d0917f69 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > @@ -100,8 +100,4 @@ wkup_vtm0: temperature-sensor@42050000 { > power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>; > #thermal-sensor-cells = <1>; > }; > - > - thermal_zones: thermal-zones { > - #include "k3-am654-industrial-thermal.dtsi" > - }; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi > index f0a6541b8042..a89257900047 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi > @@ -112,4 +112,8 @@ msmc_l3: l3-cache0 { > compatible = "cache"; > cache-level = <3>; > }; > + > + thermal_zones: thermal-zones { > + #include "k3-am654-industrial-thermal.dtsi" > + }; > }; >
WARNING: multiple messages have this Message-ID (diff)
From: "J, KEERTHY" <j-keerthy@ti.com> To: Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com> Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Amit Kucheria <amit.kucheria@linaro.org> Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Relocate thermal-zones to SoC specific location Date: Fri, 17 Sep 2021 09:13:53 +0530 [thread overview] Message-ID: <2afceb2e-e076-1261-4db4-1afd1f00f78f@ti.com> (raw) In-Reply-To: <20210916181801.32588-1-nm@ti.com> On 9/16/2021 11:48 PM, Nishanth Menon wrote: > When commit 64f9147d914d ("arm64: dts: ti: am654: Add thermal > zones") introduced thermal-zones for am654, it defined as under the > common am65-wakeup bus segment, when it is am654 specific (other SoC > spins can have slightly different thermal characteristics). Futher, > thermal-zones is introduced under simple-bus node, when it has no > actual register or base address. > > So, move it to it's rightful place under am654 SoC dtsi under the base > node. Reviewed-by: Keerthy <j-keerthy@ti.com> > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > > NOTE: > 1. This is a cosmetic fixup, so skip the "Fixes" tag. > 2. This fixes up noisy dtbs_check warning around thermal. > > arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 4 ---- > arch/arm64/boot/dts/ti/k3-am654.dtsi | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > index 9d21cdf6fce8..9c69d0917f69 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi > @@ -100,8 +100,4 @@ wkup_vtm0: temperature-sensor@42050000 { > power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>; > #thermal-sensor-cells = <1>; > }; > - > - thermal_zones: thermal-zones { > - #include "k3-am654-industrial-thermal.dtsi" > - }; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi > index f0a6541b8042..a89257900047 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi > @@ -112,4 +112,8 @@ msmc_l3: l3-cache0 { > compatible = "cache"; > cache-level = <3>; > }; > + > + thermal_zones: thermal-zones { > + #include "k3-am654-industrial-thermal.dtsi" > + }; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-17 3:44 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-16 18:18 [PATCH] arm64: dts: ti: k3-am65: Relocate thermal-zones to SoC specific location Nishanth Menon 2021-09-16 18:18 ` Nishanth Menon 2021-09-17 3:43 ` J, KEERTHY [this message] 2021-09-17 3:43 ` J, KEERTHY 2021-09-20 19:00 ` Nishanth Menon 2021-09-20 19:00 ` Nishanth Menon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2afceb2e-e076-1261-4db4-1afd1f00f78f@ti.com \ --to=j-keerthy@ti.com \ --cc=amit.kucheria@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=kristo@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.