All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Pull request, u-boot-tegra/master
Date: Tue, 16 Jan 2018 10:47:43 -0700	[thread overview]
Message-ID: <2b04a6a9-954f-7852-a8e6-ff5031615c9e@wwwdotorg.org> (raw)
In-Reply-To: <20180115135350.GJ4660@bill-the-cat>

On 01/15/2018 06:53 AM, Tom Rini wrote:
> On Fri, Jan 12, 2018 at 10:37:06AM -0700, Tom Warren wrote:
> 
>> Tom,
>>
>> Please pull u-boot-tegra/master into U-Boot/master. Thanks!
>>
>> All Tegra builds are OK, and Stephen's automated test system reports that
>> all tests pass.
>>
>> The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b:
>>
>>    Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500)
>>
>> are available in the git repository at:
>>
>>    git://git.denx.de/u-boot-tegra.git master
>>
>> for you to fetch changes up to 5fed97af20da955625cc06563a725b49cebb99eb:
>>
>>    Makefile: ensure DTB doesn't overflow into initial stack (2018-01-12
>> 10:12:32 -0700)
> 
> Applied to u-boot/master, thanks!
> 
> But please note the following checkpatch.pl issues that should be looked
> into and possibly addressed:

Most of these are due to importing code verbatim from the Linux kernel. 
I figured that keeping the code identical to upstream was better than 
locally fixing the checkpatch issues and putting the two sets of source 
out-of-sync. I believe the only two things I introduced were:

> ERROR: space required after that close brace '}'
> #44: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
> +} ram_banks[CONFIG_NR_DRAM_BANKS] = {{1}};

That's a bogus issue.

> total: 1 errors, 0 warnings, 0 checks, 48 lines checked
> WARNING: externs should be avoided in .c files
> #58: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
> +extern struct mm_region tegra_mem_map[];
> 
> total: 0 errors, 1 warnings, 0 checks, 138 lines checked
> WARNING: externs should be avoided in .c files
> #53: FILE: arch/arm/mach-tegra/tegra186/nvtboot_board.c:29:
> +extern struct mm_region tegra_mem_map[];

I suppose those could be fixed.

  reply	other threads:[~2018-01-16 17:47 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 17:37 [U-Boot] Pull request, u-boot-tegra/master Tom Warren
2018-01-15 13:53 ` Tom Rini
2018-01-16 17:47   ` Stephen Warren [this message]
2018-01-16 18:14     ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2019-08-09 17:21 Tom Warren
2019-08-11  1:13 ` Tom Rini
2019-06-05 20:50 Tom Warren
2019-06-07  1:31 ` Tom Rini
2019-06-07 15:28   ` Tom Warren
2019-06-07 15:40     ` Tom Rini
2019-06-07 17:17       ` Tom Warren
2019-06-07 18:30         ` Peter Robinson
2019-06-11  1:31 ` Tom Rini
2019-05-28 16:01 Tom Warren
2019-05-29 17:18 ` Tom Rini
2019-02-20 16:34 Tom Warren
2019-02-21 23:10 ` Tom Rini
2019-02-19 22:44 Tom Warren
2018-08-21 17:27 Tom Warren
2018-08-23 13:59 ` Tom Rini
2018-07-26 21:08 Tom Warren
2018-07-27 17:08 ` Tom Rini
2018-07-06 20:11 Tom Warren
2018-07-06 22:04 ` Tom Rini
2018-05-11 19:19 Tom Warren
2018-05-12  1:49 ` Tom Rini
2017-08-16 15:30 Tom Warren
2017-08-17  1:17 ` Tom Rini
2017-06-20 19:04 Tom Warren
2017-06-21 23:05 ` Tom Rini
2017-06-12 23:32 Tom Warren
2017-06-15 13:01 ` Tom Rini
2017-04-04 17:56 Tom Warren
2017-04-05  1:13 ` Tom Rini
2017-01-04 17:05 Tom Warren
2017-01-05 13:28 ` Tom Rini
2016-11-08 15:34 Tom Warren
2016-11-08 20:53 ` Tom Rini
2016-10-10 20:55 Tom Warren
2016-10-13  0:48 ` Tom Rini
2016-09-27 16:16 Tom Warren
2016-09-27 21:34 ` Tom Rini
2016-09-01 17:32 Tom Warren
2016-09-02 14:53 ` Tom Rini
2016-08-25 23:42 Tom Warren
2016-08-26 14:52 ` Tom Rini
2016-08-15 19:38 Tom Warren
2016-08-16  1:09 ` Tom Rini
2016-08-05 17:26 Tom Warren
2016-08-06  0:57 ` Tom Rini
2016-07-21 20:17 Tom Warren
2016-07-23  0:10 ` Tom Rini
2016-07-23  0:17   ` Stephen Warren
2016-07-23  0:22     ` Tom Rini
2016-07-23  0:31       ` Stephen Warren
2016-07-23  0:42         ` Tom Rini
2016-07-06 17:32 Tom Warren
2016-07-08  2:51 ` Tom Rini
2016-06-03 16:00 Tom Warren
2016-06-06 11:15 ` Tom Rini
2016-05-04 21:36 Tom Warren
2016-05-04 22:12 ` Tom Rini
2016-03-29 17:24 Tom Warren
2016-03-29 22:06 ` Tom Rini
2016-02-18 19:53 Tom Warren
2016-02-20  0:54 ` Tom Rini
2016-01-28 17:46 Tom Warren
2016-01-28 23:18 ` Tom Rini
2015-11-12 20:53 Tom Warren
2015-11-13  1:26 ` Tom Rini
2015-10-02 18:15 Tom Warren
2015-10-03  0:51 ` Tom Rini
2015-09-16 23:27 Tom Warren
2015-09-17  1:06 ` Tom Rini
2015-08-13 20:26 Tom Warren
2015-08-13 21:55 ` Tom Rini
2015-08-06 20:39 Tom Warren
2015-08-11 17:44 ` Tom Warren
2015-08-11 18:04   ` Tom Rini
2015-08-11 20:54     ` Tom Warren
2015-07-28 15:31 [U-Boot] Pull request: u-boot-tegra/master Tom Warren
2015-07-28 15:51 ` Stephen Warren
2015-07-28 17:23   ` Tom Warren
2015-06-09 17:06 Tom Warren
2015-06-10 14:37 ` Tom Rini
2015-05-12 21:49 Tom Warren
2015-05-13  1:45 ` Masahiro Yamada
2015-05-13 16:38   ` Tom Warren
2015-05-13 19:23     ` Tom Warren
2015-05-14 19:14       ` Tom Rini
2012-03-08 20:27 [U-Boot] pull " Tom Warren
2012-01-19  0:01 Tom Warren
2012-01-21 11:07 ` Albert ARIBAUD
2012-01-23 15:55   ` Tom Warren
2011-12-07 23:35 [U-Boot] Pull " Tom Warren
2011-12-08  7:22 ` Albert ARIBAUD
2011-12-08 16:45   ` Stephen Warren
2011-12-09 15:36     ` Albert ARIBAUD
2011-12-09 17:10       ` Stephen Warren
2011-12-09 17:22         ` Albert ARIBAUD
2011-12-09 17:37           ` Stephen Warren
2011-12-09 17:53             ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b04a6a9-954f-7852-a8e6-ff5031615c9e@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.