* [PATCH] usb: uas: Add quirk for PNY Pro Elite
@ 2020-08-19 2:27 Thinh Nguyen
2020-08-22 14:15 ` Hans de Goede
2020-08-24 10:04 ` Oliver Neukum
0 siblings, 2 replies; 3+ messages in thread
From: Thinh Nguyen @ 2020-08-19 2:27 UTC (permalink / raw)
To: Hans de Goede, Greg Kroah-Hartman, linux-usb, Alan Stern, usb-storage
Cc: Thinh Nguyen, stable
PNY Pro Elite USB 3.1 Gen 2 device (SSD) doesn't respond to ATA_12
pass-through command (i.e. it just hangs). If it doesn't support this
command, it should respond properly to the host. Let's just add a quirk
to be able to move forward with other operations.
Cc: stable@vger.kernel.org
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
drivers/usb/storage/unusual_uas.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 162b09d69f62..971f8a4354c8 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -80,6 +80,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
US_FL_BROKEN_FUA),
+/* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
+UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999,
+ "PNY",
+ "Pro Elite SSD",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+ US_FL_NO_ATA_1X),
+
/* Reported-by: Hans de Goede <hdegoede@redhat.com> */
UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
"VIA",
base-commit: d5643d2249b279077427b2c2b2ffae9b70c95b0b
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: uas: Add quirk for PNY Pro Elite
2020-08-19 2:27 [PATCH] usb: uas: Add quirk for PNY Pro Elite Thinh Nguyen
@ 2020-08-22 14:15 ` Hans de Goede
2020-08-24 10:04 ` Oliver Neukum
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2020-08-22 14:15 UTC (permalink / raw)
To: Thinh Nguyen, Greg Kroah-Hartman, linux-usb, Alan Stern, usb-storage
Cc: stable, Oliver Neukum
Hi,
On 8/19/20 4:27 AM, Thinh Nguyen wrote:
> PNY Pro Elite USB 3.1 Gen 2 device (SSD) doesn't respond to ATA_12
> pass-through command (i.e. it just hangs). If it doesn't support this
> command, it should respond properly to the host. Let's just add a quirk
> to be able to move forward with other operations.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 162b09d69f62..971f8a4354c8 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -80,6 +80,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_BROKEN_FUA),
>
> +/* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
> +UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999,
> + "PNY",
> + "Pro Elite SSD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_NO_ATA_1X),
> +
> /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
> UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
> "VIA",
>
> base-commit: d5643d2249b279077427b2c2b2ffae9b70c95b0b
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: uas: Add quirk for PNY Pro Elite
2020-08-19 2:27 [PATCH] usb: uas: Add quirk for PNY Pro Elite Thinh Nguyen
2020-08-22 14:15 ` Hans de Goede
@ 2020-08-24 10:04 ` Oliver Neukum
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2020-08-24 10:04 UTC (permalink / raw)
To: Thinh Nguyen, Hans de Goede, Greg Kroah-Hartman, linux-usb,
Alan Stern, usb-storage
Cc: stable
Am Dienstag, den 18.08.2020, 19:27 -0700 schrieb Thinh Nguyen:
> PNY Pro Elite USB 3.1 Gen 2 device (SSD) doesn't respond to ATA_12
> pass-through command (i.e. it just hangs). If it doesn't support this
> command, it should respond properly to the host. Let's just add a quirk
> to be able to move forward with other operations.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-24 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 2:27 [PATCH] usb: uas: Add quirk for PNY Pro Elite Thinh Nguyen
2020-08-22 14:15 ` Hans de Goede
2020-08-24 10:04 ` Oliver Neukum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.