From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [Regression] net/phy/micrel.c v4.9.94
Date: Thu, 19 Apr 2018 10:34:43 +0800 [thread overview]
Message-ID: <2b270eb0-3193-943f-300c-8959fad7802b@gtsys.com.hk> (raw)
In-Reply-To: <24c8e4cd-f2c1-6d50-9557-28a9958e74a5@gtsys.com.hk>
On Thursday, April 19, 2018 09:34 AM, Chris Ruehl wrote:
>
>
> On Thursday, April 19, 2018 09:21 AM, Chris Ruehl wrote:
>> On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote:
>>> On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote:
>>>> On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote:
>>>>> Hello,
>>>>>
>>>>> I like to get your heads up at a regression introduced in 4.9.94
>>>>> commitment lead to a kernel ops and make the network unusable on my MX6DL
>>>>> customized board.
>>>>>
>>>>> Race condition resume is called on startup and the phy not yet initialized.
>>>>
>>>> Hi Chris
>>>>
>>>> Please could you try
>>>>
>>>> bfe72442578b ("net: phy: micrel: fix crash when statistic requested for
>>>> KSZ9031 phy")
>>>
>>> I don't think it is a complete fix. I suspect "Micrel KSZ8795",
>>> "Micrel KSZ886X Switch", "Micrel KSZ8061", and "Micrel KS8737" will
>>> still have problems.
>>>
>>> Those four probably need a:
>>>
>>> .probe = kszphy_probe,
>>>
>>> Andrew
>>>
>>
>> Indeed I have the
>> [ 7.385851] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:05: attached PHY
>> driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:05,
>> irq=-1)
>>
>> first I rollback to a non crashing stable kernel.
>>
>> As "bfe72442578b" gonna fix it I check with the next update and verify its
>> works for me.
>>
>> Thanks
>> Chris
>
> Andrew,
>
> Change my mind. Find the patch you mentioned and will apply and test.
>
> Chris
Andrew,
make a micro patch only and can confirm to add the .probe fix the ops.
But the imx serial is broken :-( ! have to have a look into it.
--- linux-4.9/drivers/net/phy/micrel.c.orig 2018-04-19 09:37:45.648000000 +0800
+++ linux-4.9/drivers/net/phy/micrel.c 2018-04-19 09:44:54.356000000 +0800
@@ -974,6 +974,7 @@
.features = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
.flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
.driver_data = &ksz9021_type,
+ .probe = kszphy_probe,
.config_init = ksz9021_config_init,
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
@@ -993,6 +994,7 @@
.features = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
.flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
.driver_data = &ksz9021_type,
+ .probe = kszphy_probe,
.config_init = ksz9031_config_init,
.config_aneg = genphy_config_aneg,
.read_status = ksz9031_read_status,
[ 7.219735] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:04: attached PHY
driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:04, irq=-1)
Regards
Chris
--
GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521
Disclaimer: https://www.gtsys.com.hk/email/classified.html
prev parent reply other threads:[~2018-04-19 2:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 1:34 [Regression] net/phy/micrel.c v4.9.94 Chris Ruehl
2018-04-18 5:09 ` Chris Ruehl
2018-04-18 12:43 ` Andrew Lunn
2018-04-18 12:56 ` Andrew Lunn
2018-04-18 13:02 ` Andrew Lunn
2018-04-19 1:21 ` Chris Ruehl
2018-04-19 1:34 ` Chris Ruehl
2018-04-19 2:34 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b270eb0-3193-943f-300c-8959fad7802b@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.