All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: Julien Grall <julien@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Date: Mon, 6 Dec 2021 14:44:18 +0100	[thread overview]
Message-ID: <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com> (raw)
In-Reply-To: <24992.55453.893877.246946@mariner.uk.xensource.com>

On 26.11.2021 13:52, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>> On 26.11.2021 11:04, Julien Grall wrote:
>>> For this case, you provided some sort of an explanation but so far, I am 
>>> still waiting for a link to confirm that the signed-off-by match the one 
>>> on the ML.
>>
>> I haven't been able to easily find a mail archive holding this patch.
> 
> I 100% agree with Julien on all points in this thread.
> 
> Please can we keep the Linux S-o-b.
> 
> Note that S-o-b is not a chain of *approval* (whose relevance to us is
> debateable) but but a chain of *custody and transmission* for
> copyright/licence/gdpr purposes.  That latter chain is hightly
> relevant to us.
> 
> All such S-o-b should be retained.
> 
> Of course if you got the patch somewhere other than the Linux commit,
> then the chain of custody doesn't pass through the Linux commit.  But
> in that case I expect you to be able to say where you got it.

I've submitted v2 with S-o-b restored as far as necessary to meet this
requirement. I did not restore all of them, because I continue to not
see the value of retaining them. You saying "is highly relevant to us"
is a statement, but not an explanation of why tags beyond those in the
original submissions need retaining.

Without me seeing the need / value, I'm afraid I see only two ways
forward: Either things are acceptable as they are now (and will be for
future similar imports), or it needs to be someone else to put time
into spotting and then pulling in such changes.

Jan



  reply	other threads:[~2021-12-06 13:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 10:20 [PATCH 0/7] (mainly) xz imports from Linux Jan Beulich
2021-11-19 10:21 ` [PATCH 1/7] xz: add fall-through comments to a switch statement Jan Beulich
2021-11-25 16:49   ` Julien Grall
2021-11-25 16:54     ` Julien Grall
2021-11-25 17:03       ` Jan Beulich
2021-11-25 17:13         ` Julien Grall
2021-11-26  7:37           ` Jan Beulich
2021-11-26  9:03             ` Julien Grall
2021-11-26  9:12               ` Jan Beulich
2021-11-26 10:04                 ` Julien Grall
2021-11-26 11:52                   ` Jan Beulich
2021-11-26 12:52                     ` Ian Jackson
2021-12-06 13:44                       ` Jan Beulich [this message]
2021-12-06 14:28                         ` Julien Grall
2021-12-06 15:06                           ` Jan Beulich
2021-12-06 16:06                             ` Julien Grall
2021-12-06 16:12                               ` Jan Beulich
2021-12-06 16:21                                 ` Julien Grall
2021-12-06 16:24                                   ` Jan Beulich
2021-12-06 16:30                                     ` Julien Grall
2021-12-06 16:45                                   ` Ian Jackson
2021-12-07  8:55                                     ` Jan Beulich
2021-12-07  9:11                                   ` Jan Beulich
2021-12-07  9:59                                     ` Julien Grall
2021-12-07 10:19                                       ` Jan Beulich
2021-12-07 12:00                                         ` Ian Jackson
2021-12-07 13:30                                           ` Jan Beulich
2021-11-19 10:21 ` [PATCH 2/7] xz: fix XZ_DYNALLOC to avoid useless memory reallocations Jan Beulich
2021-11-25 16:55   ` Julien Grall
2021-11-19 10:21 ` [PATCH 3/7] decompressors: fix spelling mistakes Jan Beulich
2021-11-25 16:57   ` Julien Grall
2021-11-19 10:22 ` [PATCH 4/7] xz: avoid overlapping memcpy() with invalid input with in-place decompression Jan Beulich
2021-11-19 10:22 ` [PATCH 5/7] xz: fix spelling in comments Jan Beulich
2021-11-19 10:23 ` [PATCH 6/7] xz: move s->lzma.len = 0 initialization to lzma_reset() Jan Beulich
2021-11-19 10:23 ` [PATCH 7/7] xz: validate the value before assigning it to an enum variable Jan Beulich
2021-11-19 14:25 ` [PATCH 0/7] (mainly) xz imports from Linux Ian Jackson
2021-11-22  7:10   ` Jan Beulich
2021-12-03 15:35 ` Luca Fancellu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.