All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <iwj@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 0/7] (mainly) xz imports from Linux
Date: Fri, 19 Nov 2021 14:25:51 +0000	[thread overview]
Message-ID: <24983.46063.379168.151942@mariner.uk.xensource.com> (raw)
In-Reply-To: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>

Jan Beulich writes ("[PATCH 0/7] (mainly) xz imports from Linux"):
> While going through their 5.15.3 log I did notice two changes, which made
> me go check what else we might be missing. The series here is the result.
> Linux has also updated zstd, but that includes a pretty large change which
> I'm not ready to deal with right now. Them moving closer to the upstream
> zstd sources is certainly a good thing, so I suppose sooner or later we
> will want to follow them in doing so.
> 
> 1: xz: add fall-through comments to a switch statement
> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
> 3: decompressors: fix spelling mistakes
> 4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
> 5: xz: fix spelling in comments
> 6: xz: move s->lzma.len = 0 initialization to lzma_reset()
> 7: xz: validate the value before assigning it to an enum variable

FTAOD I think none of these are critical bug fixes for 4.16.
Please let me know if I'm wrong.

In theory 4 is UB but in practice the result is presumably just wrong
answers.

Ian.


  parent reply	other threads:[~2021-11-19 14:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 10:20 [PATCH 0/7] (mainly) xz imports from Linux Jan Beulich
2021-11-19 10:21 ` [PATCH 1/7] xz: add fall-through comments to a switch statement Jan Beulich
2021-11-25 16:49   ` Julien Grall
2021-11-25 16:54     ` Julien Grall
2021-11-25 17:03       ` Jan Beulich
2021-11-25 17:13         ` Julien Grall
2021-11-26  7:37           ` Jan Beulich
2021-11-26  9:03             ` Julien Grall
2021-11-26  9:12               ` Jan Beulich
2021-11-26 10:04                 ` Julien Grall
2021-11-26 11:52                   ` Jan Beulich
2021-11-26 12:52                     ` Ian Jackson
2021-12-06 13:44                       ` Jan Beulich
2021-12-06 14:28                         ` Julien Grall
2021-12-06 15:06                           ` Jan Beulich
2021-12-06 16:06                             ` Julien Grall
2021-12-06 16:12                               ` Jan Beulich
2021-12-06 16:21                                 ` Julien Grall
2021-12-06 16:24                                   ` Jan Beulich
2021-12-06 16:30                                     ` Julien Grall
2021-12-06 16:45                                   ` Ian Jackson
2021-12-07  8:55                                     ` Jan Beulich
2021-12-07  9:11                                   ` Jan Beulich
2021-12-07  9:59                                     ` Julien Grall
2021-12-07 10:19                                       ` Jan Beulich
2021-12-07 12:00                                         ` Ian Jackson
2021-12-07 13:30                                           ` Jan Beulich
2021-11-19 10:21 ` [PATCH 2/7] xz: fix XZ_DYNALLOC to avoid useless memory reallocations Jan Beulich
2021-11-25 16:55   ` Julien Grall
2021-11-19 10:21 ` [PATCH 3/7] decompressors: fix spelling mistakes Jan Beulich
2021-11-25 16:57   ` Julien Grall
2021-11-19 10:22 ` [PATCH 4/7] xz: avoid overlapping memcpy() with invalid input with in-place decompression Jan Beulich
2021-11-19 10:22 ` [PATCH 5/7] xz: fix spelling in comments Jan Beulich
2021-11-19 10:23 ` [PATCH 6/7] xz: move s->lzma.len = 0 initialization to lzma_reset() Jan Beulich
2021-11-19 10:23 ` [PATCH 7/7] xz: validate the value before assigning it to an enum variable Jan Beulich
2021-11-19 14:25 ` Ian Jackson [this message]
2021-11-22  7:10   ` [PATCH 0/7] (mainly) xz imports from Linux Jan Beulich
2021-12-03 15:35 ` Luca Fancellu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24983.46063.379168.151942@mariner.uk.xensource.com \
    --to=iwj@xenproject.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.