All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs
Date: Fri, 2 Dec 2016 17:55:10 +0200	[thread overview]
Message-ID: <2b43face-7038-9029-8730-f82189e58bcf@ti.com> (raw)
In-Reply-To: <2844580.rlqx11OSCG@avalon>


[-- Attachment #1.1.1: Type: text/plain, Size: 675 bytes --]

On 02/12/16 17:42, Laurent Pinchart wrote:

> I can understand that (even if I'm not sure it's really an issue, and we 
> should really clean up the CRTC creation code at some point), but how about 
> adding a possible_crtcs field to the priv structure then ? I don't really like 
> having to pass it around through a bunch of functions.

It is passed to two functions, I'm not sure if that's a bunch =).

I can do as you suggest, but I don't like adding fields to structs for
things that we only need once. I think local variables and function
parameters are for that.

But I agree that the patch would be quite a bit smaller with the field,
so...

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-12-02 15:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 14:07 [PATCH 1/2] drm: fix possible_crtc's type Tomi Valkeinen
2016-12-02 14:07 ` [PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs Tomi Valkeinen
2016-12-02 14:16   ` Laurent Pinchart
2016-12-02 14:22     ` Tomi Valkeinen
2016-12-02 15:42       ` Laurent Pinchart
2016-12-02 15:55         ` Tomi Valkeinen [this message]
2016-12-02 15:56           ` Laurent Pinchart
2016-12-08 11:37             ` Tomi Valkeinen
2016-12-02 14:12 ` [PATCH 1/2] drm: fix possible_crtc's type Laurent Pinchart
2016-12-02 14:12 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b43face-7038-9029-8730-f82189e58bcf@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.