* [Buildroot] [PATCH] package/xr819-xradio: add patch to build with Linux > 5.12
@ 2022-01-17 21:07 Giulio Benetti
2022-01-17 21:50 ` Giulio Benetti
0 siblings, 1 reply; 11+ messages in thread
From: Giulio Benetti @ 2022-01-17 21:07 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Sergey Matyukevich
As explained in the local patch itself of_get_mac_address() has changed, so
we need to check against Linux version and use it slightly differently.
Patch is pending upstream:
https://github.com/fifteenhex/xradio/pull/15
I've realized only later there was already an opened PR for this, anyway
IMHO I think my patch is written a little better, so please accept it.
And most of all Sergey already tested it and it works:
https://lists.buildroot.org/pipermail/buildroot/2022-January/634084.html
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
...fix-building-with-Linux-version-5.12.patch | 68 +++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
diff --git a/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
new file mode 100644
index 0000000000..a1d91e2ff7
--- /dev/null
+++ b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
@@ -0,0 +1,68 @@
+From 990b19664488a8a3bb8d019a3a6b242dd8ad4c29 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Mon, 17 Jan 2022 12:26:00 +0100
+Subject: [PATCH] main.c: fix building with Linux version > 5.12
+
+of_get_mac_address() on Linux version > 5.12 requires mac pointer as second
+argument and return an int. So let's deal with it by checking linux version
+to make it compatible with both Linux version > 5.12 and not.
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ main.c | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/main.c b/main.c
+index b60e18d..d354521 100644
+--- a/main.c
++++ b/main.c
+@@ -13,6 +13,7 @@
+ #include <net/cfg80211.h>
+ #include <linux/of_net.h>
+ #include <linux/mmc/sdio_func.h>
++#include <linux/version.h>
+
+ #include "xradio.h"
+ #include "fwio.h"
+@@ -499,8 +500,12 @@ int xradio_core_init(struct sdio_func* func)
+ int if_id;
+ struct ieee80211_hw *dev;
+ struct xradio_common *hw_priv;
++#if LINUX_VERSION_CODE > KERNEL_VERSION(5, 12, 0)
++ unsigned char addr[ETH_ALEN];
++#else
+ unsigned char randomaddr[ETH_ALEN];
+ const unsigned char *addr = NULL;
++#endif
+
+ //init xradio_common
+ dev = xradio_init_common(sizeof(struct xradio_common));
+@@ -513,6 +518,16 @@ int xradio_core_init(struct sdio_func* func)
+ hw_priv->sdio_func = func;
+ sdio_set_drvdata(func, hw_priv);
+
++#if LINUX_VERSION_CODE > KERNEL_VERSION(5, 12, 0)
++ // fill in mac addresses
++ if (hw_priv->pdev->of_node) {
++ err = of_get_mac_address(hw_priv->pdev->of_node, addr);
++ }
++ if (err < 0) {
++ dev_warn(hw_priv->pdev, "no mac address provided, using random\n");
++ eth_random_addr(addr);
++ }
++#else
+ // fill in mac addresses
+ if (hw_priv->pdev->of_node) {
+ addr = of_get_mac_address(hw_priv->pdev->of_node);
+@@ -522,6 +537,8 @@ int xradio_core_init(struct sdio_func* func)
+ eth_random_addr(randomaddr);
+ addr = randomaddr;
+ }
++#endif
++
+ memcpy(hw_priv->addresses[0].addr, addr, ETH_ALEN);
+ memcpy(hw_priv->addresses[1].addr, addr, ETH_ALEN);
+ hw_priv->addresses[1].addr[5] += 0x01;
+--
+2.25.1
+
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/xr819-xradio: add patch to build with Linux > 5.12
2022-01-17 21:07 [Buildroot] [PATCH] package/xr819-xradio: add patch to build with Linux > 5.12 Giulio Benetti
@ 2022-01-17 21:50 ` Giulio Benetti
2022-01-18 6:35 ` [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13 Giulio Benetti
0 siblings, 1 reply; 11+ messages in thread
From: Giulio Benetti @ 2022-01-17 21:50 UTC (permalink / raw)
To: buildroot; +Cc: Sergey Kuzminov, Sergey Matyukevich
Hi All,
> Il giorno 17 gen 2022, alle ore 22:07, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto:
>
> As explained in the local patch itself of_get_mac_address() has changed, so
> we need to check against Linux version and use it slightly differently.
>
> Patch is pending upstream:
> https://github.com/fifteenhex/xradio/pull/15
> I've realized only later there was already an opened PR for this, anyway
> IMHO I think my patch is written a little better, so please accept it.
> And most of all Sergey already tested it and it works:
> https://lists.buildroot.org/pipermail/buildroot/2022-January/634084.html
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> ...fix-building-with-Linux-version-5.12.patch | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
>
> diff --git a/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
> new file mode 100644
> index 0000000000..a1d91e2ff7
> --- /dev/null
> +++ b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.12.patch
> @@ -0,0 +1,68 @@
> +From 990b19664488a8a3bb8d019a3a6b242dd8ad4c29 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Mon, 17 Jan 2022 12:26:00 +0100
> +Subject: [PATCH] main.c: fix building with Linux version > 5.12
> +
> +of_get_mac_address() on Linux version > 5.12 requires mac pointer as second
> +argument and return an int. So let's deal with it by checking linux version
> +to make it compatible with both Linux version > 5.12 and not.
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + main.c | 17 +++++++++++++++++
> + 1 file changed, 17 insertions(+)
> +
> +diff --git a/main.c b/main.c
> +index b60e18d..d354521 100644
> +--- a/main.c
> ++++ b/main.c
> +@@ -13,6 +13,7 @@
> + #include <net/cfg80211.h>
> + #include <linux/of_net.h>
> + #include <linux/mmc/sdio_func.h>
> ++#include <linux/version.h>
> +
> + #include "xradio.h"
> + #include "fwio.h"
> +@@ -499,8 +500,12 @@ int xradio_core_init(struct sdio_func* func)
> + int if_id;
> + struct ieee80211_hw *dev;
> + struct xradio_common *hw_priv;
> ++#if LINUX_VERSION_CODE > KERNEL_VERSION(5, 12, 0)
> ++ unsigned char addr[ETH_ALEN];
> ++#else
> + unsigned char randomaddr[ETH_ALEN];
> + const unsigned char *addr = NULL;
> ++#endif
> +
> + //init xradio_common
> + dev = xradio_init_common(sizeof(struct xradio_common));
> +@@ -513,6 +518,16 @@ int xradio_core_init(struct sdio_func* func)
> + hw_priv->sdio_func = func;
> + sdio_set_drvdata(func, hw_priv);
> +
> ++#if LINUX_VERSION_CODE > KERNEL_VERSION(5, 12, 0)
This ^^^ must be >= 5.13.
Need to send a v2 and update my PR.
Sorry for the noise
Giulio
> ++ // fill in mac addresses
> ++ if (hw_priv->pdev->of_node) {
> ++ err = of_get_mac_address(hw_priv->pdev->of_node, addr);
> ++ }
> ++ if (err < 0) {
> ++ dev_warn(hw_priv->pdev, "no mac address provided, using random\n");
> ++ eth_random_addr(addr);
> ++ }
> ++#else
> + // fill in mac addresses
> + if (hw_priv->pdev->of_node) {
> + addr = of_get_mac_address(hw_priv->pdev->of_node);
> +@@ -522,6 +537,8 @@ int xradio_core_init(struct sdio_func* func)
> + eth_random_addr(randomaddr);
> + addr = randomaddr;
> + }
> ++#endif
> ++
> + memcpy(hw_priv->addresses[0].addr, addr, ETH_ALEN);
> + memcpy(hw_priv->addresses[1].addr, addr, ETH_ALEN);
> + hw_priv->addresses[1].addr[5] += 0x01;
> +--
> +2.25.1
> +
> --
> 2.25.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13
2022-01-17 21:50 ` Giulio Benetti
@ 2022-01-18 6:35 ` Giulio Benetti
2022-01-18 17:45 ` Sergey Kuzminov
0 siblings, 1 reply; 11+ messages in thread
From: Giulio Benetti @ 2022-01-18 6:35 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Sergey Kuzminov, Sergey Matyukevich
As explained in the local patch itself of_get_mac_address() has changed, so
we need to check against Linux version and use it slightly differently.
Patch is pending upstream:
https://github.com/fifteenhex/xradio/pull/15
I've realized only later there was already an opened PR for this, anyway
IMHO I think my patch is written a little better, so please accept it.
And most of all Sergey already tested it and it works:
https://lists.buildroot.org/pipermail/buildroot/2022-January/634084.html
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* update local patch to build correctly also with Linux >= 5.12.1 < 5.13.0
---
...fix-building-with-Linux-version-5.13.patch | 68 +++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
diff --git a/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
new file mode 100644
index 0000000000..3b9742012e
--- /dev/null
+++ b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
@@ -0,0 +1,68 @@
+From 4873746fa9d42a8edbc1e192899e00c29ed3d32a Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Mon, 17 Jan 2022 12:26:00 +0100
+Subject: [PATCH] main.c: fix building with Linux version >= 5.13
+
+of_get_mac_address() on Linux version >= 5.13 requires mac pointer as
+second argument and return an int. So let's deal with it by checking linux
+version to make it compatible with both Linux version >= 5.13 and not.
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ main.c | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/main.c b/main.c
+index b60e18d..06cb1f6 100644
+--- a/main.c
++++ b/main.c
+@@ -13,6 +13,7 @@
+ #include <net/cfg80211.h>
+ #include <linux/of_net.h>
+ #include <linux/mmc/sdio_func.h>
++#include <linux/version.h>
+
+ #include "xradio.h"
+ #include "fwio.h"
+@@ -499,8 +500,12 @@ int xradio_core_init(struct sdio_func* func)
+ int if_id;
+ struct ieee80211_hw *dev;
+ struct xradio_common *hw_priv;
++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
++ unsigned char addr[ETH_ALEN];
++#else
+ unsigned char randomaddr[ETH_ALEN];
+ const unsigned char *addr = NULL;
++#endif
+
+ //init xradio_common
+ dev = xradio_init_common(sizeof(struct xradio_common));
+@@ -513,6 +518,16 @@ int xradio_core_init(struct sdio_func* func)
+ hw_priv->sdio_func = func;
+ sdio_set_drvdata(func, hw_priv);
+
++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
++ // fill in mac addresses
++ if (hw_priv->pdev->of_node) {
++ err = of_get_mac_address(hw_priv->pdev->of_node, addr);
++ }
++ if (err < 0) {
++ dev_warn(hw_priv->pdev, "no mac address provided, using random\n");
++ eth_random_addr(addr);
++ }
++#else
+ // fill in mac addresses
+ if (hw_priv->pdev->of_node) {
+ addr = of_get_mac_address(hw_priv->pdev->of_node);
+@@ -522,6 +537,8 @@ int xradio_core_init(struct sdio_func* func)
+ eth_random_addr(randomaddr);
+ addr = randomaddr;
+ }
++#endif
++
+ memcpy(hw_priv->addresses[0].addr, addr, ETH_ALEN);
+ memcpy(hw_priv->addresses[1].addr, addr, ETH_ALEN);
+ hw_priv->addresses[1].addr[5] += 0x01;
+--
+2.25.1
+
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13
2022-01-18 6:35 ` [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13 Giulio Benetti
@ 2022-01-18 17:45 ` Sergey Kuzminov
2022-01-18 17:53 ` Giulio Benetti
0 siblings, 1 reply; 11+ messages in thread
From: Sergey Kuzminov @ 2022-01-18 17:45 UTC (permalink / raw)
To: Giulio Benetti, buildroot
Hi All, Giulio.
I checked the patch, everything works.
18.01.2022 09:35, Giulio Benetti пишет:
> As explained in the local patch itself of_get_mac_address() has changed, so
> we need to check against Linux version and use it slightly differently.
>
> Patch is pending upstream:
> https://github.com/fifteenhex/xradio/pull/15
> I've realized only later there was already an opened PR for this, anyway
> IMHO I think my patch is written a little better, so please accept it.
> And most of all Sergey already tested it and it works:
> https://lists.buildroot.org/pipermail/buildroot/2022-January/634084.html
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * update local patch to build correctly also with Linux >= 5.12.1 < 5.13.0
> ---
> ...fix-building-with-Linux-version-5.13.patch | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
>
> diff --git a/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
> new file mode 100644
> index 0000000000..3b9742012e
> --- /dev/null
> +++ b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
> @@ -0,0 +1,68 @@
> +From 4873746fa9d42a8edbc1e192899e00c29ed3d32a Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Mon, 17 Jan 2022 12:26:00 +0100
> +Subject: [PATCH] main.c: fix building with Linux version >= 5.13
> +
> +of_get_mac_address() on Linux version >= 5.13 requires mac pointer as
> +second argument and return an int. So let's deal with it by checking linux
> +version to make it compatible with both Linux version >= 5.13 and not.
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + main.c | 17 +++++++++++++++++
> + 1 file changed, 17 insertions(+)
> +
> +diff --git a/main.c b/main.c
> +index b60e18d..06cb1f6 100644
> +--- a/main.c
> ++++ b/main.c
> +@@ -13,6 +13,7 @@
> + #include <net/cfg80211.h>
> + #include <linux/of_net.h>
> + #include <linux/mmc/sdio_func.h>
> ++#include <linux/version.h>
> +
> + #include "xradio.h"
> + #include "fwio.h"
> +@@ -499,8 +500,12 @@ int xradio_core_init(struct sdio_func* func)
> + int if_id;
> + struct ieee80211_hw *dev;
> + struct xradio_common *hw_priv;
> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
> ++ unsigned char addr[ETH_ALEN];
> ++#else
> + unsigned char randomaddr[ETH_ALEN];
> + const unsigned char *addr = NULL;
> ++#endif
> +
> + //init xradio_common
> + dev = xradio_init_common(sizeof(struct xradio_common));
> +@@ -513,6 +518,16 @@ int xradio_core_init(struct sdio_func* func)
> + hw_priv->sdio_func = func;
> + sdio_set_drvdata(func, hw_priv);
> +
> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
> ++ // fill in mac addresses
> ++ if (hw_priv->pdev->of_node) {
> ++ err = of_get_mac_address(hw_priv->pdev->of_node, addr);
> ++ }
> ++ if (err < 0) {
> ++ dev_warn(hw_priv->pdev, "no mac address provided, using random\n");
> ++ eth_random_addr(addr);
> ++ }
> ++#else
> + // fill in mac addresses
> + if (hw_priv->pdev->of_node) {
> + addr = of_get_mac_address(hw_priv->pdev->of_node);
> +@@ -522,6 +537,8 @@ int xradio_core_init(struct sdio_func* func)
> + eth_random_addr(randomaddr);
> + addr = randomaddr;
> + }
> ++#endif
> ++
> + memcpy(hw_priv->addresses[0].addr, addr, ETH_ALEN);
> + memcpy(hw_priv->addresses[1].addr, addr, ETH_ALEN);
> + hw_priv->addresses[1].addr[5] += 0x01;
> +--
> +2.25.1
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13
2022-01-18 17:45 ` Sergey Kuzminov
@ 2022-01-18 17:53 ` Giulio Benetti
2022-01-18 18:10 ` Sergey Kuzminov
0 siblings, 1 reply; 11+ messages in thread
From: Giulio Benetti @ 2022-01-18 17:53 UTC (permalink / raw)
To: Sergey Kuzminov, buildroot
Hi Sergey,
On 18/01/22 18:45, Sergey Kuzminov wrote:
> Hi All, Giulio.
> I checked the patch, everything works.
Can you please place your:
Tested-by: Name Surname <e-mail>
?
--
Giulio Benetti
Benetti Engineering sas
> 18.01.2022 09:35, Giulio Benetti пишет:
>> As explained in the local patch itself of_get_mac_address() has changed, so
>> we need to check against Linux version and use it slightly differently.
>>
>> Patch is pending upstream:
>> https://github.com/fifteenhex/xradio/pull/15
>> I've realized only later there was already an opened PR for this, anyway
>> IMHO I think my patch is written a little better, so please accept it.
>> And most of all Sergey already tested it and it works:
>> https://lists.buildroot.org/pipermail/buildroot/2022-January/634084.html
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> V1->V2:
>> * update local patch to build correctly also with Linux >= 5.12.1 < 5.13.0
>> ---
>> ...fix-building-with-Linux-version-5.13.patch | 68 +++++++++++++++++++
>> 1 file changed, 68 insertions(+)
>> create mode 100644 package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
>>
>> diff --git a/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
>> new file mode 100644
>> index 0000000000..3b9742012e
>> --- /dev/null
>> +++ b/package/xr819-xradio/0001-main.c-fix-building-with-Linux-version-5.13.patch
>> @@ -0,0 +1,68 @@
>> +From 4873746fa9d42a8edbc1e192899e00c29ed3d32a Mon Sep 17 00:00:00 2001
>> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +Date: Mon, 17 Jan 2022 12:26:00 +0100
>> +Subject: [PATCH] main.c: fix building with Linux version >= 5.13
>> +
>> +of_get_mac_address() on Linux version >= 5.13 requires mac pointer as
>> +second argument and return an int. So let's deal with it by checking linux
>> +version to make it compatible with both Linux version >= 5.13 and not.
>> +
>> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +---
>> + main.c | 17 +++++++++++++++++
>> + 1 file changed, 17 insertions(+)
>> +
>> +diff --git a/main.c b/main.c
>> +index b60e18d..06cb1f6 100644
>> +--- a/main.c
>> ++++ b/main.c
>> +@@ -13,6 +13,7 @@
>> + #include <net/cfg80211.h>
>> + #include <linux/of_net.h>
>> + #include <linux/mmc/sdio_func.h>
>> ++#include <linux/version.h>
>> +
>> + #include "xradio.h"
>> + #include "fwio.h"
>> +@@ -499,8 +500,12 @@ int xradio_core_init(struct sdio_func* func)
>> + int if_id;
>> + struct ieee80211_hw *dev;
>> + struct xradio_common *hw_priv;
>> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
>> ++ unsigned char addr[ETH_ALEN];
>> ++#else
>> + unsigned char randomaddr[ETH_ALEN];
>> + const unsigned char *addr = NULL;
>> ++#endif
>> +
>> + //init xradio_common
>> + dev = xradio_init_common(sizeof(struct xradio_common));
>> +@@ -513,6 +518,16 @@ int xradio_core_init(struct sdio_func* func)
>> + hw_priv->sdio_func = func;
>> + sdio_set_drvdata(func, hw_priv);
>> +
>> ++#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 13, 0)
>> ++ // fill in mac addresses
>> ++ if (hw_priv->pdev->of_node) {
>> ++ err = of_get_mac_address(hw_priv->pdev->of_node, addr);
>> ++ }
>> ++ if (err < 0) {
>> ++ dev_warn(hw_priv->pdev, "no mac address provided, using random\n");
>> ++ eth_random_addr(addr);
>> ++ }
>> ++#else
>> + // fill in mac addresses
>> + if (hw_priv->pdev->of_node) {
>> + addr = of_get_mac_address(hw_priv->pdev->of_node);
>> +@@ -522,6 +537,8 @@ int xradio_core_init(struct sdio_func* func)
>> + eth_random_addr(randomaddr);
>> + addr = randomaddr;
>> + }
>> ++#endif
>> ++
>> + memcpy(hw_priv->addresses[0].addr, addr, ETH_ALEN);
>> + memcpy(hw_priv->addresses[1].addr, addr, ETH_ALEN);
>> + hw_priv->addresses[1].addr[5] += 0x01;
>> +--
>> +2.25.1
>> +
>
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13
2022-01-18 17:53 ` Giulio Benetti
@ 2022-01-18 18:10 ` Sergey Kuzminov
2022-01-21 10:14 ` Giulio Benetti
0 siblings, 1 reply; 11+ messages in thread
From: Sergey Kuzminov @ 2022-01-18 18:10 UTC (permalink / raw)
To: Giulio Benetti, buildroot
Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
18.01.2022 20:53, Giulio Benetti пишет:
> Hi Sergey,
>
> On 18/01/22 18:45, Sergey Kuzminov wrote:
>> Hi All, Giulio.
>> I checked the patch, everything works.
>
> Can you please place your:
> Tested-by: Name Surname <e-mail>
> ?
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13
2022-01-18 18:10 ` Sergey Kuzminov
@ 2022-01-21 10:14 ` Giulio Benetti
2022-01-21 10:33 ` [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building Giulio Benetti
0 siblings, 1 reply; 11+ messages in thread
From: Giulio Benetti @ 2022-01-21 10:14 UTC (permalink / raw)
To: Sergey Kuzminov, buildroot
Hi All,
please drop this patch since the local patch has been upstreamed:
https://github.com/fifteenhex/xradio/commit/4873746fa9d42a8edbc1e192899e00c29ed3d32a
So I'm going to send a package bump soon that I ask Sergey to test.
Thank you!
Best regards
--
Giulio Benetti
Benetti Engineering sas
On 18/01/22 19:10, Sergey Kuzminov wrote:
> Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
>
> 18.01.2022 20:53, Giulio Benetti пишет:
>> Hi Sergey,
>>
>> On 18/01/22 18:45, Sergey Kuzminov wrote:
>>> Hi All, Giulio.
>>> I checked the patch, everything works.
>>
>> Can you please place your:
>> Tested-by: Name Surname <e-mail>
>> ?
>>
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building
2022-01-21 10:14 ` Giulio Benetti
@ 2022-01-21 10:33 ` Giulio Benetti
2022-01-21 16:43 ` Sergey Kuzminov
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Giulio Benetti @ 2022-01-21 10:33 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Sergey Kuzminov, Sergey Matyukevich
Pending PR is now merged[1] and it fixes Linux >= 5.13 building. So let's
bump xr819-xradio version.
[1]: https://github.com/fifteenhex/xradio/pull/15
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/xr819-xradio/xr819-xradio.hash | 4 ++--
package/xr819-xradio/xr819-xradio.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/xr819-xradio/xr819-xradio.hash b/package/xr819-xradio/xr819-xradio.hash
index efff92ab7d..4a77db0d1a 100644
--- a/package/xr819-xradio/xr819-xradio.hash
+++ b/package/xr819-xradio/xr819-xradio.hash
@@ -1,4 +1,4 @@
# Locally computed
-sha256 5900821a777b9008d7cf9b8128e0cb75a4623ecb608b45438e17c7a056cde1bf xr819-xradio-6bf0e2e21c80456e2a3d4ad1267caecde7165871.tar.gz
+sha256 06b91b1fcf98a261125b4d599ffcce2458fb9d0c1f38a4bd432a622b446f0f51 xr819-xradio-16180b6308e3c5dc42a92a663adf669028087ff7.tar.gz
# Locally computed
-sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
+sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
diff --git a/package/xr819-xradio/xr819-xradio.mk b/package/xr819-xradio/xr819-xradio.mk
index c1fe3295b6..5f60be887c 100644
--- a/package/xr819-xradio/xr819-xradio.mk
+++ b/package/xr819-xradio/xr819-xradio.mk
@@ -4,7 +4,7 @@
#
################################################################################
-XR819_XRADIO_VERSION = 6bf0e2e21c80456e2a3d4ad1267caecde7165871
+XR819_XRADIO_VERSION = 16180b6308e3c5dc42a92a663adf669028087ff7
XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
XR819_XRADIO_LICENSE = GPL-2.0
XR819_XRADIO_LICENSE_FILES = LICENSE
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building
2022-01-21 10:33 ` [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building Giulio Benetti
@ 2022-01-21 16:43 ` Sergey Kuzminov
2022-01-21 16:45 ` Sergey Kuzminov
2022-01-22 12:16 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Sergey Kuzminov @ 2022-01-21 16:43 UTC (permalink / raw)
To: buildroot
21.01.2022 13:33, Giulio Benetti пишет:
> Pending PR is now merged[1] and it fixes Linux >= 5.13 building. So let's
> bump xr819-xradio version.
>
> [1]: https://github.com/fifteenhex/xradio/pull/15
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/xr819-xradio/xr819-xradio.hash | 4 ++--
> package/xr819-xradio/xr819-xradio.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/xr819-xradio/xr819-xradio.hash b/package/xr819-xradio/xr819-xradio.hash
> index efff92ab7d..4a77db0d1a 100644
> --- a/package/xr819-xradio/xr819-xradio.hash
> +++ b/package/xr819-xradio/xr819-xradio.hash
> @@ -1,4 +1,4 @@
> # Locally computed
> -sha256 5900821a777b9008d7cf9b8128e0cb75a4623ecb608b45438e17c7a056cde1bf xr819-xradio-6bf0e2e21c80456e2a3d4ad1267caecde7165871.tar.gz
> +sha256 06b91b1fcf98a261125b4d599ffcce2458fb9d0c1f38a4bd432a622b446f0f51 xr819-xradio-16180b6308e3c5dc42a92a663adf669028087ff7.tar.gz
> # Locally computed
> -sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
> +sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
> diff --git a/package/xr819-xradio/xr819-xradio.mk b/package/xr819-xradio/xr819-xradio.mk
> index c1fe3295b6..5f60be887c 100644
> --- a/package/xr819-xradio/xr819-xradio.mk
> +++ b/package/xr819-xradio/xr819-xradio.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -XR819_XRADIO_VERSION = 6bf0e2e21c80456e2a3d4ad1267caecde7165871
> +XR819_XRADIO_VERSION = 16180b6308e3c5dc42a92a663adf669028087ff7
> XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
> XR819_XRADIO_LICENSE = GPL-2.0
> XR819_XRADIO_LICENSE_FILES = LICENSE
Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building
2022-01-21 10:33 ` [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building Giulio Benetti
2022-01-21 16:43 ` Sergey Kuzminov
@ 2022-01-21 16:45 ` Sergey Kuzminov
2022-01-22 12:16 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Sergey Kuzminov @ 2022-01-21 16:45 UTC (permalink / raw)
To: Giulio Benetti, buildroot; +Cc: Sergey Matyukevich
21.01.2022 13:33, Giulio Benetti:
> Pending PR is now merged[1] and it fixes Linux >= 5.13 building. So let's
> bump xr819-xradio version.
>
> [1]: https://github.com/fifteenhex/xradio/pull/15
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/xr819-xradio/xr819-xradio.hash | 4 ++--
> package/xr819-xradio/xr819-xradio.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/xr819-xradio/xr819-xradio.hash b/package/xr819-xradio/xr819-xradio.hash
> index efff92ab7d..4a77db0d1a 100644
> --- a/package/xr819-xradio/xr819-xradio.hash
> +++ b/package/xr819-xradio/xr819-xradio.hash
> @@ -1,4 +1,4 @@
> # Locally computed
> -sha256 5900821a777b9008d7cf9b8128e0cb75a4623ecb608b45438e17c7a056cde1bf xr819-xradio-6bf0e2e21c80456e2a3d4ad1267caecde7165871.tar.gz
> +sha256 06b91b1fcf98a261125b4d599ffcce2458fb9d0c1f38a4bd432a622b446f0f51 xr819-xradio-16180b6308e3c5dc42a92a663adf669028087ff7.tar.gz
> # Locally computed
> -sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
> +sha256 db296f2f7f35bca3a174efb0eb392b3b17bd94b341851429a3dff411b1c2fc73 LICENSE
> diff --git a/package/xr819-xradio/xr819-xradio.mk b/package/xr819-xradio/xr819-xradio.mk
> index c1fe3295b6..5f60be887c 100644
> --- a/package/xr819-xradio/xr819-xradio.mk
> +++ b/package/xr819-xradio/xr819-xradio.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -XR819_XRADIO_VERSION = 6bf0e2e21c80456e2a3d4ad1267caecde7165871
> +XR819_XRADIO_VERSION = 16180b6308e3c5dc42a92a663adf669028087ff7
> XR819_XRADIO_SITE = $(call github,fifteenhex,xradio,$(XR819_XRADIO_VERSION))
> XR819_XRADIO_LICENSE = GPL-2.0
> XR819_XRADIO_LICENSE_FILES = LICENSE
Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building
2022-01-21 10:33 ` [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building Giulio Benetti
2022-01-21 16:43 ` Sergey Kuzminov
2022-01-21 16:45 ` Sergey Kuzminov
@ 2022-01-22 12:16 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2022-01-22 12:16 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Sergey Kuzminov, Sergey Matyukevich, buildroot
On Fri, 21 Jan 2022 11:33:02 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Pending PR is now merged[1] and it fixes Linux >= 5.13 building. So let's
> bump xr819-xradio version.
>
> [1]: https://github.com/fifteenhex/xradio/pull/15
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/xr819-xradio/xr819-xradio.hash | 4 ++--
> package/xr819-xradio/xr819-xradio.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-01-22 12:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 21:07 [Buildroot] [PATCH] package/xr819-xradio: add patch to build with Linux > 5.12 Giulio Benetti
2022-01-17 21:50 ` Giulio Benetti
2022-01-18 6:35 ` [Buildroot] [PATCH v2] package/xr819-xradio: add patch to build with Linux >= 5.13 Giulio Benetti
2022-01-18 17:45 ` Sergey Kuzminov
2022-01-18 17:53 ` Giulio Benetti
2022-01-18 18:10 ` Sergey Kuzminov
2022-01-21 10:14 ` Giulio Benetti
2022-01-21 10:33 ` [Buildroot] [PATCH] package/xr819-xradio: bump to latest version to fix Linux >= 5.13 building Giulio Benetti
2022-01-21 16:43 ` Sergey Kuzminov
2022-01-21 16:45 ` Sergey Kuzminov
2022-01-22 12:16 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.