All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	arcml <linux-snps-arc@lists.infradead.org>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH 4/5] ARC: add support for DSP-enabled userspace applications
Date: Thu, 9 Jan 2020 22:46:09 +0000	[thread overview]
Message-ID: <2bc415e2-b6fe-f00b-9715-10a58f8b7a00@synopsys.com> (raw)
In-Reply-To: <BY5PR12MB403419E2722BE80E329D3409DE390@BY5PR12MB4034.namprd12.prod.outlook.com>

On 1/9/20 11:01 AM, Eugeniy Paltsev wrote:
> Hi Vineet,
>
>> From: Vineet Gupta <vgupta@synopsys.com>
>> On 12/27/19 10:03 AM, Eugeniy Paltsev wrote:
>>> To be able to run DSP-enabled userspace applications we need to
>>> save and restore following DSP-related registers:
>>> At IRQ/exception entry/exit:
>>>  * ACC0_GLO, ACC0_GHI, DSP_CTRL
>>>  * ACC0_LO, ACC0_HI (we already save them as r58, r59 pair)
>>> At context switch:
>>>  * DSP_BFLY0, DSP_FFT_CTRL
> [snip]
>>> +
>>> +#ifndef __ASSEMBLY__
>>> +
>>> +/* some defines to simplify config sanitize in kernel/setup.c */
>>> +#if defined(CONFIG_ARC_DSP_KERNEL)    || \
>>> +    defined(CONFIG_ARC_DSP_USERSPACE)
>>> +#define ARC_DSP_HANDLED                      1
>>> +#else
>>> +#define ARC_DSP_HANDLED                      0
>>> +#endif
>> This is a really bad idea - u r introducing explicit include dependencies which
>> can change even outside of arch changes !
>> We've dealt with enough of these problems with current.h, so best to avoid, even
>> if there is some code clutter.
> Hmm, would it be OK if I add this option as a private kconfig option?
> I.E (for ARC_DSP_HANDLED):

Yes that would be good.

-Vineet


WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: arcml <linux-snps-arc@lists.infradead.org>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ARC: add support for DSP-enabled userspace applications
Date: Thu, 9 Jan 2020 22:46:09 +0000	[thread overview]
Message-ID: <2bc415e2-b6fe-f00b-9715-10a58f8b7a00@synopsys.com> (raw)
In-Reply-To: <BY5PR12MB403419E2722BE80E329D3409DE390@BY5PR12MB4034.namprd12.prod.outlook.com>

On 1/9/20 11:01 AM, Eugeniy Paltsev wrote:
> Hi Vineet,
>
>> From: Vineet Gupta <vgupta@synopsys.com>
>> On 12/27/19 10:03 AM, Eugeniy Paltsev wrote:
>>> To be able to run DSP-enabled userspace applications we need to
>>> save and restore following DSP-related registers:
>>> At IRQ/exception entry/exit:
>>>  * ACC0_GLO, ACC0_GHI, DSP_CTRL
>>>  * ACC0_LO, ACC0_HI (we already save them as r58, r59 pair)
>>> At context switch:
>>>  * DSP_BFLY0, DSP_FFT_CTRL
> [snip]
>>> +
>>> +#ifndef __ASSEMBLY__
>>> +
>>> +/* some defines to simplify config sanitize in kernel/setup.c */
>>> +#if defined(CONFIG_ARC_DSP_KERNEL)    || \
>>> +    defined(CONFIG_ARC_DSP_USERSPACE)
>>> +#define ARC_DSP_HANDLED                      1
>>> +#else
>>> +#define ARC_DSP_HANDLED                      0
>>> +#endif
>> This is a really bad idea - u r introducing explicit include dependencies which
>> can change even outside of arch changes !
>> We've dealt with enough of these problems with current.h, so best to avoid, even
>> if there is some code clutter.
> Hmm, would it be OK if I add this option as a private kconfig option?
> I.E (for ARC_DSP_HANDLED):

Yes that would be good.

-Vineet

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  reply	other threads:[~2020-01-09 22:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27 18:03 [RFC 0/5] ARC: handle DSP presence in HW Eugeniy Paltsev
2019-12-27 18:03 ` Eugeniy Paltsev
2019-12-27 18:03 ` [PATCH 1/5] ARC: pt_regs: remove hardcoded registers offset Eugeniy Paltsev
2019-12-27 18:03   ` Eugeniy Paltsev
2019-12-28 21:06   ` Vineet Gupta
2019-12-28 21:06     ` Vineet Gupta
2019-12-27 18:03 ` [PATCH 2/5] ARC: add helpers to sanitize config options Eugeniy Paltsev
2019-12-27 18:03   ` Eugeniy Paltsev
2020-01-06 22:47   ` Vineet Gupta
2020-01-06 22:47     ` Vineet Gupta
2019-12-27 18:03 ` [PATCH 3/5] ARC: handle DSP presence in HW Eugeniy Paltsev
2019-12-27 18:03   ` Eugeniy Paltsev
2020-01-07  1:03   ` Vineet Gupta
2020-01-07  1:03     ` Vineet Gupta
2020-01-07  1:30     ` Vineet Gupta
2020-01-07  1:30       ` Vineet Gupta
2020-01-10 14:54     ` Eugeniy Paltsev
2020-01-10 14:54       ` Eugeniy Paltsev
2020-01-13 16:49       ` Vineet Gupta
2020-01-13 16:49         ` Vineet Gupta
2019-12-27 18:03 ` [PATCH 4/5] ARC: add support for DSP-enabled userspace applications Eugeniy Paltsev
2019-12-27 18:03   ` Eugeniy Paltsev
2020-01-07 18:25   ` Vineet Gupta
2020-01-07 18:25     ` Vineet Gupta
2020-01-09 19:01     ` Eugeniy Paltsev
2020-01-09 19:01       ` Eugeniy Paltsev
2020-01-09 22:46       ` Vineet Gupta [this message]
2020-01-09 22:46         ` Vineet Gupta
2020-03-04 11:51     ` Eugeniy Paltsev
2020-03-04 11:51       ` Eugeniy Paltsev
2020-03-04 17:58       ` Vineet Gupta
2020-03-04 17:58         ` Vineet Gupta
2019-12-27 18:03 ` [PATCH 5/5] ARC: allow userspace DSP applications to use AGU extensions Eugeniy Paltsev
2019-12-27 18:03   ` Eugeniy Paltsev
2020-01-07 18:30   ` Vineet Gupta
2020-01-07 18:30     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bc415e2-b6fe-f00b-9715-10a58f8b7a00@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.