* Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-14 10:52 ` linmiaohe
0 siblings, 0 replies; 6+ messages in thread
From: linmiaohe @ 2020-09-14 10:52 UTC (permalink / raw)
To: Michal Hocko; +Cc: hannes, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel
Michal Hocko <mhocko@suse.com> wrote:
> On Sun 13-09-20 05:41:29, Miaohe Lin wrote:
>> Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
>> usage/max"), the arg @reclaim has no priority field anymore.
>
>The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean up reclaim iter array")
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
>Other than that
>Acked-by: Michal Hocko <mhocko@suse.com>
>
Many thanks for your ack. I have resend the one yesterday:
https://lkml.org/lkml/2020/9/13/69
>
>> ---
>> mm/memcontrol.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-14 10:52 ` linmiaohe
0 siblings, 0 replies; 6+ messages in thread
From: linmiaohe @ 2020-09-14 10:52 UTC (permalink / raw)
To: Michal Hocko
Cc: hannes-druUgvl0LCNAfugRpC6u6w,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> wrote:
> On Sun 13-09-20 05:41:29, Miaohe Lin wrote:
>> Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
>> usage/max"), the arg @reclaim has no priority field anymore.
>
>The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean up reclaim iter array")
>>
>> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>
>Other than that
>Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
>
Many thanks for your ack. I have resend the one yesterday:
https://lkml.org/lkml/2020/9/13/69
>
>> ---
>> mm/memcontrol.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-14 10:46 ` Michal Hocko
0 siblings, 0 replies; 6+ messages in thread
From: Michal Hocko @ 2020-09-14 10:46 UTC (permalink / raw)
To: Miaohe Lin; +Cc: hannes, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel
On Sun 13-09-20 05:41:29, Miaohe Lin wrote:
> Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
> usage/max"), the arg @reclaim has no priority field anymore.
The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean
up reclaim iter array")
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Other than that
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memcontrol.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 75cd1a1e66c8..a57aa0f42d40 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void)
> * invocations for reference counting, or use mem_cgroup_iter_break()
> * to cancel a hierarchy walk before the round-trip is complete.
> *
> - * Reclaimers can specify a node and a priority level in @reclaim to
> - * divide up the memcgs in the hierarchy among all concurrent
> - * reclaimers operating on the same node and priority.
> + * Reclaimers can specify a node in @reclaim to divide up the memcgs
> + * in the hierarchy among all concurrent reclaimers operating on the
> + * same node.
> */
> struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> struct mem_cgroup *prev,
> --
> 2.19.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-14 10:46 ` Michal Hocko
0 siblings, 0 replies; 6+ messages in thread
From: Michal Hocko @ 2020-09-14 10:46 UTC (permalink / raw)
To: Miaohe Lin
Cc: hannes-druUgvl0LCNAfugRpC6u6w,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sun 13-09-20 05:41:29, Miaohe Lin wrote:
> Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
> usage/max"), the arg @reclaim has no priority field anymore.
The priority field has been removed by 9da83f3fc74b ("mm, memcg: clean
up reclaim iter array")
>
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Other than that
Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
> ---
> mm/memcontrol.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 75cd1a1e66c8..a57aa0f42d40 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void)
> * invocations for reference counting, or use mem_cgroup_iter_break()
> * to cancel a hierarchy walk before the round-trip is complete.
> *
> - * Reclaimers can specify a node and a priority level in @reclaim to
> - * divide up the memcgs in the hierarchy among all concurrent
> - * reclaimers operating on the same node and priority.
> + * Reclaimers can specify a node in @reclaim to divide up the memcgs
> + * in the hierarchy among all concurrent reclaimers operating on the
> + * same node.
> */
> struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> struct mem_cgroup *prev,
> --
> 2.19.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-13 9:41 ` Miaohe Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2020-09-13 9:41 UTC (permalink / raw)
To: hannes, mhocko, vdavydov.dev, akpm
Cc: cgroups, linux-mm, linux-kernel, linmiaohe
Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
usage/max"), the arg @reclaim has no priority field anymore.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memcontrol.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 75cd1a1e66c8..a57aa0f42d40 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void)
* invocations for reference counting, or use mem_cgroup_iter_break()
* to cancel a hierarchy walk before the round-trip is complete.
*
- * Reclaimers can specify a node and a priority level in @reclaim to
- * divide up the memcgs in the hierarchy among all concurrent
- * reclaimers operating on the same node and priority.
+ * Reclaimers can specify a node in @reclaim to divide up the memcgs
+ * in the hierarchy among all concurrent reclaimers operating on the
+ * same node.
*/
struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
struct mem_cgroup *prev,
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter()
@ 2020-09-13 9:41 ` Miaohe Lin
0 siblings, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2020-09-13 9:41 UTC (permalink / raw)
To: hannes-druUgvl0LCNAfugRpC6u6w, mhocko-DgEjT+Ai2ygdnm+yROfE0A,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linmiaohe-hv44wF8Li93QT0dZR+AlfA
Since commit bbec2e15170a ("mm: rename page_counter's count/limit into
usage/max"), the arg @reclaim has no priority field anymore.
Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
mm/memcontrol.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 75cd1a1e66c8..a57aa0f42d40 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1138,9 +1138,9 @@ static __always_inline struct mem_cgroup *get_mem_cgroup_from_current(void)
* invocations for reference counting, or use mem_cgroup_iter_break()
* to cancel a hierarchy walk before the round-trip is complete.
*
- * Reclaimers can specify a node and a priority level in @reclaim to
- * divide up the memcgs in the hierarchy among all concurrent
- * reclaimers operating on the same node and priority.
+ * Reclaimers can specify a node in @reclaim to divide up the memcgs
+ * in the hierarchy among all concurrent reclaimers operating on the
+ * same node.
*/
struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
struct mem_cgroup *prev,
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-14 10:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 10:52 [PATCH] mm: memcontrol: Correct the comment of mem_cgroup_iter() linmiaohe
2020-09-14 10:52 ` linmiaohe
-- strict thread matches above, loose matches on Subject: below --
2020-09-13 9:41 Miaohe Lin
2020-09-13 9:41 ` Miaohe Lin
2020-09-14 10:46 ` Michal Hocko
2020-09-14 10:46 ` Michal Hocko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.