[PATCH] configure: Add -Werror to avx2, avx512 tests

[PATCH] configure: Add -Werror to avx2, avx512 tests

[Richard Henderson]

When using clang, we get

ERROR: configure test passed without -Werror but failed with -Werror.
       This is probably a bug in the configure script. The failing command
       will be at the bottom of config.log.
       You can run configure with --disable-werror to bypass this check.

What we really want from these two tests is whether the
entire code sequence is supported, including pragmas.
Adding -Werror makes the test properly fail for clang.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 63f38fa94c..cf4616f635 100755
--- a/configure
+++ b/configure
@@ -3884,7 +3884,7 @@ static int bar(void *a) {
 }
 int main(int argc, char *argv[]) { return bar(argv[0]); }
 EOF
-  if compile_object "" ; then
+  if compile_object "-Werror" ; then
     avx2_opt="yes"
   else
     avx2_opt="no"
@@ -3914,7 +3914,7 @@ int main(int argc, char *argv[])
 	return bar(argv[0]);
 }
 EOF
-  if ! compile_object "" ; then
+  if ! compile_object "-Werror" ; then
     avx512f_opt="no"
   fi
 else
-- 
2.25.1

Re: [PATCH] configure: Add -Werror to avx2, avx512 tests

[Paolo Bonzini]

On 19/07/21 22:01, Richard Henderson wrote:
> When using clang, we get
> 
> ERROR: configure test passed without -Werror but failed with -Werror.
>         This is probably a bug in the configure script. The failing command
>         will be at the bottom of config.log.
>         You can run configure with --disable-werror to bypass this check.
> 
> What we really want from these two tests is whether the
> entire code sequence is supported, including pragmas.
> Adding -Werror makes the test properly fail for clang.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 63f38fa94c..cf4616f635 100755
> --- a/configure
> +++ b/configure
> @@ -3884,7 +3884,7 @@ static int bar(void *a) {
>   }
>   int main(int argc, char *argv[]) { return bar(argv[0]); }
>   EOF
> -  if compile_object "" ; then
> +  if compile_object "-Werror" ; then
>       avx2_opt="yes"
>     else
>       avx2_opt="no"
> @@ -3914,7 +3914,7 @@ int main(int argc, char *argv[])
>   	return bar(argv[0]);
>   }
>   EOF
> -  if ! compile_object "" ; then
> +  if ! compile_object "-Werror" ; then
>       avx512f_opt="no"
>     fi
>   else
> 

Queued, thanks.

Paolo