* [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight
@ 2023-10-05 8:40 James Clark
2023-10-05 12:08 ` Mike Leach
0 siblings, 1 reply; 4+ messages in thread
From: James Clark @ 2023-10-05 8:40 UTC (permalink / raw)
To: gregkh, coresight, linux-kernel
Cc: suzuki.poulose, mike.leach, leo.yan, namhyung, atrajeev, James Clark
There are a few files missing from the list like test_arm_coresight.sh
and arm-coresight.txt. These could be picked up just with a name match.
Signed-off-by: James Clark <james.clark@arm.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 90f13281d297..3ee45066b7e4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2066,6 +2066,7 @@ F: tools/perf/arch/arm/util/pmu.c
F: tools/perf/tests/shell/coresight/*
F: tools/perf/util/cs-etm-decoder/*
F: tools/perf/util/cs-etm.*
+N: coresight
ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
M: Hans Ulli Kroll <ulli.kroll@googlemail.com>
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight
2023-10-05 8:40 [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight James Clark
@ 2023-10-05 12:08 ` Mike Leach
2023-10-05 12:42 ` James Clark
0 siblings, 1 reply; 4+ messages in thread
From: Mike Leach @ 2023-10-05 12:08 UTC (permalink / raw)
To: James Clark
Cc: gregkh, coresight, linux-kernel, suzuki.poulose, leo.yan,
namhyung, atrajeev
Won't this also pick up....
drivers/accel/habanalabs/gaudi/gaudi_coresight.c
?
Which isn't part of anything we maintain
On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>
> There are a few files missing from the list like test_arm_coresight.sh
> and arm-coresight.txt. These could be picked up just with a name match.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..3ee45066b7e4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2066,6 +2066,7 @@ F: tools/perf/arch/arm/util/pmu.c
> F: tools/perf/tests/shell/coresight/*
> F: tools/perf/util/cs-etm-decoder/*
> F: tools/perf/util/cs-etm.*
> +N: coresight
>
> ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
> M: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> --
> 2.34.1
>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight
2023-10-05 12:08 ` Mike Leach
@ 2023-10-05 12:42 ` James Clark
2023-10-05 12:56 ` Suzuki K Poulose
0 siblings, 1 reply; 4+ messages in thread
From: James Clark @ 2023-10-05 12:42 UTC (permalink / raw)
To: Mike Leach
Cc: gregkh, coresight, linux-kernel, suzuki.poulose, leo.yan,
namhyung, atrajeev
On 05/10/2023 13:08, Mike Leach wrote:
> Won't this also pick up....
>
> drivers/accel/habanalabs/gaudi/gaudi_coresight.c
>
> ?
>
> Which isn't part of anything we maintain
>
Ah ok I did try to check for other non Arm Coresight files with
Coresight in the name and didn't find any, but I must have missed that one.
I will just explicitly add the missing ones instead.
Although on further inspection it does seem to be related to some Arm
Coresight implementation, although not one that fits in the existing
Perf or Coresight driver framework. So I'm not sure if there could ever
be any sharing of code between the two, maybe not from an initial glance.
> On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>>
>> There are a few files missing from the list like test_arm_coresight.sh
>> and arm-coresight.txt. These could be picked up just with a name match.
>>
>> Signed-off-by: James Clark <james.clark@arm.com>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 90f13281d297..3ee45066b7e4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2066,6 +2066,7 @@ F: tools/perf/arch/arm/util/pmu.c
>> F: tools/perf/tests/shell/coresight/*
>> F: tools/perf/util/cs-etm-decoder/*
>> F: tools/perf/util/cs-etm.*
>> +N: coresight
>>
>> ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
>> M: Hans Ulli Kroll <ulli.kroll@googlemail.com>
>> --
>> 2.34.1
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight
2023-10-05 12:42 ` James Clark
@ 2023-10-05 12:56 ` Suzuki K Poulose
0 siblings, 0 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2023-10-05 12:56 UTC (permalink / raw)
To: James Clark, Mike Leach
Cc: gregkh, coresight, linux-kernel, leo.yan, namhyung, atrajeev,
Oded Gabbay
On 05/10/2023 13:42, James Clark wrote:
>
>
> On 05/10/2023 13:08, Mike Leach wrote:
>> Won't this also pick up....
>>
>> drivers/accel/habanalabs/gaudi/gaudi_coresight.c
>>
>> ?
>>
>> Which isn't part of anything we maintain
>>
>
> Ah ok I did try to check for other non Arm Coresight files with
> Coresight in the name and didn't find any, but I must have missed that one.
>
> I will just explicitly add the missing ones instead.
>
> Although on further inspection it does seem to be related to some Arm
> Coresight implementation, although not one that fits in the existing
True, indeed it is hand written code sequence that we do for the
normal CoreSight components. The access to the components looks a bit
convoluted. However, with the coresight_access abstraction we have,
it is possible to abstract it away and move the driver framework to
CoreSight drivers.
> Perf or Coresight driver framework. So I'm not sure if there could ever
> be any sharing of code between the two, maybe not from an initial glance.
Nothing that we could do at the moment without support from the
habana labs folks.
Suzuki
>
>> On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>>>
>>> There are a few files missing from the list like test_arm_coresight.sh
>>> and arm-coresight.txt. These could be picked up just with a name match.
>>>
>>> Signed-off-by: James Clark <james.clark@arm.com>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 90f13281d297..3ee45066b7e4 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2066,6 +2066,7 @@ F: tools/perf/arch/arm/util/pmu.c
>>> F: tools/perf/tests/shell/coresight/*
>>> F: tools/perf/util/cs-etm-decoder/*
>>> F: tools/perf/util/cs-etm.*
>>> +N: coresight
>>>
>>> ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
>>> M: Hans Ulli Kroll <ulli.kroll@googlemail.com>
>>> --
>>> 2.34.1
>>>
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-05 16:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-05 8:40 [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight James Clark
2023-10-05 12:08 ` Mike Leach
2023-10-05 12:42 ` James Clark
2023-10-05 12:56 ` Suzuki K Poulose
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.