All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	Hartley Sweeten <hsweeten@visionengravers.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description
Date: Fri, 30 Dec 2022 21:41:48 +0100	[thread overview]
Message-ID: <2c25f7d8882da98f2acaa1cc26f4f2de84eef1cd.camel@gmail.com> (raw)
In-Reply-To: <20221230180809.051fc6bd@jic23-huawei>

Hi Jonathan,

On Fri, 2022-12-30 at 18:08 +0000, Jonathan Cameron wrote:
> On Fri, 23 Dec 2022 17:26:35 +0100
> Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote:
> 
> > Add device tree bindings for Cirrus Logic EP9301/EP9302 internal SoCs' ADC
> > block.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> 
> Applied to the togreg branch of iio.git and pushed out as testing.

Thanks!

> Whilst we are looking at this driver, Alexander, would you mind if we relaxed
> the Kconfig dependencies to:
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 46c4fc2fc534..fd1d68dce507 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -441,7 +441,7 @@ config ENVELOPE_DETECTOR
>  
>  config EP93XX_ADC
>         tristate "Cirrus Logic EP93XX ADC driver"
> -       depends on ARCH_EP93XX
> +       depends on ARCH_EP93XX || COMPILE_TEST
>         help
>           Driver for the ADC module on the EP93XX series of SoC from Cirrus Logic.
>           It's recommended to switch on CONFIG_HIGH_RES_TIMERS option, in this
> 
> I end up doing that locally to build test patches like this one and it doesn't
> seem to cause any problems.

Sure, it's fine with me!

-- 
Alexander Sverdlin.


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	Hartley Sweeten <hsweeten@visionengravers.com>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description
Date: Fri, 30 Dec 2022 21:41:48 +0100	[thread overview]
Message-ID: <2c25f7d8882da98f2acaa1cc26f4f2de84eef1cd.camel@gmail.com> (raw)
In-Reply-To: <20221230180809.051fc6bd@jic23-huawei>

Hi Jonathan,

On Fri, 2022-12-30 at 18:08 +0000, Jonathan Cameron wrote:
> On Fri, 23 Dec 2022 17:26:35 +0100
> Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote:
> 
> > Add device tree bindings for Cirrus Logic EP9301/EP9302 internal SoCs' ADC
> > block.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> 
> Applied to the togreg branch of iio.git and pushed out as testing.

Thanks!

> Whilst we are looking at this driver, Alexander, would you mind if we relaxed
> the Kconfig dependencies to:
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 46c4fc2fc534..fd1d68dce507 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -441,7 +441,7 @@ config ENVELOPE_DETECTOR
>  
>  config EP93XX_ADC
>         tristate "Cirrus Logic EP93XX ADC driver"
> -       depends on ARCH_EP93XX
> +       depends on ARCH_EP93XX || COMPILE_TEST
>         help
>           Driver for the ADC module on the EP93XX series of SoC from Cirrus Logic.
>           It's recommended to switch on CONFIG_HIGH_RES_TIMERS option, in this
> 
> I end up doing that locally to build test patches like this one and it doesn't
> seem to cause any problems.

Sure, it's fine with me!

-- 
Alexander Sverdlin.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-30 20:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 16:26 [PATCH v3 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Alexander Sverdlin
2022-12-23 16:26 ` Alexander Sverdlin
2022-12-23 16:26 ` [PATCH v3 2/2] iio: adc: ep93xx: Add OF support Alexander Sverdlin
2022-12-23 16:26   ` Alexander Sverdlin
2022-12-30 18:08 ` [PATCH v3 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Jonathan Cameron
2022-12-30 18:08   ` Jonathan Cameron
2022-12-30 20:41   ` Alexander Sverdlin [this message]
2022-12-30 20:41     ` Alexander Sverdlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c25f7d8882da98f2acaa1cc26f4f2de84eef1cd.camel@gmail.com \
    --to=alexander.sverdlin@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.