All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt: bindings: as3645a: Fix the example node
@ 2017-12-05 13:36 ` Dan Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-05 13:36 UTC (permalink / raw)
  To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	rpurdie-Fm38FmjxZ/leoWH0uzbU5w,
	jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w, pavel-+ZI9xUNit7I
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-leds-u79uwXL29TY76Z2rM5mHXA, Dan Murphy

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
---
 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..8a49ccfec29b 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,8 +59,8 @@ Example
 =======
 
 	as3645a@30 {
-		#address-cells: 1
-		#size-cells: 0
+		#address-cells = <1>;
+		#size-cells = <0>;
 		reg = <0x30>;
 		compatible = "ams,as3645a";
 		flash@0 {
-- 
2.15.0.124.g7668cbc60

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] dt: bindings: as3645a: Fix the example node
@ 2017-12-05 13:36 ` Dan Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-05 13:36 UTC (permalink / raw)
  To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel
  Cc: devicetree, linux-kernel, linux-leds, Dan Murphy

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..8a49ccfec29b 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,8 +59,8 @@ Example
 =======
 
 	as3645a@30 {
-		#address-cells: 1
-		#size-cells: 0
+		#address-cells = <1>;
+		#size-cells = <0>;
 		reg = <0x30>;
 		compatible = "ams,as3645a";
 		flash@0 {
-- 
2.15.0.124.g7668cbc60

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
  2017-12-05 13:36 ` Dan Murphy
@ 2017-12-05 20:03     ` Dan Murphy
  -1 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-05 20:03 UTC (permalink / raw)
  To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	rpurdie-Fm38FmjxZ/leoWH0uzbU5w,
	jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w, pavel-+ZI9xUNit7I,
	sakari.ailus-X3B1VOXEql0
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-leds-u79uwXL29TY76Z2rM5mHXA

+Sakari driver maintainer

On 12/05/2017 07:36 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..8a49ccfec29b 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,8 +59,8 @@ Example
>  =======
>  
>  	as3645a@30 {
> -		#address-cells: 1
> -		#size-cells: 0
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  		reg = <0x30>;
>  		compatible = "ams,as3645a";
>  		flash@0 {
> 


-- 
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
@ 2017-12-05 20:03     ` Dan Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-05 20:03 UTC (permalink / raw)
  To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel, sakari.ailus
  Cc: devicetree, linux-kernel, linux-leds

+Sakari driver maintainer

On 12/05/2017 07:36 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..8a49ccfec29b 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,8 +59,8 @@ Example
>  =======
>  
>  	as3645a@30 {
> -		#address-cells: 1
> -		#size-cells: 0
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  		reg = <0x30>;
>  		compatible = "ams,as3645a";
>  		flash@0 {
> 


-- 
------------------
Dan Murphy

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
  2017-12-05 13:36 ` Dan Murphy
  (?)
  (?)
@ 2017-12-06 21:52 ` Rob Herring
  2017-12-06 22:32     ` Dan Murphy
  -1 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2017-12-06 21:52 UTC (permalink / raw)
  To: Dan Murphy
  Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
	linux-kernel, linux-leds

On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..8a49ccfec29b 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,8 +59,8 @@ Example
>  =======
>  
>  	as3645a@30 {
> -		#address-cells: 1
> -		#size-cells: 0
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  		reg = <0x30>;
>  		compatible = "ams,as3645a";

Convention is also we put compatible first.

>  		flash@0 {
> -- 
> 2.15.0.124.g7668cbc60
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
  2017-12-06 21:52 ` Rob Herring
@ 2017-12-06 22:32     ` Dan Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-06 22:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: mark.rutland-5wv7dgnIgG8, rpurdie-Fm38FmjxZ/leoWH0uzbU5w,
	jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w, pavel-+ZI9xUNit7I,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-leds-u79uwXL29TY76Z2rM5mHXA

Rob

On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>>  =======
>>  
>>  	as3645a@30 {
>> -		#address-cells: 1
>> -		#size-cells: 0
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>>  		reg = <0x30>;
>>  		compatible = "ams,as3645a";
> 
> Convention is also we put compatible first.
> 

OK I will move that too for v2.

Can that be in the same patch or do you want a separate patch?

Dan

>>  		flash@0 {
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
@ 2017-12-06 22:32     ` Dan Murphy
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Murphy @ 2017-12-06 22:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
	linux-kernel, linux-leds

Rob

On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>>  =======
>>  
>>  	as3645a@30 {
>> -		#address-cells: 1
>> -		#size-cells: 0
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>>  		reg = <0x30>;
>>  		compatible = "ams,as3645a";
> 
> Convention is also we put compatible first.
> 

OK I will move that too for v2.

Can that be in the same patch or do you want a separate patch?

Dan

>>  		flash@0 {
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
  2017-12-06 22:32     ` Dan Murphy
  (?)
@ 2017-12-07 15:42     ` Rob Herring
  2017-12-27 21:19       ` Pavel Machek
  -1 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2017-12-07 15:42 UTC (permalink / raw)
  To: Dan Murphy
  Cc: Mark Rutland, Richard Purdie, Jacek Anaszewski, Pavel Machek,
	devicetree, linux-kernel, Linux LED Subsystem

On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@ti.com> wrote:
> Rob
>
> On 12/06/2017 03:52 PM, Rob Herring wrote:
>> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>>> Fix the address-cells and size-cells example node
>>> to reflect to the correct representation.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> index fdc40e354a64..8a49ccfec29b 100644
>>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> @@ -59,8 +59,8 @@ Example
>>>  =======
>>>
>>>      as3645a@30 {
>>> -            #address-cells: 1
>>> -            #size-cells: 0
>>> +            #address-cells = <1>;
>>> +            #size-cells = <0>;
>>>              reg = <0x30>;
>>>              compatible = "ams,as3645a";
>>
>> Convention is also we put compatible first.
>>
>
> OK I will move that too for v2.
>
> Can that be in the same patch or do you want a separate patch?

Same patch is fine.

Rob

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] dt: bindings: as3645a: Fix the example node
  2017-12-07 15:42     ` Rob Herring
@ 2017-12-27 21:19       ` Pavel Machek
  0 siblings, 0 replies; 9+ messages in thread
From: Pavel Machek @ 2017-12-27 21:19 UTC (permalink / raw)
  To: Rob Herring
  Cc: Dan Murphy, Mark Rutland, Richard Purdie, Jacek Anaszewski,
	devicetree, linux-kernel, Linux LED Subsystem

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

On Thu 2017-12-07 09:42:29, Rob Herring wrote:
> On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@ti.com> wrote:
> > Rob
> >
> > On 12/06/2017 03:52 PM, Rob Herring wrote:
> >> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
> >>> Fix the address-cells and size-cells example node
> >>> to reflect to the correct representation.
> >>>
> >>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> index fdc40e354a64..8a49ccfec29b 100644
> >>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> @@ -59,8 +59,8 @@ Example
> >>>  =======
> >>>
> >>>      as3645a@30 {
> >>> -            #address-cells: 1
> >>> -            #size-cells: 0
> >>> +            #address-cells = <1>;
> >>> +            #size-cells = <0>;
> >>>              reg = <0x30>;
> >>>              compatible = "ams,as3645a";
> >>
> >> Convention is also we put compatible first.
> >>
> >
> > OK I will move that too for v2.
> >
> > Can that be in the same patch or do you want a separate patch?
> 
> Same patch is fine.

For fixed patch:

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-12-27 21:19 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 13:36 [PATCH] dt: bindings: as3645a: Fix the example node Dan Murphy
2017-12-05 13:36 ` Dan Murphy
     [not found] ` <20171205133637.30022-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-05 20:03   ` Dan Murphy
2017-12-05 20:03     ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
2017-12-06 22:32   ` Dan Murphy
2017-12-06 22:32     ` Dan Murphy
2017-12-07 15:42     ` Rob Herring
2017-12-27 21:19       ` Pavel Machek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.