* [Buildroot] qt5base: don't enable KMS if it doesn't have udev
@ 2016-07-08 0:07 Akihiko Odaki
2016-07-08 1:17 ` [Buildroot] [PATCH v2] " Akihiko Odaki
0 siblings, 1 reply; 6+ messages in thread
From: Akihiko Odaki @ 2016-07-08 0:07 UTC (permalink / raw)
To: buildroot
diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index bf541b0..60b4e94 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -30,8 +30,11 @@ QT5BASE_CONFIGURE_OPTS += \
# Uses libgbm from mesa3d
ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
-QT5BASE_CONFIGURE_OPTS += -kms -gbm
+QT5BASE_CONFIGURE_OPTS += -gbm
QT5BASE_DEPENDENCIES += mesa3d
+ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+QT5BASE_CONFIGURE_OPTS += -kms
+endif
else
QT5BASE_CONFIGURE_OPTS += -no-kms
endif
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] qt5base: don't enable KMS if it doesn't have udev
2016-07-08 0:07 [Buildroot] qt5base: don't enable KMS if it doesn't have udev Akihiko Odaki
@ 2016-07-08 1:17 ` Akihiko Odaki
2016-07-08 18:53 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Akihiko Odaki @ 2016-07-08 1:17 UTC (permalink / raw)
To: buildroot
Signed-off-by: Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp>
---
package/qt5/qt5base/qt5base.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index bf541b0..60b4e94 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -30,8 +30,11 @@ QT5BASE_CONFIGURE_OPTS += \
# Uses libgbm from mesa3d
ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
-QT5BASE_CONFIGURE_OPTS += -kms -gbm
+QT5BASE_CONFIGURE_OPTS += -gbm
QT5BASE_DEPENDENCIES += mesa3d
+ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+QT5BASE_CONFIGURE_OPTS += -kms
+endif
else
QT5BASE_CONFIGURE_OPTS += -no-kms
endif
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] qt5base: don't enable KMS if it doesn't have udev
2016-07-08 1:17 ` [Buildroot] [PATCH v2] " Akihiko Odaki
@ 2016-07-08 18:53 ` Thomas Petazzoni
2016-07-17 2:05 ` Akihiko Odaki
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-07-08 18:53 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 8 Jul 2016 10:17:32 +0900, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp>
Thanks for this new iteration. When you send a patch that fixes an
autobuilder failure, please include something like this in the commit
log:
Fixes:
http://autobuild.buildroot.org/results/....
(which should point to the autobuilder failure being fixed by this
patch).
However, I have some comments below.
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index bf541b0..60b4e94 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -30,8 +30,11 @@ QT5BASE_CONFIGURE_OPTS += \
>
> # Uses libgbm from mesa3d
> ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
> -QT5BASE_CONFIGURE_OPTS += -kms -gbm
> +QT5BASE_CONFIGURE_OPTS += -gbm
> QT5BASE_DEPENDENCIES += mesa3d
> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> +QT5BASE_CONFIGURE_OPTS += -kms
> +endif
Does it really make sense to enable GBM without KMS? The only place
where I see GBM actually being used in Qt's configure script is:
if [ "$CFG_EGLFS" = "yes" ] && [ "$CFG_KMS" = "yes" ] && [ "$CFG_GBM" = "yes" ]; then
QT_CONFIG="$QT_CONFIG eglfs_gbm"
CFG_EGLFS_GBM="yes"
Which seems to indicate that *both* KMS and GBM are needed in order to
enable the eglfs_gbm module. Can you check this? If that's the case,
then a better patch would be:
ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL)$(BR2_PACKAGE_HAS_UDEV),yy)
QT5BASE_CONFIGURE_OPTS += -kms -gbm
else
...
endif
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2] qt5base: don't enable KMS if it doesn't have udev
2016-07-08 18:53 ` Thomas Petazzoni
@ 2016-07-17 2:05 ` Akihiko Odaki
2016-07-24 22:43 ` Akihiko Odaki
2016-08-20 19:27 ` Peter Seiderer
0 siblings, 2 replies; 6+ messages in thread
From: Akihiko Odaki @ 2016-07-17 2:05 UTC (permalink / raw)
To: buildroot
Hi,
On 2016-07-09 03:53, Thomas Petazzoni wrote:
> Thanks for this new iteration. When you send a patch that fixes an
> autobuilder failure, please include something like this in the commit
> log:
>
> Fixes:
>
> http://autobuild.buildroot.org/results/....
>
> (which should point to the autobuilder failure being fixed by this
> patch).
I see. I'll keep in mind.
> However, I have some comments below.
>
>> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
>> index bf541b0..60b4e94 100644
>> --- a/package/qt5/qt5base/qt5base.mk
>> +++ b/package/qt5/qt5base/qt5base.mk
>> @@ -30,8 +30,11 @@ QT5BASE_CONFIGURE_OPTS += \
>>
>> # Uses libgbm from mesa3d
>> ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
>> -QT5BASE_CONFIGURE_OPTS += -kms -gbm
>> +QT5BASE_CONFIGURE_OPTS += -gbm
>> QT5BASE_DEPENDENCIES += mesa3d
>> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
>> +QT5BASE_CONFIGURE_OPTS += -kms
>> +endif
>
> Does it really make sense to enable GBM without KMS? The only place
> where I see GBM actually being used in Qt's configure script is:
>
> if [ "$CFG_EGLFS" = "yes" ] && [ "$CFG_KMS" = "yes" ] && [ "$CFG_GBM" = "yes" ]; then
> QT_CONFIG="$QT_CONFIG eglfs_gbm"
> CFG_EGLFS_GBM="yes"
>
> Which seems to indicate that *both* KMS and GBM are needed in order to
> enable the eglfs_gbm module. Can you check this? If that's the case,
> then a better patch would be:
>
> ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL)$(BR2_PACKAGE_HAS_UDEV),yy)
> QT5BASE_CONFIGURE_OPTS += -kms -gbm
> else
> ...
> endif
It has another configuration.
if [ "$CFG_GBM" = "yes" ]; then
QT_CONFIG="$QT_CONFIG gbm"
fi
I have no idea what it means. It doesn't mean anything as far as I see.
But considering it has the configuration, Qt may have some intension to
do something with it. I think gbm should be set even if kms is not set.
Regards,
Akihiko Odaki
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2] qt5base: don't enable KMS if it doesn't have udev
2016-07-17 2:05 ` Akihiko Odaki
@ 2016-07-24 22:43 ` Akihiko Odaki
2016-08-20 19:27 ` Peter Seiderer
1 sibling, 0 replies; 6+ messages in thread
From: Akihiko Odaki @ 2016-07-24 22:43 UTC (permalink / raw)
To: buildroot
ping
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] qt5base: don't enable KMS if it doesn't have udev
2016-07-17 2:05 ` Akihiko Odaki
2016-07-24 22:43 ` Akihiko Odaki
@ 2016-08-20 19:27 ` Peter Seiderer
1 sibling, 0 replies; 6+ messages in thread
From: Peter Seiderer @ 2016-08-20 19:27 UTC (permalink / raw)
To: buildroot
Hello Akihiko, Thomas,
On Sun, 17 Jul 2016 11:05:57 +0900, Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp> wrote:
> Hi,
>
> On 2016-07-09 03:53, Thomas Petazzoni wrote:
> > Thanks for this new iteration. When you send a patch that fixes an
> > autobuilder failure, please include something like this in the commit
> > log:
> >
> > Fixes:
> >
> > http://autobuild.buildroot.org/results/....
> >
> > (which should point to the autobuilder failure being fixed by this
> > patch).
>
> I see. I'll keep in mind.
>
> > However, I have some comments below.
> >
> >> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> >> index bf541b0..60b4e94 100644
> >> --- a/package/qt5/qt5base/qt5base.mk
> >> +++ b/package/qt5/qt5base/qt5base.mk
> >> @@ -30,8 +30,11 @@ QT5BASE_CONFIGURE_OPTS += \
> >>
> >> # Uses libgbm from mesa3d
> >> ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y)
> >> -QT5BASE_CONFIGURE_OPTS += -kms -gbm
> >> +QT5BASE_CONFIGURE_OPTS += -gbm
> >> QT5BASE_DEPENDENCIES += mesa3d
> >> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> >> +QT5BASE_CONFIGURE_OPTS += -kms
> >> +endif
> >
> > Does it really make sense to enable GBM without KMS? The only place
> > where I see GBM actually being used in Qt's configure script is:
> >
> > if [ "$CFG_EGLFS" = "yes" ] && [ "$CFG_KMS" = "yes" ] && [ "$CFG_GBM" = "yes" ]; then
> > QT_CONFIG="$QT_CONFIG eglfs_gbm"
> > CFG_EGLFS_GBM="yes"
> >
> > Which seems to indicate that *both* KMS and GBM are needed in order to
> > enable the eglfs_gbm module. Can you check this? If that's the case,
> > then a better patch would be:
> >
> > ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL)$(BR2_PACKAGE_HAS_UDEV),yy)
> > QT5BASE_CONFIGURE_OPTS += -kms -gbm
> > else
> > ...
> > endif
>
> It has another configuration.
>
> if [ "$CFG_GBM" = "yes" ]; then
> QT_CONFIG="$QT_CONFIG gbm"
> fi
>
> I have no idea what it means. It doesn't mean anything as far as I see.
> But considering it has the configuration, Qt may have some intension to
> do something with it. I think gbm should be set even if kms is not set.
>
> Regards,
> Akihiko Odaki
There is a upstream patch [1] to remove the libudev dependency from kms
(simply not needed), just send a buildroot patch [2] using this solution...
Regards,
Peter
[1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
[2] http://lists.busybox.net/pipermail/buildroot/2016-August/170316.html
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-20 19:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-08 0:07 [Buildroot] qt5base: don't enable KMS if it doesn't have udev Akihiko Odaki
2016-07-08 1:17 ` [Buildroot] [PATCH v2] " Akihiko Odaki
2016-07-08 18:53 ` Thomas Petazzoni
2016-07-17 2:05 ` Akihiko Odaki
2016-07-24 22:43 ` Akihiko Odaki
2016-08-20 19:27 ` Peter Seiderer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.