From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org, vkoul@kernel.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/2] ASoC: wsa881x: mark read_only_wordlength flag Date: Wed, 11 Mar 2020 13:58:44 -0500 [thread overview] Message-ID: <2c56d592-719f-bd87-25cb-c5028bde729b@linux.intel.com> (raw) In-Reply-To: <20200311113545.23773-3-srinivas.kandagatla@linaro.org> On 3/11/20 6:35 AM, Srinivas Kandagatla wrote: > WSA881x works in PDM mode so the wordlength is fixed, which also makes > the only field "WordLength" in DPN_BlockCtrl1 register a read-only. > Writing to this register will throw up errors with Qualcomm Controller. it'd be good to clarify the nature of these errors, i.e. a) is this the Slave device responding with a NAK? b) is this the Slave device responding with COMMAND_IGNORED, and those responses not handled by the controller? c) something else? Thanks! > So use ro_blockctrl1_reg flag to mark this field as read-only so that > core will not write to this register. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > sound/soc/codecs/wsa881x.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c > index b59f1d0e7f84..35b44b297f9e 100644 > --- a/sound/soc/codecs/wsa881x.c > +++ b/sound/soc/codecs/wsa881x.c > @@ -394,6 +394,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* COMP */ > .num = 2, > @@ -401,6 +402,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* BOOST */ > .num = 3, > @@ -408,6 +410,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* VISENSE */ > .num = 4, > @@ -415,6 +418,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > } > }; > >
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org, vkoul@kernel.org Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: wsa881x: mark read_only_wordlength flag Date: Wed, 11 Mar 2020 13:58:44 -0500 [thread overview] Message-ID: <2c56d592-719f-bd87-25cb-c5028bde729b@linux.intel.com> (raw) In-Reply-To: <20200311113545.23773-3-srinivas.kandagatla@linaro.org> On 3/11/20 6:35 AM, Srinivas Kandagatla wrote: > WSA881x works in PDM mode so the wordlength is fixed, which also makes > the only field "WordLength" in DPN_BlockCtrl1 register a read-only. > Writing to this register will throw up errors with Qualcomm Controller. it'd be good to clarify the nature of these errors, i.e. a) is this the Slave device responding with a NAK? b) is this the Slave device responding with COMMAND_IGNORED, and those responses not handled by the controller? c) something else? Thanks! > So use ro_blockctrl1_reg flag to mark this field as read-only so that > core will not write to this register. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > sound/soc/codecs/wsa881x.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c > index b59f1d0e7f84..35b44b297f9e 100644 > --- a/sound/soc/codecs/wsa881x.c > +++ b/sound/soc/codecs/wsa881x.c > @@ -394,6 +394,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* COMP */ > .num = 2, > @@ -401,6 +402,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* BOOST */ > .num = 3, > @@ -408,6 +410,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > }, { > /* VISENSE */ > .num = 4, > @@ -415,6 +418,7 @@ static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = { > .min_ch = 1, > .max_ch = 1, > .simple_ch_prep_sm = true, > + .read_only_wordlength = true, > } > }; > >
next prev parent reply other threads:[~2020-03-11 18:58 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-11 11:35 [PATCH 0/2] soundwire: add read_only_wordlength flag Srinivas Kandagatla 2020-03-11 11:35 ` Srinivas Kandagatla 2020-03-11 11:35 ` [PATCH 1/2] soundwire: stream: Add read_only_wordlength flag to port properties Srinivas Kandagatla 2020-03-11 11:35 ` Srinivas Kandagatla 2020-03-20 13:56 ` Vinod Koul 2020-03-20 13:56 ` Vinod Koul 2020-03-11 11:35 ` [PATCH 2/2] ASoC: wsa881x: mark read_only_wordlength flag Srinivas Kandagatla 2020-03-11 11:35 ` Srinivas Kandagatla 2020-03-11 18:58 ` Pierre-Louis Bossart [this message] 2020-03-11 18:58 ` Pierre-Louis Bossart 2020-03-12 9:54 ` Srinivas Kandagatla 2020-03-12 9:54 ` Srinivas Kandagatla 2020-03-20 14:02 ` Vinod Koul 2020-03-20 14:02 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2c56d592-719f-bd87-25cb-c5028bde729b@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.