All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Philippe Schenker <dev@pschenker.ch>,
	jic23@kernel.org, marcel.ziswiler@toradex.com, stefan@agner.ch
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	devicetree@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant devicetrees
Date: Sat, 24 Nov 2018 14:20:58 +0300	[thread overview]
Message-ID: <2c7d4caa-4a6e-cea1-d394-51790227d968@gmail.com> (raw)
In-Reply-To: <20181123142411.8921-4-dev@pschenker.ch>

On 23.11.2018 17:24, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Activate the stmpe-adc driver as found on Apalis/Colibri iMX6/T30 modules
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Hello Philippe,

Just a very minor comment.. device trees are not for drivers, but for HW description. It will be better to s/driver/DT node/ in both commit name and description.

WARNING: multiple messages have this Message-ID (diff)
From: digetx@gmail.com (Dmitry Osipenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant devicetrees
Date: Sat, 24 Nov 2018 14:20:58 +0300	[thread overview]
Message-ID: <2c7d4caa-4a6e-cea1-d394-51790227d968@gmail.com> (raw)
In-Reply-To: <20181123142411.8921-4-dev@pschenker.ch>

On 23.11.2018 17:24, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Activate the stmpe-adc driver as found on Apalis/Colibri iMX6/T30 modules
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Hello Philippe,

Just a very minor comment.. device trees are not for drivers, but for HW description. It will be better to s/driver/DT node/ in both commit name and description.

  reply	other threads:[~2018-11-24 11:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 14:24 [PATCH v3 1/4] mfd: stmpe: Move ADC related defines to header of mfd Philippe Schenker
2018-11-23 14:24 ` Philippe Schenker
2018-11-23 14:24 ` [PATCH v3 2/4] iio: adc: add STMPE ADC driver using IIO framework Philippe Schenker
2018-11-23 14:24   ` Philippe Schenker
2018-11-23 14:24   ` Philippe Schenker
2018-11-25 10:27   ` Jonathan Cameron
2018-11-25 10:27     ` Jonathan Cameron
2018-11-25 10:27     ` Jonathan Cameron
2018-11-25 10:27     ` Jonathan Cameron
2018-11-28  9:04   ` Lee Jones
2018-11-28  9:04     ` Lee Jones
2018-11-28  9:04     ` Lee Jones
2018-11-23 14:24 ` [PATCH v3 3/4] iio: adc: add STMPE ADC devicetree bindings Philippe Schenker
2018-11-23 14:24   ` Philippe Schenker
2018-11-25 10:04   ` Jonathan Cameron
2018-11-25 10:04     ` Jonathan Cameron
2018-12-06 15:49     ` Philippe Schenker
2018-12-06 15:49       ` Philippe Schenker
2018-12-08 10:55       ` Jonathan Cameron
2018-12-08 10:55         ` Jonathan Cameron
2018-11-28  9:02   ` Lee Jones
2018-11-28  9:02     ` Lee Jones
2018-11-23 14:24 ` [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant devicetrees Philippe Schenker
2018-11-23 14:24   ` Philippe Schenker
2018-11-24 11:20   ` Dmitry Osipenko [this message]
2018-11-24 11:20     ` Dmitry Osipenko
2018-11-27 14:21   ` Thierry Reding
2018-11-27 14:21     ` Thierry Reding
2018-11-28  9:15 ` [PATCH v3 1/4] mfd: stmpe: Move ADC related defines to header of mfd Lee Jones
2018-11-28  9:15   ` Lee Jones
2018-12-09  4:52   ` Dmitry Torokhov
2018-12-09  4:52     ` Dmitry Torokhov
2018-12-10  6:16     ` Lee Jones
2018-12-10  6:16       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c7d4caa-4a6e-cea1-d394-51790227d968@gmail.com \
    --to=digetx@gmail.com \
    --cc=dev@pschenker.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=jic23@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=philippe.schenker@toradex.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.