* [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power @ 2021-05-31 11:30 David Hunt 2021-06-02 11:14 ` Burakov, Anatoly 2021-06-22 14:07 ` [dpdk-dev] [PATCH v2] " David Hunt 0 siblings, 2 replies; 7+ messages in thread From: David Hunt @ 2021-05-31 11:30 UTC (permalink / raw) To: dev; +Cc: david.hunt The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This patch adds a 'baseline' mode were the pmd power management is not enabled. Use --pmg-mgmt=baseline. Signed-off-by: David Hunt <david.hunt@intel.com> --- examples/l3fwd-power/main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f8dfed1634..34b0eaa401 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1617,7 +1617,7 @@ print_usage(const char *prgname) " empty polls, full polls, and core busyness to telemetry\n" " --interrupt-only: enable interrupt-only mode\n" " --pmd-mgmt MODE: enable PMD power management mode. " - "Currently supported modes: monitor, pause, scale\n", + "Currently supported modes: baseline, monitor, pause, scale\n", prgname); } @@ -1714,6 +1714,7 @@ parse_pmd_mgmt_config(const char *name) #define PMD_MGMT_MONITOR "monitor" #define PMD_MGMT_PAUSE "pause" #define PMD_MGMT_SCALE "scale" +#define PMD_MGMT_BASELINE "baseline" if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; @@ -1729,6 +1730,10 @@ parse_pmd_mgmt_config(const char *name) pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; return 0; } + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { + pmgmt_type = -1; + return 0; + } /* unknown PMD power management mode */ return -1; } @@ -2767,7 +2772,8 @@ main(int argc, char **argv) "Fail to add ptype cb\n"); } - if (app_mode == APP_MODE_PMD_MGMT) { + if ((app_mode == APP_MODE_PMD_MGMT) && + (pmgmt_type >= 0)) { ret = rte_power_ethdev_pmgmt_queue_enable( lcore_id, portid, queueid, pmgmt_type); -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power 2021-05-31 11:30 [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power David Hunt @ 2021-06-02 11:14 ` Burakov, Anatoly 2021-06-22 14:07 ` [dpdk-dev] [PATCH v2] " David Hunt 1 sibling, 0 replies; 7+ messages in thread From: Burakov, Anatoly @ 2021-06-02 11:14 UTC (permalink / raw) To: David Hunt, dev On 31-May-21 12:30 PM, David Hunt wrote: > The PMD Power Management scheme currently has 3 modes, > scale, monitor and pause. However, it would be nice to > have a baseline mode for easy comparison of power savings > with and without these modes. > > This patch adds a 'baseline' mode were the pmd power > management is not enabled. Use --pmg-mgmt=baseline. > > Signed-off-by: David Hunt <david.hunt@intel.com> > --- > examples/l3fwd-power/main.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index f8dfed1634..34b0eaa401 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1617,7 +1617,7 @@ print_usage(const char *prgname) > " empty polls, full polls, and core busyness to telemetry\n" > " --interrupt-only: enable interrupt-only mode\n" > " --pmd-mgmt MODE: enable PMD power management mode. " > - "Currently supported modes: monitor, pause, scale\n", > + "Currently supported modes: baseline, monitor, pause, scale\n", > prgname); > } > > @@ -1714,6 +1714,7 @@ parse_pmd_mgmt_config(const char *name) > #define PMD_MGMT_MONITOR "monitor" > #define PMD_MGMT_PAUSE "pause" > #define PMD_MGMT_SCALE "scale" > +#define PMD_MGMT_BASELINE "baseline" > > if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { > pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; > @@ -1729,6 +1730,10 @@ parse_pmd_mgmt_config(const char *name) > pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; > return 0; > } > + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { > + pmgmt_type = -1; > + return 0; > + } I don't particularly like the enum abuse, type safety exists for a reason :) perhaps just add a bool that enables/disables this? you're effectively doing that anyway with pmgmt_type >= 0. > /* unknown PMD power management mode */ > return -1; > } > @@ -2767,7 +2772,8 @@ main(int argc, char **argv) > "Fail to add ptype cb\n"); > } > > - if (app_mode == APP_MODE_PMD_MGMT) { > + if ((app_mode == APP_MODE_PMD_MGMT) && > + (pmgmt_type >= 0)) { > ret = rte_power_ethdev_pmgmt_queue_enable( > lcore_id, portid, queueid, > pmgmt_type); > -- Thanks, Anatoly ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power 2021-05-31 11:30 [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power David Hunt 2021-06-02 11:14 ` Burakov, Anatoly @ 2021-06-22 14:07 ` David Hunt 2021-06-23 10:14 ` Burakov, Anatoly 1 sibling, 1 reply; 7+ messages in thread From: David Hunt @ 2021-06-22 14:07 UTC (permalink / raw) To: dev; +Cc: david.hunt, anatoly.burakov The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This patch adds a 'baseline' mode were the pmd power management is not enabled. Use --pmg-mgmt=baseline. Signed-off-by: David Hunt <david.hunt@intel.com> --- changes in v2 * added a bool for baseline mode rather than abusing enums --- examples/l3fwd-power/main.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f8dfed1634..aeb2411e62 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -207,6 +207,7 @@ enum appmode { enum appmode app_mode; static enum rte_power_pmd_mgmt_type pmgmt_type; +bool baseline_enabled; enum freq_scale_hint_t { @@ -1617,7 +1618,7 @@ print_usage(const char *prgname) " empty polls, full polls, and core busyness to telemetry\n" " --interrupt-only: enable interrupt-only mode\n" " --pmd-mgmt MODE: enable PMD power management mode. " - "Currently supported modes: monitor, pause, scale\n", + "Currently supported modes: baseline, monitor, pause, scale\n", prgname); } @@ -1714,6 +1715,7 @@ parse_pmd_mgmt_config(const char *name) #define PMD_MGMT_MONITOR "monitor" #define PMD_MGMT_PAUSE "pause" #define PMD_MGMT_SCALE "scale" +#define PMD_MGMT_BASELINE "baseline" if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; @@ -1729,6 +1731,10 @@ parse_pmd_mgmt_config(const char *name) pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; return 0; } + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { + baseline_enabled = true; + return 0; + } /* unknown PMD power management mode */ return -1; } @@ -2528,6 +2534,9 @@ main(int argc, char **argv) /* init RTE timer library to be used late */ rte_timer_subsystem_init(); + /* if we're running pmd-mgmt mode, don't default to baseline mode */ + baseline_enabled = false; + /* parse application arguments (after the EAL ones) */ ret = parse_args(argc, argv); if (ret < 0) @@ -2767,7 +2776,8 @@ main(int argc, char **argv) "Fail to add ptype cb\n"); } - if (app_mode == APP_MODE_PMD_MGMT) { + if ((app_mode == APP_MODE_PMD_MGMT) && + (baseline_enabled == false)) { ret = rte_power_ethdev_pmgmt_queue_enable( lcore_id, portid, queueid, pmgmt_type); -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power 2021-06-22 14:07 ` [dpdk-dev] [PATCH v2] " David Hunt @ 2021-06-23 10:14 ` Burakov, Anatoly 2021-06-23 12:09 ` David Hunt 0 siblings, 1 reply; 7+ messages in thread From: Burakov, Anatoly @ 2021-06-23 10:14 UTC (permalink / raw) To: David Hunt, dev On 22-Jun-21 3:07 PM, David Hunt wrote: > The PMD Power Management scheme currently has 3 modes, > scale, monitor and pause. However, it would be nice to > have a baseline mode for easy comparison of power savings > with and without these modes. > > This patch adds a 'baseline' mode were the pmd power > management is not enabled. Use --pmg-mgmt=baseline. > > Signed-off-by: David Hunt <david.hunt@intel.com> > > --- > changes in v2 > * added a bool for baseline mode rather than abusing enums > --- > examples/l3fwd-power/main.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index f8dfed1634..aeb2411e62 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -207,6 +207,7 @@ enum appmode { > enum appmode app_mode; > > static enum rte_power_pmd_mgmt_type pmgmt_type; > +bool baseline_enabled; > > enum freq_scale_hint_t > { > @@ -1617,7 +1618,7 @@ print_usage(const char *prgname) > " empty polls, full polls, and core busyness to telemetry\n" > " --interrupt-only: enable interrupt-only mode\n" > " --pmd-mgmt MODE: enable PMD power management mode. " > - "Currently supported modes: monitor, pause, scale\n", > + "Currently supported modes: baseline, monitor, pause, scale\n", > prgname); > } > > @@ -1714,6 +1715,7 @@ parse_pmd_mgmt_config(const char *name) > #define PMD_MGMT_MONITOR "monitor" > #define PMD_MGMT_PAUSE "pause" > #define PMD_MGMT_SCALE "scale" > +#define PMD_MGMT_BASELINE "baseline" > > if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { > pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; > @@ -1729,6 +1731,10 @@ parse_pmd_mgmt_config(const char *name) > pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; > return 0; > } > + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { > + baseline_enabled = true; > + return 0; > + } > /* unknown PMD power management mode */ > return -1; > } > @@ -2528,6 +2534,9 @@ main(int argc, char **argv) > /* init RTE timer library to be used late */ > rte_timer_subsystem_init(); > > + /* if we're running pmd-mgmt mode, don't default to baseline mode */ > + baseline_enabled = false; > + > /* parse application arguments (after the EAL ones) */ > ret = parse_args(argc, argv); > if (ret < 0) > @@ -2767,7 +2776,8 @@ main(int argc, char **argv) > "Fail to add ptype cb\n"); > } > > - if (app_mode == APP_MODE_PMD_MGMT) { > + if ((app_mode == APP_MODE_PMD_MGMT) && > + (baseline_enabled == false)) { Nitpicking, !baseline_enabled Otherwise, Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > ret = rte_power_ethdev_pmgmt_queue_enable( > lcore_id, portid, queueid, > pmgmt_type); > -- Thanks, Anatoly ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power 2021-06-23 10:14 ` Burakov, Anatoly @ 2021-06-23 12:09 ` David Hunt 2021-06-23 14:14 ` Burakov, Anatoly 0 siblings, 1 reply; 7+ messages in thread From: David Hunt @ 2021-06-23 12:09 UTC (permalink / raw) To: Burakov, Anatoly, dev On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: > On 22-Jun-21 3:07 PM, David Hunt wrote: >> The PMD Power Management scheme currently has 3 modes, >> scale, monitor and pause. However, it would be nice to >> have a baseline mode for easy comparison of power savings >> with and without these modes. >> >> This patch adds a 'baseline' mode were the pmd power >> management is not enabled. Use --pmg-mgmt=baseline. >> >> Signed-off-by: David Hunt <david.hunt@intel.com> >> >> --- >> changes in v2 >> * added a bool for baseline mode rather than abusing enums >> --- >> examples/l3fwd-power/main.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c >> index f8dfed1634..aeb2411e62 100644 >> --- a/examples/l3fwd-power/main.c >> +++ b/examples/l3fwd-power/main.c >> @@ -207,6 +207,7 @@ enum appmode { >> enum appmode app_mode; >> static enum rte_power_pmd_mgmt_type pmgmt_type; >> +bool baseline_enabled; >> enum freq_scale_hint_t >> { >> @@ -1617,7 +1618,7 @@ print_usage(const char *prgname) >> " empty polls, full polls, and core busyness to telemetry\n" >> " --interrupt-only: enable interrupt-only mode\n" >> " --pmd-mgmt MODE: enable PMD power management mode. " >> - "Currently supported modes: monitor, pause, scale\n", >> + "Currently supported modes: baseline, monitor, pause, scale\n", >> prgname); >> } >> @@ -1714,6 +1715,7 @@ parse_pmd_mgmt_config(const char *name) >> #define PMD_MGMT_MONITOR "monitor" >> #define PMD_MGMT_PAUSE "pause" >> #define PMD_MGMT_SCALE "scale" >> +#define PMD_MGMT_BASELINE "baseline" >> if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) >> == 0) { >> pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; >> @@ -1729,6 +1731,10 @@ parse_pmd_mgmt_config(const char *name) >> pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; >> return 0; >> } >> + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) >> == 0) { >> + baseline_enabled = true; >> + return 0; >> + } >> /* unknown PMD power management mode */ >> return -1; >> } >> @@ -2528,6 +2534,9 @@ main(int argc, char **argv) >> /* init RTE timer library to be used late */ >> rte_timer_subsystem_init(); >> + /* if we're running pmd-mgmt mode, don't default to baseline >> mode */ >> + baseline_enabled = false; >> + >> /* parse application arguments (after the EAL ones) */ >> ret = parse_args(argc, argv); >> if (ret < 0) >> @@ -2767,7 +2776,8 @@ main(int argc, char **argv) >> "Fail to add ptype cb\n"); >> } >> - if (app_mode == APP_MODE_PMD_MGMT) { >> + if ((app_mode == APP_MODE_PMD_MGMT) && >> + (baseline_enabled == false)) { > > Nitpicking, !baseline_enabled > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll take this format into consideration for future patches, OK? > Otherwise, > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power 2021-06-23 12:09 ` David Hunt @ 2021-06-23 14:14 ` Burakov, Anatoly 2021-07-10 6:43 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Burakov, Anatoly @ 2021-06-23 14:14 UTC (permalink / raw) To: David Hunt, dev On 23-Jun-21 1:09 PM, David Hunt wrote: > > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: >> On 22-Jun-21 3:07 PM, David Hunt wrote: >>> The PMD Power Management scheme currently has 3 modes, >>> scale, monitor and pause. However, it would be nice to >>> have a baseline mode for easy comparison of power savings >>> with and without these modes. >>> >>> This patch adds a 'baseline' mode were the pmd power >>> management is not enabled. Use --pmg-mgmt=baseline. >>> >>> Signed-off-by: David Hunt <david.hunt@intel.com> >>> >>> --- >>> changes in v2 >>> * added a bool for baseline mode rather than abusing enums >>> --- >>> examples/l3fwd-power/main.c | 14 ++++++++++++-- >>> 1 file changed, 12 insertions(+), 2 deletions(-) >>> >>> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c >>> index f8dfed1634..aeb2411e62 100644 >>> --- a/examples/l3fwd-power/main.c >>> +++ b/examples/l3fwd-power/main.c >>> @@ -207,6 +207,7 @@ enum appmode { >>> enum appmode app_mode; >>> static enum rte_power_pmd_mgmt_type pmgmt_type; >>> +bool baseline_enabled; >>> enum freq_scale_hint_t >>> { >>> @@ -1617,7 +1618,7 @@ print_usage(const char *prgname) >>> " empty polls, full polls, and core busyness to telemetry\n" >>> " --interrupt-only: enable interrupt-only mode\n" >>> " --pmd-mgmt MODE: enable PMD power management mode. " >>> - "Currently supported modes: monitor, pause, scale\n", >>> + "Currently supported modes: baseline, monitor, pause, scale\n", >>> prgname); >>> } >>> @@ -1714,6 +1715,7 @@ parse_pmd_mgmt_config(const char *name) >>> #define PMD_MGMT_MONITOR "monitor" >>> #define PMD_MGMT_PAUSE "pause" >>> #define PMD_MGMT_SCALE "scale" >>> +#define PMD_MGMT_BASELINE "baseline" >>> if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) >>> == 0) { >>> pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; >>> @@ -1729,6 +1731,10 @@ parse_pmd_mgmt_config(const char *name) >>> pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; >>> return 0; >>> } >>> + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) >>> == 0) { >>> + baseline_enabled = true; >>> + return 0; >>> + } >>> /* unknown PMD power management mode */ >>> return -1; >>> } >>> @@ -2528,6 +2534,9 @@ main(int argc, char **argv) >>> /* init RTE timer library to be used late */ >>> rte_timer_subsystem_init(); >>> + /* if we're running pmd-mgmt mode, don't default to baseline >>> mode */ >>> + baseline_enabled = false; >>> + >>> /* parse application arguments (after the EAL ones) */ >>> ret = parse_args(argc, argv); >>> if (ret < 0) >>> @@ -2767,7 +2776,8 @@ main(int argc, char **argv) >>> "Fail to add ptype cb\n"); >>> } >>> - if (app_mode == APP_MODE_PMD_MGMT) { >>> + if ((app_mode == APP_MODE_PMD_MGMT) && >>> + (baseline_enabled == false)) { >> >> Nitpicking, !baseline_enabled >> > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll > take this format into consideration for future patches, OK? Yep, i'm fine either way. Maybe someone can fix it on apply :) > > >> Otherwise, >> >> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> >> >> -- Thanks, Anatoly ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power 2021-06-23 14:14 ` Burakov, Anatoly @ 2021-07-10 6:43 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2021-07-10 6:43 UTC (permalink / raw) To: David Hunt; +Cc: dev, Burakov, Anatoly 23/06/2021 16:14, Burakov, Anatoly: > On 23-Jun-21 1:09 PM, David Hunt wrote: > > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: > >> On 22-Jun-21 3:07 PM, David Hunt wrote: > >>> The PMD Power Management scheme currently has 3 modes, > >>> scale, monitor and pause. However, it would be nice to > >>> have a baseline mode for easy comparison of power savings > >>> with and without these modes. > >>> > >>> This patch adds a 'baseline' mode were the pmd power > >>> management is not enabled. Use --pmg-mgmt=baseline. > >>> > >>> Signed-off-by: David Hunt <david.hunt@intel.com> > >>> > >>> --- > >>> - if (app_mode == APP_MODE_PMD_MGMT) { > >>> + if ((app_mode == APP_MODE_PMD_MGMT) && > >>> + (baseline_enabled == false)) { > >> > >> Nitpicking, !baseline_enabled > >> > > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll > > take this format into consideration for future patches, OK? > > Yep, i'm fine either way. Maybe someone can fix it on apply :) Applied with the change. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-10 6:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-31 11:30 [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power David Hunt 2021-06-02 11:14 ` Burakov, Anatoly 2021-06-22 14:07 ` [dpdk-dev] [PATCH v2] " David Hunt 2021-06-23 10:14 ` Burakov, Anatoly 2021-06-23 12:09 ` David Hunt 2021-06-23 14:14 ` Burakov, Anatoly 2021-07-10 6:43 ` Thomas Monjalon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.