* [PATCH 1/1] aoe: remove unnecessary oom message
@ 2021-06-09 12:11 Zhen Lei
2021-06-09 15:42 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-06-09 12:11 UTC (permalink / raw)
To: Justin Sanders, Jens Axboe, linux-block; +Cc: Zhen Lei
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message
Remove it can help us save a bit of memory.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/block/aoe/aoechr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c
index ab41be625a53..8eea2529da20 100644
--- a/drivers/block/aoe/aoechr.c
+++ b/drivers/block/aoe/aoechr.c
@@ -140,10 +140,8 @@ bail: spin_unlock_irqrestore(&emsgs_lock, flags);
}
mp = kmemdup(msg, n, GFP_ATOMIC);
- if (mp == NULL) {
- printk(KERN_ERR "aoe: allocation failure, len=%ld\n", n);
+ if (!mp)
goto bail;
- }
em->msg = mp;
em->flags |= EMFL_VALID;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] aoe: remove unnecessary oom message
2021-06-09 12:11 [PATCH 1/1] aoe: remove unnecessary oom message Zhen Lei
@ 2021-06-09 15:42 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-06-09 15:42 UTC (permalink / raw)
To: Zhen Lei, Justin Sanders, linux-block
On 6/9/21 6:11 AM, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 12:11 [PATCH 1/1] aoe: remove unnecessary oom message Zhen Lei
2021-06-09 15:42 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.