From: Vignesh Raghavendra <vigneshr@ti.com> To: Christoph Fink <christoph.fink@omicron-lab.com> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>, Richard Weinberger <richard@nod.at>, Christoph Fink <fink.christoph@gmail.com>, Huang Shijie <shijie8@gmail.com>, <linux-kernel@vger.kernel.org>, Marek Vasut <marek.vasut@gmail.com>, <linux-mtd@lists.infradead.org>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, Han Xu <han.xu@nxp.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0 Date: Wed, 16 Oct 2019 14:11:51 +0530 [thread overview] Message-ID: <2c950e5b-bf77-b2a8-d7ee-6c669948b68f@ti.com> (raw) In-Reply-To: <1568184843-11300-1-git-send-email-christoph.fink@omicron-lab.com> On 11/09/19 12:24 PM, Christoph Fink wrote: > From: Christoph Fink <fink.christoph@gmail.com> > This patch is not against mainline kernel. There is no support for DTR mode in kernel yet. Below hunk is not even present in the spi-nor.c. For future submissions: Subject line should be one line summary of the patch starting with prefix "mtd: spi-nor:" (hint: run git log on file to know the format) and commit message should have detailed description of the patch Regards Vignesh > Signed-off-by: Christoph Fink <fink.christoph@gmail.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 8cc4b04..7fd52fa 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2089,7 +2089,7 @@ static const struct sfdp_bfpt_read sfdp_bfpt_reads[] = { > /* Fast Read 1-4-4-DTR */ > { > SNOR_HWCAPS_READ_1_4_4_DTR, > - BFPT_DWORD(1), BIT(21), /* Supported bit */ > + BFPT_DWORD(1), BIT(19), /* Supported bit */ > BFPT_DWORD(3), 0, /* Settings */ > SNOR_PROTO_1_4_4_DTR, > }, > -- Regards Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com> To: Christoph Fink <christoph.fink@omicron-lab.com> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org, Christoph Fink <fink.christoph@gmail.com>, linux-mtd@lists.infradead.org, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, Han Xu <han.xu@nxp.com>, Brian Norris <computersforpeace@gmail.com>, Huang Shijie <shijie8@gmail.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0 Date: Wed, 16 Oct 2019 14:11:51 +0530 [thread overview] Message-ID: <2c950e5b-bf77-b2a8-d7ee-6c669948b68f@ti.com> (raw) In-Reply-To: <1568184843-11300-1-git-send-email-christoph.fink@omicron-lab.com> On 11/09/19 12:24 PM, Christoph Fink wrote: > From: Christoph Fink <fink.christoph@gmail.com> > This patch is not against mainline kernel. There is no support for DTR mode in kernel yet. Below hunk is not even present in the spi-nor.c. For future submissions: Subject line should be one line summary of the patch starting with prefix "mtd: spi-nor:" (hint: run git log on file to know the format) and commit message should have detailed description of the patch Regards Vignesh > Signed-off-by: Christoph Fink <fink.christoph@gmail.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 8cc4b04..7fd52fa 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2089,7 +2089,7 @@ static const struct sfdp_bfpt_read sfdp_bfpt_reads[] = { > /* Fast Read 1-4-4-DTR */ > { > SNOR_HWCAPS_READ_1_4_4_DTR, > - BFPT_DWORD(1), BIT(21), /* Supported bit */ > + BFPT_DWORD(1), BIT(19), /* Supported bit */ > BFPT_DWORD(3), 0, /* Settings */ > SNOR_PROTO_1_4_4_DTR, > }, > -- Regards Vignesh ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-10-16 8:42 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 6:54 [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0 Christoph Fink 2019-09-11 6:54 ` Christoph Fink 2019-10-16 8:41 ` Vignesh Raghavendra [this message] 2019-10-16 8:41 ` Vignesh Raghavendra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2c950e5b-bf77-b2a8-d7ee-6c669948b68f@ti.com \ --to=vigneshr@ti.com \ --cc=boris.brezillon@free-electrons.com \ --cc=christoph.fink@omicron-lab.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@wedev4u.fr \ --cc=dwmw2@infradead.org \ --cc=fink.christoph@gmail.com \ --cc=han.xu@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=richard@nod.at \ --cc=shijie8@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.