All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bartosz Biłas" <b.bilas@grinn-global.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/qt5webengine: fix build error
Date: Tue, 30 Jul 2019 18:06:18 +0200	[thread overview]
Message-ID: <2ca6ec7e-ff3c-8ca6-53b3-d1cb5318ac15@grinn-global.com> (raw)
In-Reply-To: <20190730160359.3f298606@windsurf>

Hi Thomas,

I haven't found anything except this one: 
https://patchwork.ozlabs.org/comment/2079425/ . I've been struggling 
with it during developing one of my projects. According to the GCC 
version, I've encountered another error while I was building this 
package when gcc version was lower than 8. I'll do a clean build one 
more time with gcc 4.8 to show exactly what the problem is.

Best
Bartek
On 30.07.2019 16:03, Thomas Petazzoni wrote:
> Hello Bartosz,
>
> Thanks for your patch, see below for some questions.
>
> On Tue, 30 Jul 2019 13:58:32 +0200
> Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>
>> This commit adds a patch from upstream chromium
>> and bumps required minimal gcc version to 8.
>>
>> Fixes:
>>    ../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16:
>>    note: in definition of macro 'NS'
>>    #define NS(id) id
>>                  ^~
>>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> Do we have any corresponding build failure in the autobuilders ? If so,
> we like to have a reference to such build failures.
>
> Also, why is the required gcc version now >= 8.x ? This is not really
> explained in your commit log.
>
> Thomas

  reply	other threads:[~2019-07-30 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 11:58 [Buildroot] [PATCH] package/qt5/qt5webengine: fix build error Bartosz Bilas
2019-07-30 14:03 ` Thomas Petazzoni
2019-07-30 16:06   ` Bartosz Biłas [this message]
2019-07-30 21:30 ` Peter Seiderer
2019-07-31  7:15   ` Bartosz Biłas
2019-08-11 20:30     ` Thomas Petazzoni
2019-09-04 11:54       ` Andreas Naumann
2019-12-20 11:43       ` Giulio Benetti
2019-12-20 17:16         ` Bartosz Bilas
2020-04-01 15:03         ` Thomas Petazzoni
2020-04-02  5:35           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ca6ec7e-ff3c-8ca6-53b3-d1cb5318ac15@grinn-global.com \
    --to=b.bilas@grinn-global.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.