From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayush Sawal <ayush.sawal@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rohit Maheshwari <rohitm@chelsio.com>,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Subject: Re: [PATCH 1/2] Crypto/chcr: Avoid some code duplication
Date: Mon, 13 Jul 2020 21:30:43 +0200 [thread overview]
Message-ID: <2cb65b54-5be0-7fab-546d-e7fc33621c7f@web.de> (raw)
> The error handling path of 'chcr_authenc_setkey()' is the same as this
> error handling code.
I find this change description improvable.
> So just 'goto out' as done everywhere in the function to simplify the code.
I propose to adjust jump targets a bit more for better exception handling
in this function implementation.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayush Sawal <ayush.sawal@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rohit Maheshwari <rohitm@chelsio.com>,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Subject: Re: [PATCH 1/2] Crypto/chcr: Avoid some code duplication
Date: Mon, 13 Jul 2020 19:30:43 +0000 [thread overview]
Message-ID: <2cb65b54-5be0-7fab-546d-e7fc33621c7f@web.de> (raw)
In-Reply-To: <20200712211404.276211-1-christophe.jaillet@wanadoo.fr>
> The error handling path of 'chcr_authenc_setkey()' is the same as this
> error handling code.
I find this change description improvable.
> So just 'goto out' as done everywhere in the function to simplify the code.
I propose to adjust jump targets a bit more for better exception handling
in this function implementation.
Regards,
Markus
next reply other threads:[~2020-07-13 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 19:30 Markus Elfring [this message]
2020-07-13 19:30 ` [PATCH 1/2] Crypto/chcr: Avoid some code duplication Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-07-12 21:14 Christophe JAILLET
2020-07-12 21:14 ` Christophe JAILLET
2020-07-16 11:56 ` Herbert Xu
2020-07-16 11:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb65b54-5be0-7fab-546d-e7fc33621c7f@web.de \
--to=markus.elfring@web.de \
--cc=ayush.sawal@chelsio.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.