Re: [Buildroot] [PATCH v2 1/2] configs/aspeed_ast2600evb: new defconfig

[Arnout Vandecappelle <arnout@mind.be>]

On 06/06/2022 15:57, Cédric Le Goater wrote:
> The kernel is from upstream and U-Boot is from the OpenBMC branch
> where most of development is done. Mainline doesn't have the required
> support for HW.
> 
> The main resulting file from the build is a flash image. The partition
> layout matches the OpenBMC one for 64M chips. It makes it easier to
> update the different partitions from Linux. Intermediate files can be
> used to boot from U-boot over the network or to boot QEMU using
> -kernel/-initrd/-dtb.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

[snip]
> diff --git a/configs/aspeed_ast2600evb_defconfig b/configs/aspeed_ast2600evb_defconfig
> new file mode 100644
> index 000000000000..19e46a752f3c
> --- /dev/null
> +++ b/configs/aspeed_ast2600evb_defconfig
> @@ -0,0 +1,56 @@
> +# Architecture
> +BR2_arm=y

  I would have expected

BR2_cortex_a7=y

Now it's building for arm926t...

> +
> +# System
> +BR2_TARGET_GENERIC_HOSTNAME="aspeed-evb"
> +BR2_TARGET_GENERIC_ISSUE="Aspeed EVB"
> +BR2_TARGET_GENERIC_GETTY_PORT="ttyS4"

  Doesn't the default console work?

> +BR2_SYSTEM_DHCP="eth0"
> +
> +# Filesystem
> +BR2_TARGET_ROOTFS_CPIO=y
> +BR2_TARGET_ROOTFS_CPIO_XZ=y
> +
> +# Image
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/aspeed/common/post-image.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"

  I think this argument isn't used, is it?

> +
> +# Linux headers same as kernel
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_17=y
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.17.7"
> +BR2_LINUX_KERNEL_DEFCONFIG="aspeed_g5"
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/aspeed/ast2600-evb/linux.fragment"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="aspeed-ast2600-evb"
> +
> +# Boot
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/openbmc/u-boot.git"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="f2b82fa4ba17ed8091fe76c284220006645a293b"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="evb-ast2600"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=ast2600a1-evb"
> +
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +
> +# Target tools
> +BR2_PACKAGE_MTD=y

  OK, fair enough, since flashcp is mentioned in the readme.

> +BR2_PACKAGE_UBOOT_TOOLS=y
> +BR2_PACKAGE_LIBGPIOD=y
> +BR2_PACKAGE_LIBGPIOD_TOOLS=y
> +BR2_PACKAGE_LIBCURL=y
> +BR2_PACKAGE_LIBCURL_CURL=y
> +BR2_PACKAGE_LIBCURL_VERBOSE=y
> +BR2_PACKAGE_LIBFFI=y
> +BR2_PACKAGE_DROPBEAR=y
> +BR2_PACKAGE_DROPBEAR_DISABLE_REVERSEDNS=y
> +BR2_PACKAGE_LRZSZ=y

  But why are all these needed? Defconfigs should be minimal - the only thing to 
add is stuff that you need to make the hardware work; typically linux-firmware, 
for example, or wpa_supplicant for boards that have only wifi. I don't think 
that that's the case here.

> +BR2_PACKAGE_HOST_MKPASSWD=y

  This one is definitely not needed, it's not used anywhere during the build.

  Regards,
  Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot