Re: [Buildroot] [PATCH v2 1/2] configs/aspeed_ast2600evb: new defconfig

From: Joel Stanley <joel@jms.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
	Troy Lee <troy_lee@aspeedtech.com>,
	Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 1/2] configs/aspeed_ast2600evb: new defconfig
Date: Mon, 6 Jun 2022 22:57:37 +0000	[thread overview]
Message-ID: <CACPK8Xe=3ifKNZxs5GSaHtgYONPy-_w9m8_cSkR3Rya2KkZS7Q@mail.gmail.com> (raw)
In-Reply-To: <20220606135756.2264709-1-clg@kaod.org>

On Mon, 6 Jun 2022 at 13:58, Cédric Le Goater <clg@kaod.org> wrote:
>
> The kernel is from upstream and U-Boot is from the OpenBMC branch
> where most of development is done. Mainline doesn't have the required
> support for HW.
>
> The main resulting file from the build is a flash image. The partition
> layout matches the OpenBMC one for 64M chips. It makes it easier to
> update the different partitions from Linux. Intermediate files can be
> used to boot from U-boot over the network or to boot QEMU using
> -kernel/-initrd/-dtb.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>
>  Changes in v2:
>
>  - Add Joel to the list of developers
>  - Removed unused CONFIG from linux.fragment but added
>    CONFIG_I2C_SLAVE_EEPROM which is useful for tests
>  - minor cleanups in readme.txt
>
>  DEVELOPERS                              |  4 ++
>  board/aspeed/ast2600-evb/genimage.cfg   | 40 +++++++++++++
>  board/aspeed/ast2600-evb/linux.fragment |  1 +
>  board/aspeed/ast2600-evb/readme.txt     | 80 +++++++++++++++++++++++++
>  board/aspeed/common/image.its.template  | 56 +++++++++++++++++
>  board/aspeed/common/post-image.sh       | 27 +++++++++
>  configs/aspeed_ast2600evb_defconfig     | 56 +++++++++++++++++
>  7 files changed, 264 insertions(+)
>  create mode 100644 board/aspeed/ast2600-evb/genimage.cfg
>  create mode 100644 board/aspeed/ast2600-evb/linux.fragment
>  create mode 100644 board/aspeed/ast2600-evb/readme.txt
>  create mode 100644 board/aspeed/common/image.its.template
>  create mode 100755 board/aspeed/common/post-image.sh
>  create mode 100644 configs/aspeed_ast2600evb_defconfig
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 71cc3da6d70b..3a7f67aee230 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -501,8 +501,10 @@ F: package/znc/
>  N:     Cédric Le Goater <clg@kaod.org>
>  F:     board/qemu/ppc-bamboo/
>  F:     board/qemu/ppc64le-powernv8/readme.txt
> +F:     board/aspeed/
>  F:     configs/qemu_ppc_bamboo_defconfig
>  F:     configs/qemu_ppc64le_powernv8_defconfig
> +F:     configs/aspeed*
>
>  N:     Charles Hardin <ckhardin@gmail.com>
>  F:     package/alsa-plugins/
> @@ -1451,6 +1453,8 @@ F:        board/qemu/ppc64le-pseries/
>  F:     configs/qemu_ppc64le_pseries_defconfig
>  F:     board/qemu/ppc-mac99/
>  F:     configs/qemu_ppc_mac99_defconfig
> +F:     board/aspeed/
> +F:     configs/aspeed*
>
>  N:     Johan Derycke <johanderycke@gmail.com>
>  F:     package/python-libconfig/
> diff --git a/board/aspeed/ast2600-evb/genimage.cfg b/board/aspeed/ast2600-evb/genimage.cfg
> new file mode 100644
> index 000000000000..56932d478756
> --- /dev/null
> +++ b/board/aspeed/ast2600-evb/genimage.cfg
> @@ -0,0 +1,40 @@
> +#
> +# This config reproduces the OpenBMC flash layout defined in Linux :
> +#
> +#    arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> +#
> +# and included by aspeed-ast2600-evb.dts
> +#
> +flash nor-64M-256 {
> +       pebsize = 4K
> +       numpebs = 16K
> +       minimum-io-unit-size = 256
> +}
> +
> +image flash.img {
> +       flash {
> +       }
> +       flashtype = "nor-64M-256"
> +
> +       partition uboot {
> +               image = "u-boot.bin"
> +               size = 896K
> +       }
> +
> +       partition ubootenv {
> +               /* TODO */
> +               offset = 896K
> +               size = 128K
> +       }
> +
> +       partition fitimage {
> +               image = "image.itb"
> +               offset = 1M
> +               size = 9M
> +       }
> +
> +       partition spare {

It occured to me that we could put the rootfs here instead, which
would test the filesystem generation instead of initrd. Something to
think about for the future perhaps.

> +               offset = 10M
> +               size = 54M
> +       }
> +}
> diff --git a/board/aspeed/ast2600-evb/linux.fragment b/board/aspeed/ast2600-evb/linux.fragment
> new file mode 100644
> index 000000000000..8dd460870799
> --- /dev/null
> +++ b/board/aspeed/ast2600-evb/linux.fragment
> @@ -0,0 +1 @@
> +CONFIG_I2C_SLAVE_EEPROM=y

I'll take a patch to put that in the upstream defconfig if you want.

This looks good to go in as it is from an aspeed/kernel/u-boot perspective.

Reviewed-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot