From: <Tudor.Ambarus@microchip.com> To: <michael@walle.cc>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <p.yadav@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Subject: Re: [PATCH v4 4/4] mtd: spi-nor: otp: implement erase for Winbond and similar flashes Date: Mon, 31 May 2021 08:56:39 +0000 [thread overview] Message-ID: <2d04a7f5-c99e-3177-5a1f-debe49f51ef5@microchip.com> (raw) In-Reply-To: <20210521194034.15249-5-michael@walle.cc> On 5/21/21 10:40 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Winbond flashes with OTP support provide a command to erase the OTP > data. This might come in handy during development. > > This was tested with a Winbond W25Q32JW on a LS1028A SoC with the > NXP FSPI controller. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > drivers/mtd/spi-nor/core.c | 2 +- > drivers/mtd/spi-nor/core.h | 4 ++ > drivers/mtd/spi-nor/otp.c | 83 +++++++++++++++++++++++++++++++++++ > drivers/mtd/spi-nor/winbond.c | 1 + > 4 files changed, 89 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index bd2c7717eb10..9551effb6a44 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -1318,7 +1318,7 @@ static u32 spi_nor_convert_addr(struct spi_nor *nor, loff_t addr) > /* > * Initiate the erasure of a single sector > */ > -static int spi_nor_erase_sector(struct spi_nor *nor, u32 addr) > +int spi_nor_erase_sector(struct spi_nor *nor, u32 addr) > { > int i; > > diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h > index 28a2e0be97a3..9398a8738857 100644 > --- a/drivers/mtd/spi-nor/core.h > +++ b/drivers/mtd/spi-nor/core.h > @@ -207,6 +207,7 @@ struct spi_nor_otp_organization { > * @read: read from the SPI NOR OTP area. > * @write: write to the SPI NOR OTP area. > * @lock: lock an OTP region. > + * @erase: erase an OTP region. > * @is_locked: check if an OTP region of the SPI NOR is locked. > */ > struct spi_nor_otp_ops { > @@ -214,6 +215,7 @@ struct spi_nor_otp_ops { > int (*write)(struct spi_nor *nor, loff_t addr, size_t len, > const u8 *buf); > int (*lock)(struct spi_nor *nor, unsigned int region); > + int (*erase)(struct spi_nor *nor, loff_t addr); maybe better: int (*erase)(struct spi_nor *nor, loff_t addr, size_t len); > int (*is_locked)(struct spi_nor *nor, unsigned int region); > };
WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com> To: <michael@walle.cc>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <p.yadav@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Subject: Re: [PATCH v4 4/4] mtd: spi-nor: otp: implement erase for Winbond and similar flashes Date: Mon, 31 May 2021 08:56:39 +0000 [thread overview] Message-ID: <2d04a7f5-c99e-3177-5a1f-debe49f51ef5@microchip.com> (raw) In-Reply-To: <20210521194034.15249-5-michael@walle.cc> On 5/21/21 10:40 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Winbond flashes with OTP support provide a command to erase the OTP > data. This might come in handy during development. > > This was tested with a Winbond W25Q32JW on a LS1028A SoC with the > NXP FSPI controller. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > drivers/mtd/spi-nor/core.c | 2 +- > drivers/mtd/spi-nor/core.h | 4 ++ > drivers/mtd/spi-nor/otp.c | 83 +++++++++++++++++++++++++++++++++++ > drivers/mtd/spi-nor/winbond.c | 1 + > 4 files changed, 89 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index bd2c7717eb10..9551effb6a44 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -1318,7 +1318,7 @@ static u32 spi_nor_convert_addr(struct spi_nor *nor, loff_t addr) > /* > * Initiate the erasure of a single sector > */ > -static int spi_nor_erase_sector(struct spi_nor *nor, u32 addr) > +int spi_nor_erase_sector(struct spi_nor *nor, u32 addr) > { > int i; > > diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h > index 28a2e0be97a3..9398a8738857 100644 > --- a/drivers/mtd/spi-nor/core.h > +++ b/drivers/mtd/spi-nor/core.h > @@ -207,6 +207,7 @@ struct spi_nor_otp_organization { > * @read: read from the SPI NOR OTP area. > * @write: write to the SPI NOR OTP area. > * @lock: lock an OTP region. > + * @erase: erase an OTP region. > * @is_locked: check if an OTP region of the SPI NOR is locked. > */ > struct spi_nor_otp_ops { > @@ -214,6 +215,7 @@ struct spi_nor_otp_ops { > int (*write)(struct spi_nor *nor, loff_t addr, size_t len, > const u8 *buf); > int (*lock)(struct spi_nor *nor, unsigned int region); > + int (*erase)(struct spi_nor *nor, loff_t addr); maybe better: int (*erase)(struct spi_nor *nor, loff_t addr, size_t len); > int (*is_locked)(struct spi_nor *nor, unsigned int region); > }; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-31 8:56 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 19:40 [PATCH v4 0/4] mtd: spi-nor: otp: 4 byte mode fix and erase support Michael Walle 2021-05-21 19:40 ` Michael Walle 2021-05-21 19:40 ` [PATCH v4 1/4] mtd: spi-nor: otp: fix access to security registers in 4 byte mode Michael Walle 2021-05-21 19:40 ` Michael Walle 2021-05-31 8:27 ` Tudor.Ambarus 2021-05-31 8:27 ` Tudor.Ambarus 2021-05-21 19:40 ` [PATCH v4 2/4] mtd: spi-nor: otp: use more consistent wording Michael Walle 2021-05-21 19:40 ` Michael Walle 2021-05-31 8:28 ` Tudor.Ambarus 2021-05-31 8:28 ` Tudor.Ambarus 2021-05-21 19:40 ` [PATCH v4 3/4] mtd: spi-nor: otp: return -EROFS if region is read-only Michael Walle 2021-05-21 19:40 ` Michael Walle 2021-05-25 19:33 ` Pratyush Yadav 2021-05-25 19:33 ` Pratyush Yadav 2021-05-26 10:41 ` Michael Walle 2021-05-26 10:41 ` Michael Walle 2021-05-26 11:13 ` Pratyush Yadav 2021-05-26 11:13 ` Pratyush Yadav 2021-05-31 8:52 ` Tudor.Ambarus 2021-05-31 8:52 ` Tudor.Ambarus 2021-06-01 13:02 ` Michael Walle 2021-06-01 13:02 ` Michael Walle 2021-06-03 5:22 ` Tudor.Ambarus 2021-06-03 5:22 ` Tudor.Ambarus 2021-05-21 19:40 ` [PATCH v4 4/4] mtd: spi-nor: otp: implement erase for Winbond and similar flashes Michael Walle 2021-05-21 19:40 ` Michael Walle 2021-05-25 19:37 ` Pratyush Yadav 2021-05-25 19:37 ` Pratyush Yadav 2021-05-31 8:56 ` Tudor.Ambarus [this message] 2021-05-31 8:56 ` Tudor.Ambarus 2021-06-01 13:30 ` Michael Walle 2021-06-01 13:30 ` Michael Walle 2021-06-03 5:08 ` Tudor.Ambarus 2021-06-03 5:08 ` Tudor.Ambarus 2021-06-03 5:30 ` Tudor.Ambarus 2021-06-03 5:30 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2d04a7f5-c99e-3177-5a1f-debe49f51ef5@microchip.com \ --to=tudor.ambarus@microchip.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.