All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mvebu: x530: set MPP55 to gpio
@ 2022-05-02  3:16 Chris Packham
  2022-05-02  5:23 ` Stefan Roese
  2022-05-02 15:45 ` Stefan Roese
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Packham @ 2022-05-02  3:16 UTC (permalink / raw)
  To: u-boot; +Cc: Chris Packham, Chris Packham, Stefan Roese, Tom Rini

MPP55 is used as a reset connected to the L3 switch chip. This doesn't
matter for u-boot as it doesn't use the L3 switch but it is useful to
be able to toggle the switch in/out of reset for the OS.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
I sent this out a while back but it was part of a series that has been dropped
for the time being. There's not reason to hold this change up behind the other
so I'm sending it as a standalong change.

 board/alliedtelesis/x530/x530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
index c0ec2afa3011..cbf4533e78de 100644
--- a/board/alliedtelesis/x530/x530.c
+++ b/board/alliedtelesis/x530/x530.c
@@ -93,7 +93,7 @@ int board_early_init_f(void)
 	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
 	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
 	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
-	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
+	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
 	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
 
 	return 0;
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: mvebu: x530: set MPP55 to gpio
  2022-05-02  3:16 [PATCH] ARM: mvebu: x530: set MPP55 to gpio Chris Packham
@ 2022-05-02  5:23 ` Stefan Roese
  2022-05-02 15:45 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2022-05-02  5:23 UTC (permalink / raw)
  To: Chris Packham, u-boot; +Cc: Chris Packham, Tom Rini

On 02.05.22 05:16, Chris Packham wrote:
> MPP55 is used as a reset connected to the L3 switch chip. This doesn't
> matter for u-boot as it doesn't use the L3 switch but it is useful to
> be able to toggle the switch in/out of reset for the OS.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> I sent this out a while back but it was part of a series that has been dropped
> for the time being. There's not reason to hold this change up behind the other
> so I'm sending it as a standalong change.

Good.

> 
>   board/alliedtelesis/x530/x530.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
> index c0ec2afa3011..cbf4533e78de 100644
> --- a/board/alliedtelesis/x530/x530.c
> +++ b/board/alliedtelesis/x530/x530.c
> @@ -93,7 +93,7 @@ int board_early_init_f(void)
>   	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
>   	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
>   	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
> -	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
> +	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
>   	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
>   
>   	return 0;

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: mvebu: x530: set MPP55 to gpio
  2022-05-02  3:16 [PATCH] ARM: mvebu: x530: set MPP55 to gpio Chris Packham
  2022-05-02  5:23 ` Stefan Roese
@ 2022-05-02 15:45 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2022-05-02 15:45 UTC (permalink / raw)
  To: Chris Packham, u-boot; +Cc: Chris Packham, Tom Rini

On 02.05.22 05:16, Chris Packham wrote:
> MPP55 is used as a reset connected to the L3 switch chip. This doesn't
> matter for u-boot as it doesn't use the L3 switch but it is useful to
> be able to toggle the switch in/out of reset for the OS.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I sent this out a while back but it was part of a series that has been dropped
> for the time being. There's not reason to hold this change up behind the other
> so I'm sending it as a standalong change.

Applied to u-boot-marvell/master

Thanks,
Stefan


>   board/alliedtelesis/x530/x530.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
> index c0ec2afa3011..cbf4533e78de 100644
> --- a/board/alliedtelesis/x530/x530.c
> +++ b/board/alliedtelesis/x530/x530.c
> @@ -93,7 +93,7 @@ int board_early_init_f(void)
>   	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
>   	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
>   	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
> -	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
> +	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
>   	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
>   
>   	return 0;

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-02 15:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02  3:16 [PATCH] ARM: mvebu: x530: set MPP55 to gpio Chris Packham
2022-05-02  5:23 ` Stefan Roese
2022-05-02 15:45 ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.