All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v5 2/2] cpupower: Fix to return negative value if no permisssion for read_msr
       [not found] <CAOkq_Bfc_u6crJtB=qJY4P76KnkLHF_7ZbFOsDsb5hhtpO5_FQ@mail.gmail.com>
@ 2021-07-26 20:04 ` Shuah Khan
  0 siblings, 0 replies; only message in thread
From: Shuah Khan @ 2021-07-26 20:04 UTC (permalink / raw)
  To: 徐福海, shuah, Thomas Renninger
  Cc: xufuhai, lishujin, linux-pm, linux-kernel, Shuah Khan

On 7/23/21 12:26 AM, 徐福海 wrote:
> From: xufuhai<xufuhai1992@gmail.com>  <mailto:xufuhai@kuaishou.com>
> 
> If the read_msr function is executed by a non-root user, the function returns
> -1, which means that there is no permission to access//dev/cpu//%d/msr, but
> cpufreq_has_boost_support should also return -1 immediately, and should not
> follow the original logic to return 0, which will cause amd The cpupower tool
> returns the boost active state as 0.
> 
> Reproduce procedure:
>          cpupower frequency-info
> 
> Reported-by:   yangrui<yangrui@kuaishou.com>  <mailto:yangrui@kuaishou.com>
> Signed-off-by: xufuhai<xufuhai1992@gmail.com>  <mailto:xufuhai@kuaishou.com>
> Signed-off-by: chenguanqiao<chenguanqiao@kuaishou.com>  <mailto:chenguanqiao@kuaishou.com>
> Signed-off-by: lishujin<lishujin@kuaishou.com>  <mailto:lishujin@kuaishou.com>

Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-26 20:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAOkq_Bfc_u6crJtB=qJY4P76KnkLHF_7ZbFOsDsb5hhtpO5_FQ@mail.gmail.com>
2021-07-26 20:04 ` [PATCH v5 2/2] cpupower: Fix to return negative value if no permisssion for read_msr Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.