From: Suman Anna <s-anna@ti.com> To: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Ohad Ben-Cohen <ohad@wizery.com>, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F. Davis" <afd@ti.com>, Tero Kristo <t-kristo@ti.com> Subject: Re: [PATCHv8 RESEND 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Date: Fri, 20 Mar 2020 16:38:23 -0500 [thread overview] Message-ID: <2d186bf1-db04-5f69-62a8-d1970e0592a4@ti.com> (raw) In-Reply-To: <20200320203409.GC16145@xps15> On 3/20/20 3:34 PM, Mathieu Poirier wrote: > On Fri, Mar 13, 2020 at 07:43:34PM -0500, Suman Anna wrote: >> The DSP remote processors on OMAP SoCs require a boot register to >> be programmed with a boot address, and this boot address needs to >> be on a 1KB boundary. The current code is simply masking the boot >> address appropriately without performing any sanity checks before >> releasing the resets. An unaligned boot address results in an >> undefined execution behavior and can result in various bus errors >> like MMU Faults or L3 NoC errors. Such errors are hard to debug and >> can be easily avoided by adding a sanity check for the alignment >> before booting a DSP remote processor. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> Reviewed-by: Andrew F. Davis <afd@ti.com> >> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org> >> --- >> v8-Resend: Updated to fix compilation issues against rproc-next >> >> drivers/remoteproc/omap_remoteproc.c | 20 ++++++++++++++++---- >> 1 file changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index d47d5ded651a..fe11cb709770 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -121,14 +121,23 @@ static void omap_rproc_kick(struct rproc *rproc, int vqid) >> * @rproc: handle of a remote processor >> * >> * Set boot address for a supported DSP remote processor. >> + * >> + * Return: 0 on success, or -EINVAL if boot address is not aligned properly >> */ >> -static void omap_rproc_write_dsp_boot_addr(struct rproc *rproc) >> +static int omap_rproc_write_dsp_boot_addr(struct rproc *rproc) >> { >> + struct device *dev = rproc->dev.parent; >> struct omap_rproc *oproc = rproc->priv; >> struct omap_rproc_boot_data *bdata = oproc->boot_data; >> u32 offset = bdata->boot_reg; >> >> - regmap_write(bdata->syscon, offset, rproc->bootaddr); >> + if (rproc->bootaddr & (SZ_1K - 1)) { >> + dev_err(dev, "invalid boot address 0x%llx, must be aligned on a 1KB boundary\n", >> + rproc->bootaddr); > > Yes it does fix the compilation problem but after that patch 7 doesn't apply > anymore. git am -3 should apply the patch. I didn't resend that one since there were no code changes. regards Suman > >> + return -EINVAL; >> + } >> + >> + return regmap_write(bdata->syscon, offset, rproc->bootaddr); >> } >> >> /* >> @@ -145,8 +154,11 @@ static int omap_rproc_start(struct rproc *rproc) >> int ret; >> struct mbox_client *client = &oproc->client; >> >> - if (oproc->boot_data) >> - omap_rproc_write_dsp_boot_addr(rproc); >> + if (oproc->boot_data) { >> + ret = omap_rproc_write_dsp_boot_addr(rproc); >> + if (ret) >> + return ret; >> + } >> >> client->dev = dev; >> client->tx_done = NULL; >> -- >> 2.23.0 >>
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com> To: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Ohad Ben-Cohen <ohad@wizery.com>, <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Andrew F. Davis" <afd@ti.com>, Tero Kristo <t-kristo@ti.com> Subject: Re: [PATCHv8 RESEND 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Date: Fri, 20 Mar 2020 16:38:23 -0500 [thread overview] Message-ID: <2d186bf1-db04-5f69-62a8-d1970e0592a4@ti.com> (raw) In-Reply-To: <20200320203409.GC16145@xps15> On 3/20/20 3:34 PM, Mathieu Poirier wrote: > On Fri, Mar 13, 2020 at 07:43:34PM -0500, Suman Anna wrote: >> The DSP remote processors on OMAP SoCs require a boot register to >> be programmed with a boot address, and this boot address needs to >> be on a 1KB boundary. The current code is simply masking the boot >> address appropriately without performing any sanity checks before >> releasing the resets. An unaligned boot address results in an >> undefined execution behavior and can result in various bus errors >> like MMU Faults or L3 NoC errors. Such errors are hard to debug and >> can be easily avoided by adding a sanity check for the alignment >> before booting a DSP remote processor. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> Reviewed-by: Andrew F. Davis <afd@ti.com> >> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org> >> --- >> v8-Resend: Updated to fix compilation issues against rproc-next >> >> drivers/remoteproc/omap_remoteproc.c | 20 ++++++++++++++++---- >> 1 file changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index d47d5ded651a..fe11cb709770 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -121,14 +121,23 @@ static void omap_rproc_kick(struct rproc *rproc, int vqid) >> * @rproc: handle of a remote processor >> * >> * Set boot address for a supported DSP remote processor. >> + * >> + * Return: 0 on success, or -EINVAL if boot address is not aligned properly >> */ >> -static void omap_rproc_write_dsp_boot_addr(struct rproc *rproc) >> +static int omap_rproc_write_dsp_boot_addr(struct rproc *rproc) >> { >> + struct device *dev = rproc->dev.parent; >> struct omap_rproc *oproc = rproc->priv; >> struct omap_rproc_boot_data *bdata = oproc->boot_data; >> u32 offset = bdata->boot_reg; >> >> - regmap_write(bdata->syscon, offset, rproc->bootaddr); >> + if (rproc->bootaddr & (SZ_1K - 1)) { >> + dev_err(dev, "invalid boot address 0x%llx, must be aligned on a 1KB boundary\n", >> + rproc->bootaddr); > > Yes it does fix the compilation problem but after that patch 7 doesn't apply > anymore. git am -3 should apply the patch. I didn't resend that one since there were no code changes. regards Suman > >> + return -EINVAL; >> + } >> + >> + return regmap_write(bdata->syscon, offset, rproc->bootaddr); >> } >> >> /* >> @@ -145,8 +154,11 @@ static int omap_rproc_start(struct rproc *rproc) >> int ret; >> struct mbox_client *client = &oproc->client; >> >> - if (oproc->boot_data) >> - omap_rproc_write_dsp_boot_addr(rproc); >> + if (oproc->boot_data) { >> + ret = omap_rproc_write_dsp_boot_addr(rproc); >> + if (ret) >> + return ret; >> + } >> >> client->dev = dev; >> client->tx_done = NULL; >> -- >> 2.23.0 >>
next prev parent reply other threads:[~2020-03-20 21:38 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-13 8:17 [PATCHv8 00/15] remoteproc: updates for omap remoteproc support Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 02/15] remoteproc/omap: Add device tree support Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-14 0:43 ` [PATCHv8 RESEND " Suman Anna 2020-03-14 0:43 ` Suman Anna 2020-03-20 20:34 ` Mathieu Poirier 2020-03-20 21:38 ` Suman Anna [this message] 2020-03-20 21:38 ` Suman Anna 2020-03-13 8:17 ` [PATCHv8 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-14 0:43 ` [PATCHv8 RESEND " Suman Anna 2020-03-14 0:43 ` Suman Anna 2020-03-13 8:17 ` [PATCHv8 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 08/15] remoteproc/omap: Remove the platform_data header Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 09/15] remoteproc/omap: Check for undefined mailbox messages Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 10/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 11/15] remoteproc/omap: Add support for system suspend/resume Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 12/15] remoteproc/omap: Add support for runtime auto-suspend/resume Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-20 20:23 ` Mathieu Poirier 2020-03-13 8:17 ` [PATCHv8 13/15] remoteproc/omap: Report device exceptions and trigger recovery Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-13 8:17 ` [PATCHv8 14/15] remoteproc/omap: Add watchdog functionality for remote processors Tero Kristo 2020-03-13 8:17 ` Tero Kristo 2020-03-20 20:32 ` Mathieu Poirier 2020-03-20 21:48 ` Suman Anna 2020-03-20 21:48 ` Suman Anna 2020-03-23 15:14 ` Mathieu Poirier 2020-03-13 8:17 ` [PATCHv8 15/15] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo 2020-03-13 8:17 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2d186bf1-db04-5f69-62a8-d1970e0592a4@ti.com \ --to=s-anna@ti.com \ --cc=afd@ti.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=ohad@wizery.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.