From: Dan Murphy <dmurphy@ti.com> To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, robh+dt@kernel.org, pavel@ucw.cz Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver Date: Tue, 8 Jan 2019 14:53:36 -0600 [thread overview] Message-ID: <2d2d5dcd-9c23-e901-daac-9b79aa5a5e82@ti.com> (raw) In-Reply-To: <dc2283f9-db85-1eaf-f046-3fbbd4adcace@gmail.com> Jacek On 1/8/19 2:33 PM, Jacek Anaszewski wrote: > Dan, > > On 12/19/18 5:26 PM, Dan Murphy wrote: >> Introduce the bindings for the Texas Instruments LP5024 and the LP5018 >> RGB LED device driver. The LP5024/18 can control RGB LEDs individually >> or as part of a control bank group. These devices have the ability >> to adjust the mixing control for the RGB LEDs to obtain different colors >> independent of the overall brightness of the LED grouping. >> >> Datasheet: >> http://www.ti.com/lit/ds/symlink/lp5024.pdf >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> .../devicetree/bindings/leds/leds-lp5024.txt | 63 +++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lp5024.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp5024.txt b/Documentation/devicetree/bindings/leds/leds-lp5024.txt >> new file mode 100644 >> index 000000000000..9567aa6f7813 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lp5024.txt >> @@ -0,0 +1,63 @@ >> +* Texas Instruments - LP5024/18 RGB LED driver >> + >> +The LM3692x is an ultra-compact, highly efficient, >> +white-LED driver designed for LCD display backlighting. >> + >> +The main difference between the LP5024 and L5018 is the number of >> +RGB LEDs they support. The LP5024 supports twenty four strings while the >> +LP5018 supports eighteen strings. >> + >> +Required properties: >> + - compatible: >> + "ti,lp5018" >> + "ti,lp5024" >> + - reg : I2C slave address >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Optional properties: >> + - enable-gpios : gpio pin to enable/disable the device. >> + - vled-supply : LED supply >> + >> +Required child properties: >> + - reg : Is the child node iteration. >> + - led-sources : LP5024 - 0 - 7 >> + LP5018 - 0 - 5 >> + Declares the LED string or strings that the child node >> + will control. If ti,control-bank is set then this >> + property will contain multiple LED IDs. >> + >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + - linux,default-trigger : >> + see Documentation/devicetree/bindings/leds/common.txt >> + - ti,control-bank : Indicates that the LED strings declared in the >> + led-sources property are grouped within a control >> + bank for brightness and mixing control. >> + >> +Example: >> + >> +led-controller@28 { >> + compatible = "ti,lp5024"; >> + reg = <0x28>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vbatt>; >> + >> + led@0 { >> + reg = <0>; >> + led-sources = <1>; >> + }; >> + >> + led@1 { >> + reg = <1>; >> + led-sources = <0 6>; >> + ti,control-bank; > > Do you really need ti,control-bank? Doesn't led-sources array size > greater than 1 mean that the node describes control bank? > That will work too. > Also, does it make sense to have only two LEDs in the bank? The array can populate all 7 LEDs in a single node. I only show 2 here as the example. See the description above of the led-sources Dan > >> + }; >> + >> +} >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/symlink/lp5024.pdf >> > -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Jacek Anaszewski <jacek.anaszewski@gmail.com>, <robh+dt@kernel.org>, <pavel@ucw.cz> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org> Subject: Re: [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver Date: Tue, 8 Jan 2019 14:53:36 -0600 [thread overview] Message-ID: <2d2d5dcd-9c23-e901-daac-9b79aa5a5e82@ti.com> (raw) In-Reply-To: <dc2283f9-db85-1eaf-f046-3fbbd4adcace@gmail.com> Jacek On 1/8/19 2:33 PM, Jacek Anaszewski wrote: > Dan, > > On 12/19/18 5:26 PM, Dan Murphy wrote: >> Introduce the bindings for the Texas Instruments LP5024 and the LP5018 >> RGB LED device driver. The LP5024/18 can control RGB LEDs individually >> or as part of a control bank group. These devices have the ability >> to adjust the mixing control for the RGB LEDs to obtain different colors >> independent of the overall brightness of the LED grouping. >> >> Datasheet: >> http://www.ti.com/lit/ds/symlink/lp5024.pdf >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> .../devicetree/bindings/leds/leds-lp5024.txt | 63 +++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lp5024.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp5024.txt b/Documentation/devicetree/bindings/leds/leds-lp5024.txt >> new file mode 100644 >> index 000000000000..9567aa6f7813 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lp5024.txt >> @@ -0,0 +1,63 @@ >> +* Texas Instruments - LP5024/18 RGB LED driver >> + >> +The LM3692x is an ultra-compact, highly efficient, >> +white-LED driver designed for LCD display backlighting. >> + >> +The main difference between the LP5024 and L5018 is the number of >> +RGB LEDs they support. The LP5024 supports twenty four strings while the >> +LP5018 supports eighteen strings. >> + >> +Required properties: >> + - compatible: >> + "ti,lp5018" >> + "ti,lp5024" >> + - reg : I2C slave address >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Optional properties: >> + - enable-gpios : gpio pin to enable/disable the device. >> + - vled-supply : LED supply >> + >> +Required child properties: >> + - reg : Is the child node iteration. >> + - led-sources : LP5024 - 0 - 7 >> + LP5018 - 0 - 5 >> + Declares the LED string or strings that the child node >> + will control. If ti,control-bank is set then this >> + property will contain multiple LED IDs. >> + >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + - linux,default-trigger : >> + see Documentation/devicetree/bindings/leds/common.txt >> + - ti,control-bank : Indicates that the LED strings declared in the >> + led-sources property are grouped within a control >> + bank for brightness and mixing control. >> + >> +Example: >> + >> +led-controller@28 { >> + compatible = "ti,lp5024"; >> + reg = <0x28>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vbatt>; >> + >> + led@0 { >> + reg = <0>; >> + led-sources = <1>; >> + }; >> + >> + led@1 { >> + reg = <1>; >> + led-sources = <0 6>; >> + ti,control-bank; > > Do you really need ti,control-bank? Doesn't led-sources array size > greater than 1 mean that the node describes control bank? > That will work too. > Also, does it make sense to have only two LEDs in the bank? The array can populate all 7 LEDs in a single node. I only show 2 here as the example. See the description above of the led-sources Dan > >> + }; >> + >> +} >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/symlink/lp5024.pdf >> > -- ------------------ Dan Murphy
next prev parent reply other threads:[~2019-01-08 20:53 UTC|newest] Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-19 16:26 [PATCH 0/2] LP5024/18 LED introduction Dan Murphy 2018-12-19 16:26 ` Dan Murphy 2018-12-19 16:26 ` [PATCH 1/2] dt: bindings: lp5024: Introduce the lp5024 and lp5018 RGB driver Dan Murphy 2018-12-19 16:26 ` Dan Murphy 2018-12-28 23:53 ` Rob Herring 2018-12-31 18:54 ` Dan Murphy 2018-12-31 18:54 ` Dan Murphy 2019-01-08 20:33 ` Jacek Anaszewski 2019-01-08 20:53 ` Dan Murphy [this message] 2019-01-08 20:53 ` Dan Murphy 2019-01-08 21:16 ` Jacek Anaszewski 2019-01-08 21:22 ` Dan Murphy 2019-01-08 21:22 ` Dan Murphy 2019-01-09 20:12 ` Jacek Anaszewski 2019-01-09 21:12 ` Dan Murphy 2019-01-09 21:12 ` Dan Murphy 2019-01-09 21:28 ` Jacek Anaszewski 2019-01-09 21:31 ` Dan Murphy 2019-01-09 21:31 ` Dan Murphy 2019-01-10 18:44 ` Jacek Anaszewski 2019-01-10 19:22 ` Dan Murphy 2019-01-10 19:22 ` Dan Murphy 2019-01-10 19:57 ` Jacek Anaszewski 2019-01-10 20:43 ` Dan Murphy 2019-01-10 20:43 ` Dan Murphy 2019-01-10 22:03 ` Jacek Anaszewski 2019-01-10 23:51 ` Dan Murphy 2019-01-10 23:51 ` Dan Murphy 2019-01-11 12:38 ` Dan Murphy 2019-01-11 12:38 ` Dan Murphy 2019-01-11 21:52 ` Jacek Anaszewski 2019-01-12 17:09 ` Dan Murphy 2019-01-12 17:09 ` Dan Murphy 2019-01-12 19:48 ` Jacek Anaszewski 2019-01-14 12:27 ` Dan Murphy 2019-01-14 12:27 ` Dan Murphy 2019-01-14 20:11 ` Jacek Anaszewski 2019-01-14 20:14 ` Dan Murphy 2019-01-14 20:14 ` Dan Murphy 2019-01-14 20:28 ` Jacek Anaszewski 2019-01-14 20:29 ` Dan Murphy 2019-01-14 20:29 ` Dan Murphy 2018-12-19 16:26 ` [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver Dan Murphy 2018-12-19 16:26 ` Dan Murphy 2018-12-19 19:04 ` Dan Murphy 2018-12-19 19:04 ` Dan Murphy 2018-12-19 19:34 ` Pavel Machek 2018-12-19 19:41 ` Dan Murphy 2018-12-19 19:41 ` Dan Murphy 2018-12-19 20:10 ` Pavel Machek 2018-12-19 20:41 ` Dan Murphy 2018-12-19 20:41 ` Dan Murphy 2018-12-19 21:36 ` Jacek Anaszewski 2018-12-19 21:50 ` Dan Murphy 2018-12-19 21:50 ` Dan Murphy 2018-12-20 12:40 ` Vesa Jääskeläinen 2018-12-20 13:56 ` Dan Murphy 2018-12-20 13:56 ` Dan Murphy 2019-01-01 13:45 ` Vesa Jääskeläinen 2019-01-03 22:05 ` Jacek Anaszewski 2019-01-03 23:19 ` Vesa Jääskeläinen 2019-01-03 23:34 ` Pavel Machek 2019-01-04 19:49 ` Vesa Jääskeläinen 2019-01-04 20:43 ` Pavel Machek 2019-01-04 19:12 ` Jacek Anaszewski 2019-01-04 20:12 ` Pavel Machek 2019-01-04 21:37 ` Jacek Anaszewski 2019-01-04 22:07 ` Pavel Machek 2019-01-05 12:16 ` Jacek Anaszewski 2019-01-05 12:31 ` Pavel Machek 2019-01-05 13:16 ` Jacek Anaszewski 2019-01-05 22:12 ` Generic RGB LED support was " Pavel Machek 2019-01-06 15:52 ` Jacek Anaszewski 2019-01-07 19:13 ` Jacek Anaszewski 2019-01-07 19:36 ` Dan Murphy 2019-01-07 20:59 ` Jacek Anaszewski 2019-01-07 21:14 ` Dan Murphy 2019-01-08 21:18 ` Jacek Anaszewski 2019-01-08 21:25 ` Dan Murphy 2019-01-10 12:46 ` Dan Murphy 2019-01-10 19:23 ` Jacek Anaszewski 2019-01-10 19:58 ` Dan Murphy 2019-01-10 21:02 ` Jacek Anaszewski 2019-01-10 21:07 ` Dan Murphy 2019-01-08 22:59 ` Pavel Machek 2019-01-09 7:11 ` Vesa Jääskeläinen 2019-01-13 16:37 ` Jacek Anaszewski 2019-01-05 0:39 ` Vesa Jääskeläinen 2019-01-07 19:34 ` Dan Murphy 2019-01-07 19:34 ` Dan Murphy 2019-01-09 6:20 ` Vesa Jääskeläinen 2019-01-07 21:13 ` Jacek Anaszewski 2019-01-07 21:15 ` Dan Murphy 2019-01-07 21:15 ` Dan Murphy 2019-01-09 6:46 ` Vesa Jääskeläinen 2019-01-13 16:36 ` Jacek Anaszewski 2018-12-20 20:31 ` Jacek Anaszewski 2018-12-21 7:32 ` Jacek Anaszewski 2018-12-21 13:05 ` Dan Murphy 2018-12-21 13:05 ` Dan Murphy 2018-12-29 18:28 ` Jacek Anaszewski 2018-12-29 19:07 ` Pavel Machek 2018-12-30 17:09 ` Jacek Anaszewski 2018-12-30 17:35 ` Pavel Machek 2018-12-31 15:43 ` Jacek Anaszewski 2018-12-31 15:47 ` Jacek Anaszewski 2018-12-31 19:15 ` Dan Murphy 2018-12-31 19:15 ` Dan Murphy 2019-01-01 14:42 ` Jacek Anaszewski 2019-01-01 18:11 ` Dan Murphy 2019-01-01 18:11 ` Dan Murphy 2019-01-01 22:06 ` Jacek Anaszewski 2018-12-31 16:28 ` Pavel Machek 2019-01-01 14:26 ` Jacek Anaszewski 2018-12-19 22:03 ` Pavel Machek 2018-12-19 22:08 ` Dan Murphy 2018-12-19 22:08 ` Dan Murphy 2018-12-19 22:27 ` Pavel Machek 2018-12-20 1:31 ` Dan Murphy 2018-12-20 1:31 ` Dan Murphy 2018-12-20 9:06 ` Pavel Machek 2018-12-20 14:03 ` Dan Murphy 2018-12-20 14:03 ` Dan Murphy 2019-01-08 21:10 ` Jacek Anaszewski 2019-01-08 21:17 ` Dan Murphy 2019-01-08 21:17 ` Dan Murphy 2019-07-22 20:59 ` Backlight in motorola Droid 4 Pavel Machek 2019-07-23 15:53 ` Dan Murphy 2019-07-23 15:53 ` Dan Murphy 2019-07-24 8:22 ` Pavel Machek 2019-07-24 12:45 ` Pavel Machek 2019-07-24 15:10 ` Dan Murphy 2019-07-24 15:10 ` Dan Murphy 2019-07-24 15:22 ` Dan Murphy 2019-07-24 15:22 ` Dan Murphy 2019-07-26 14:38 ` Dan Murphy 2019-07-26 14:38 ` Dan Murphy 2019-07-29 22:00 ` Pavel Machek 2019-07-30 18:21 ` Dan Murphy 2019-07-30 18:21 ` Dan Murphy 2019-07-30 21:52 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2d2d5dcd-9c23-e901-daac-9b79aa5a5e82@ti.com \ --to=dmurphy@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.