* [PATCH] generic: fix statx definition for non-x86 architecture
@ 2017-04-19 23:54 Gwendal Grignou
2017-04-20 0:27 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Gwendal Grignou @ 2017-04-19 23:54 UTC (permalink / raw)
To: dhowells, eguan; +Cc: fstests
Fix a compilation error for ARM:
__ILP32__ is defined but not __X32_SYSCALL_BIT.
The check should only apply for x86_64 architecture, statx for other
architectures is not implemented yet - see commit 7acc839c9e57
"statx: Add a system call to make enhanced file info available".
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
src/statx.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/statx.h b/src/statx.h
index b491c018..5d58208a 100644
--- a/src/statx.h
+++ b/src/statx.h
@@ -19,10 +19,12 @@
#ifndef __NR_statx
# ifdef __i386__
# define __NR_statx 383
-# elif defined (__ILP32__)
-# define __NR_statx (__X32_SYSCALL_BIT + 332)
# elif defined(__x86_64__)
-# define __NR_statx 332
+# if defined (__ILP32__)
+# define __NR_statx (__X32_SYSCALL_BIT + 332)
+# else
+# define __NR_statx 332
+# endif
# endif
#endif
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic: fix statx definition for non-x86 architecture
2017-04-19 23:54 [PATCH] generic: fix statx definition for non-x86 architecture Gwendal Grignou
@ 2017-04-20 0:27 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2017-04-20 0:27 UTC (permalink / raw)
To: Gwendal Grignou, dhowells, eguan; +Cc: fstests
On 4/19/17 6:54 PM, Gwendal Grignou wrote:
> Fix a compilation error for ARM:
> __ILP32__ is defined but not __X32_SYSCALL_BIT.
>
> The check should only apply for x86_64 architecture, statx for other
> architectures is not implemented yet - see commit 7acc839c9e57
> "statx: Add a system call to make enhanced file info available".
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
probably needs fixing in xfs_io too, thanks.
-Eric
> ---
> src/statx.h | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/statx.h b/src/statx.h
> index b491c018..5d58208a 100644
> --- a/src/statx.h
> +++ b/src/statx.h
> @@ -19,10 +19,12 @@
> #ifndef __NR_statx
> # ifdef __i386__
> # define __NR_statx 383
> -# elif defined (__ILP32__)
> -# define __NR_statx (__X32_SYSCALL_BIT + 332)
> # elif defined(__x86_64__)
> -# define __NR_statx 332
> +# if defined (__ILP32__)
> +# define __NR_statx (__X32_SYSCALL_BIT + 332)
> +# else
> +# define __NR_statx 332
> +# endif
> # endif
> #endif
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-20 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 23:54 [PATCH] generic: fix statx definition for non-x86 architecture Gwendal Grignou
2017-04-20 0:27 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.