From: Quan Nguyen <quan@os.amperecomputing.com> To: Lee Jones <lee.jones@linaro.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Jonathan Corbet <corbet@lwn.net>, Derek Kiernan <derek.kiernan@xilinx.com>, Dragan Cvetic <dragan.cvetic@xilinx.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thu Nguyen <thu@os.amperecomputing.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, OpenBMC Maillist <openbmc@lists.ozlabs.org>, Open Source Submission <patches@amperecomputing.com>, Phong Vo <phong@os.amperecomputing.com>, "Thang Q . Nguyen" <thang@os.amperecomputing.com> Subject: Re: [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro MFD driver Date: Wed, 29 Jun 2022 16:23:26 +0700 [thread overview] Message-ID: <2d3b395d-affa-a651-c284-605b26a6f667@os.amperecomputing.com> (raw) In-Reply-To: <20220422024653.2199489-9-quan@os.amperecomputing.com> Dear Lee Jones, Thank you for the comment as on the link: https://lore.kernel.org/lkml/202204230554.4528TqPu-lkp@intel.com/T/#m476dce286d806bb3713f689663fa631f5a1f0909 I'm not sure what happen (maybe due to my bad junk filter) but I could only see your email when checking the link mentioned above. I will try to response on each of your comment inline. Thank you very much for the comment. - Quan On 22/04/2022 09:46, Quan Nguyen wrote: > Adds Multi-function devices driver for SMpro co-processor found on the [Lee] Please drop the term MFD and describe the device instead. [Quan] Will replace MFD with "core" as your suggestion. > Mt.Jade hardware reference platform with Ampere's Altra processor family. > > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> > --- > Changes in v8: > + None > > Changes in v7: > + Smpro-mfd now significant changes in compare with simple-mfd-i2c > driver, remove the copyright note about simple-mfd-i2c [Quan] > + Install bus->read/write() to handle multiple types of bus > access. [Quan] > + Update license to MODULE_LICENSE("GPL") [Quan] > + Add others minor refactor the code [Quan] > > Changes in v6: > + Update license part to reflect that this driver is clone from > simple-mfd-i2c driver [Quan] > > Changes in v5: > + Dropped the use of simple-mfd-i2c driver [Quan] > + Introduced drivers/mfd/smpro-mfd.c driver to instantiate > sub-devices. This is to avoid DT nodes without resource issue [Quan] > + Revised commit message [Quan] > > Changes in v4: > + Add "depends on I2C" to fix build issue found by kernel test > robot [Guenter] > > Changes in v3: > + None > > Changes in v2: > + Used 'struct of_device_id's .data attribute [Lee Jones] > > drivers/mfd/Kconfig | 12 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/smpro-mfd.c | 134 ++++++++++++++++++++++++++++++++++++++++ [Lee] Please drop the 'mfd' part. Does 'core' work instead? [Quan] Will drop the MFD thoroughly in next version. > 3 files changed, 147 insertions(+) > create mode 100644 drivers/mfd/smpro-mfd.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3b59456f5545..383d0e6cfb91 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -77,6 +77,18 @@ config MFD_AS3711 > help > Support for the AS3711 PMIC from AMS > > +config MFD_SMPRO > + tristate "Ampere Computing MFD SMpro core driver" > + depends on I2C > + select MFD_CORE > + select REGMAP_I2C > + help > + Say yes here to enable SMpro driver support for Ampere's Altra > + processor family. > + > + Ampere's Altra SMpro exposes an I2C regmap interface that can > + be accessed by child devices. > + > config MFD_AS3722 > tristate "ams AS3722 Power Management IC" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 858cacf659d6..36f8981cc4fd 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -266,6 +266,7 @@ obj-$(CONFIG_MFD_QCOM_PM8008) += qcom-pm8008.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > +obj-$(CONFIG_MFD_SMPRO) += smpro-mfd.o > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > obj-$(CONFIG_MFD_ATC260X) += atc260x-core.o > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c > new file mode 100644 > index 000000000000..485c4f89ebd9 > --- /dev/null > +++ b/drivers/mfd/smpro-mfd.c > @@ -0,0 +1,134 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Ampere Altra Family SMPro MFD - I2C > + * > + * Copyright (c) 2022, Ampere Computing LLC > + * Author: Quan Nguyen <quan@os.amperecomputing..com> > + */ > + > +#include <linux/i2c.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/of_platform.h> > +#include <linux/mfd/core.h> > +#include <linux/regmap.h> > + [Lee] Alphabetical. [Quan] Will sort the included files follow alphbetical order in next version. > +/* Identification Registers */ > +#define MANUFACTURER_ID_REG 0x02 > +#define AMPERE_MANUFACTURER_ID 0xCD3A > + > +static int smpro_mfd_write(void *context, const void *data, size_t count) > +{ > + struct device *dev = context; > + struct i2c_client *i2c = to_i2c_client(dev); > + int ret; > + > + ret = i2c_master_send(i2c, data, count); > + if (ret == count) > + return 0; > + else if (ret < 0) > + return ret; > + else > + return -EIO; > +} > + > +static int smpro_mfd_read(void *context, const void *reg, size_t reg_size, > + void *val, size_t val_size) > +{ > + struct device *dev = context; > + struct i2c_client *i2c = to_i2c_client(dev); > + struct i2c_msg xfer[2]; > + unsigned char buf[2]; > + int ret; > + > + xfer[0].addr = i2c->addr; > + xfer[0].flags = 0; > + > + buf[0] = *(u8 *)reg; > + buf[1] = val_size; > + xfer[0].len = 2; > + xfer[0].buf = buf; > + > + xfer[1].addr = i2c->addr; > + xfer[1].flags = I2C_M_RD; > + xfer[1].len = val_size; > + xfer[1].buf = val; > + > + ret = i2c_transfer(i2c->adapter, xfer, 2); > + if (ret == 2) > + return 0; > + else if (ret < 0) > + return ret; > + else > + return -EIO; > +} > + [Lee] This looks all too familiar. I wonder how generic these i2c call-backs actually are. [Quan] yes, this is similar with regmap_i2c_read() but with reg_size is force to 2. We can reuse regmap_i2c_read() but it needs to be exported from drivers/base/regmap/regmap-i2c.c > +static const struct regmap_bus smpro_regmap_bus = { > + .read = smpro_mfd_read, > + .write = smpro_mfd_write, > + .val_format_endian_default = REGMAP_ENDIAN_BIG, > +}; > + > +static bool smpro_mfd_readable_noinc_reg(struct device *dev, unsigned int reg) > +{ > + return (reg == 0x82 || reg == 0x85 || reg == 0x92 || reg == 0x95 || > + reg == 0xC2 || reg == 0xC5 || reg == 0xD2 || reg == 0xDA); > +} [Lee] No magic numbers. Please define these registers. [Quan] Will fix this in next version. > + > +static const struct regmap_config smpro_regmap_config = { > + .reg_bits = 8, > + .val_bits = 16, > + .readable_noinc_reg = smpro_mfd_readable_noinc_reg, > +}; > + > +static const struct mfd_cell smpro_devs[] = { > + MFD_CELL_NAME("smpro-hwmon"), > + MFD_CELL_NAME("smpro-errmon"), > + MFD_CELL_NAME("smpro-misc"), > +}; > + > +static int smpro_mfd_probe(struct i2c_client *i2c) > +{ > + const struct regmap_config *config; > + struct regmap *regmap; > + unsigned int val; > + int ret; > + > + config = device_get_match_data(&i2c->dev); > + if (!config) > + config = &smpro_regmap_config; > + [Lee] This use-case is not currently supported. Please return an error instead. [Quan] Will update in next version. > + regmap = devm_regmap_init(&i2c->dev, &smpro_regmap_bus, &i2c->dev, config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + /* Check for valid ID */ [Lee] Decent #define nomenclature should render this comment superfluous. [Quan] Thanks, will remove in next version. > + ret = regmap_read(regmap, MANUFACTURER_ID_REG, &val); > + if (ret) > + return ret; > + > + if (val != AMPERE_MANUFACTURER_ID) > + return -ENODEV; > + > + return devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO, > + smpro_devs, ARRAY_SIZE(smpro_devs), NULL, 0, NULL); > +} > + > +static const struct of_device_id smpro_mfd_of_match[] = { > + { .compatible = "ampere,smpro", .data = &smpro_regmap_config }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, smpro_mfd_of_match); > + > +static struct i2c_driver smpro_mfd_driver = { > + .probe_new = smpro_mfd_probe, > + .driver = { > + .name = "smpro-mfd-i2c", [Lee] "smpro-core" [Quan] Will change mfd to "core" thoroughly. Thanks for the review. > + .of_match_table = smpro_mfd_of_match, > + }, > +}; > +module_i2c_driver(smpro_mfd_driver); > + > +MODULE_AUTHOR("Quan Nguyen <quan@os.amperecomputing.com>"); > +MODULE_DESCRIPTION("SMPRO MFD - I2C driver"); > +MODULE_LICENSE("GPL");
WARNING: multiple messages have this Message-ID (diff)
From: Quan Nguyen <quan@os.amperecomputing.com> To: Lee Jones <lee.jones@linaro.org> Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>, Phong Vo <phong@os.amperecomputing.com>, Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dragan Cvetic <dragan.cvetic@xilinx.com>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Thang Q . Nguyen" <thang@os.amperecomputing.com>, OpenBMC Maillist <openbmc@lists.ozlabs.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Derek Kiernan <derek.kiernan@xilinx.com>, Open Source Submission <patches@amperecomputing.com>, Thu Nguyen <thu@os.amperecomputing.com>, Guenter Roeck <linux@roeck-us.net> Subject: Re: [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro MFD driver Date: Wed, 29 Jun 2022 16:23:26 +0700 [thread overview] Message-ID: <2d3b395d-affa-a651-c284-605b26a6f667@os.amperecomputing.com> (raw) In-Reply-To: <20220422024653.2199489-9-quan@os.amperecomputing.com> Dear Lee Jones, Thank you for the comment as on the link: https://lore.kernel.org/lkml/202204230554.4528TqPu-lkp@intel.com/T/#m476dce286d806bb3713f689663fa631f5a1f0909 I'm not sure what happen (maybe due to my bad junk filter) but I could only see your email when checking the link mentioned above. I will try to response on each of your comment inline. Thank you very much for the comment. - Quan On 22/04/2022 09:46, Quan Nguyen wrote: > Adds Multi-function devices driver for SMpro co-processor found on the [Lee] Please drop the term MFD and describe the device instead. [Quan] Will replace MFD with "core" as your suggestion. > Mt.Jade hardware reference platform with Ampere's Altra processor family. > > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> > --- > Changes in v8: > + None > > Changes in v7: > + Smpro-mfd now significant changes in compare with simple-mfd-i2c > driver, remove the copyright note about simple-mfd-i2c [Quan] > + Install bus->read/write() to handle multiple types of bus > access. [Quan] > + Update license to MODULE_LICENSE("GPL") [Quan] > + Add others minor refactor the code [Quan] > > Changes in v6: > + Update license part to reflect that this driver is clone from > simple-mfd-i2c driver [Quan] > > Changes in v5: > + Dropped the use of simple-mfd-i2c driver [Quan] > + Introduced drivers/mfd/smpro-mfd.c driver to instantiate > sub-devices. This is to avoid DT nodes without resource issue [Quan] > + Revised commit message [Quan] > > Changes in v4: > + Add "depends on I2C" to fix build issue found by kernel test > robot [Guenter] > > Changes in v3: > + None > > Changes in v2: > + Used 'struct of_device_id's .data attribute [Lee Jones] > > drivers/mfd/Kconfig | 12 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/smpro-mfd.c | 134 ++++++++++++++++++++++++++++++++++++++++ [Lee] Please drop the 'mfd' part. Does 'core' work instead? [Quan] Will drop the MFD thoroughly in next version. > 3 files changed, 147 insertions(+) > create mode 100644 drivers/mfd/smpro-mfd.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3b59456f5545..383d0e6cfb91 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -77,6 +77,18 @@ config MFD_AS3711 > help > Support for the AS3711 PMIC from AMS > > +config MFD_SMPRO > + tristate "Ampere Computing MFD SMpro core driver" > + depends on I2C > + select MFD_CORE > + select REGMAP_I2C > + help > + Say yes here to enable SMpro driver support for Ampere's Altra > + processor family. > + > + Ampere's Altra SMpro exposes an I2C regmap interface that can > + be accessed by child devices. > + > config MFD_AS3722 > tristate "ams AS3722 Power Management IC" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 858cacf659d6..36f8981cc4fd 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -266,6 +266,7 @@ obj-$(CONFIG_MFD_QCOM_PM8008) += qcom-pm8008.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > +obj-$(CONFIG_MFD_SMPRO) += smpro-mfd.o > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > obj-$(CONFIG_MFD_ATC260X) += atc260x-core.o > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c > new file mode 100644 > index 000000000000..485c4f89ebd9 > --- /dev/null > +++ b/drivers/mfd/smpro-mfd.c > @@ -0,0 +1,134 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Ampere Altra Family SMPro MFD - I2C > + * > + * Copyright (c) 2022, Ampere Computing LLC > + * Author: Quan Nguyen <quan@os.amperecomputing..com> > + */ > + > +#include <linux/i2c.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/of_platform.h> > +#include <linux/mfd/core.h> > +#include <linux/regmap.h> > + [Lee] Alphabetical. [Quan] Will sort the included files follow alphbetical order in next version. > +/* Identification Registers */ > +#define MANUFACTURER_ID_REG 0x02 > +#define AMPERE_MANUFACTURER_ID 0xCD3A > + > +static int smpro_mfd_write(void *context, const void *data, size_t count) > +{ > + struct device *dev = context; > + struct i2c_client *i2c = to_i2c_client(dev); > + int ret; > + > + ret = i2c_master_send(i2c, data, count); > + if (ret == count) > + return 0; > + else if (ret < 0) > + return ret; > + else > + return -EIO; > +} > + > +static int smpro_mfd_read(void *context, const void *reg, size_t reg_size, > + void *val, size_t val_size) > +{ > + struct device *dev = context; > + struct i2c_client *i2c = to_i2c_client(dev); > + struct i2c_msg xfer[2]; > + unsigned char buf[2]; > + int ret; > + > + xfer[0].addr = i2c->addr; > + xfer[0].flags = 0; > + > + buf[0] = *(u8 *)reg; > + buf[1] = val_size; > + xfer[0].len = 2; > + xfer[0].buf = buf; > + > + xfer[1].addr = i2c->addr; > + xfer[1].flags = I2C_M_RD; > + xfer[1].len = val_size; > + xfer[1].buf = val; > + > + ret = i2c_transfer(i2c->adapter, xfer, 2); > + if (ret == 2) > + return 0; > + else if (ret < 0) > + return ret; > + else > + return -EIO; > +} > + [Lee] This looks all too familiar. I wonder how generic these i2c call-backs actually are. [Quan] yes, this is similar with regmap_i2c_read() but with reg_size is force to 2. We can reuse regmap_i2c_read() but it needs to be exported from drivers/base/regmap/regmap-i2c.c > +static const struct regmap_bus smpro_regmap_bus = { > + .read = smpro_mfd_read, > + .write = smpro_mfd_write, > + .val_format_endian_default = REGMAP_ENDIAN_BIG, > +}; > + > +static bool smpro_mfd_readable_noinc_reg(struct device *dev, unsigned int reg) > +{ > + return (reg == 0x82 || reg == 0x85 || reg == 0x92 || reg == 0x95 || > + reg == 0xC2 || reg == 0xC5 || reg == 0xD2 || reg == 0xDA); > +} [Lee] No magic numbers. Please define these registers. [Quan] Will fix this in next version. > + > +static const struct regmap_config smpro_regmap_config = { > + .reg_bits = 8, > + .val_bits = 16, > + .readable_noinc_reg = smpro_mfd_readable_noinc_reg, > +}; > + > +static const struct mfd_cell smpro_devs[] = { > + MFD_CELL_NAME("smpro-hwmon"), > + MFD_CELL_NAME("smpro-errmon"), > + MFD_CELL_NAME("smpro-misc"), > +}; > + > +static int smpro_mfd_probe(struct i2c_client *i2c) > +{ > + const struct regmap_config *config; > + struct regmap *regmap; > + unsigned int val; > + int ret; > + > + config = device_get_match_data(&i2c->dev); > + if (!config) > + config = &smpro_regmap_config; > + [Lee] This use-case is not currently supported. Please return an error instead. [Quan] Will update in next version. > + regmap = devm_regmap_init(&i2c->dev, &smpro_regmap_bus, &i2c->dev, config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + /* Check for valid ID */ [Lee] Decent #define nomenclature should render this comment superfluous. [Quan] Thanks, will remove in next version. > + ret = regmap_read(regmap, MANUFACTURER_ID_REG, &val); > + if (ret) > + return ret; > + > + if (val != AMPERE_MANUFACTURER_ID) > + return -ENODEV; > + > + return devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO, > + smpro_devs, ARRAY_SIZE(smpro_devs), NULL, 0, NULL); > +} > + > +static const struct of_device_id smpro_mfd_of_match[] = { > + { .compatible = "ampere,smpro", .data = &smpro_regmap_config }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, smpro_mfd_of_match); > + > +static struct i2c_driver smpro_mfd_driver = { > + .probe_new = smpro_mfd_probe, > + .driver = { > + .name = "smpro-mfd-i2c", [Lee] "smpro-core" [Quan] Will change mfd to "core" thoroughly. Thanks for the review. > + .of_match_table = smpro_mfd_of_match, > + }, > +}; > +module_i2c_driver(smpro_mfd_driver); > + > +MODULE_AUTHOR("Quan Nguyen <quan@os.amperecomputing.com>"); > +MODULE_DESCRIPTION("SMPRO MFD - I2C driver"); > +MODULE_LICENSE("GPL");
next prev parent reply other threads:[~2022-06-29 9:24 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-22 2:46 [PATCH v8 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 1/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 2/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 3/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 6:20 ` Greg Kroah-Hartman 2022-04-22 6:20 ` Greg Kroah-Hartman 2022-04-22 14:43 ` Quan Nguyen 2022-04-22 14:43 ` Quan Nguyen 2022-04-22 14:57 ` Greg Kroah-Hartman 2022-04-22 14:57 ` Greg Kroah-Hartman 2022-04-22 17:07 ` Darren Hart 2022-04-22 17:07 ` Darren Hart 2022-04-22 23:21 ` Quan Nguyen 2022-04-22 23:21 ` Quan Nguyen 2022-06-01 8:21 ` Quan Nguyen 2022-06-01 8:21 ` Quan Nguyen 2022-06-01 9:33 ` Greg Kroah-Hartman 2022-06-01 9:33 ` Greg Kroah-Hartman 2022-06-02 9:36 ` Quan Nguyen 2022-06-02 9:36 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 4/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 6:27 ` Bagas Sanjaya 2022-04-22 6:27 ` Bagas Sanjaya 2022-04-22 2:46 ` [PATCH v8 5/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 6/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 7/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen 2022-04-22 21:19 ` kernel test robot 2022-04-22 21:19 ` kernel test robot 2022-06-15 22:14 ` Lee Jones 2022-06-15 22:14 ` Lee Jones 2022-06-29 9:23 ` Quan Nguyen [this message] 2022-06-29 9:23 ` Quan Nguyen 2022-04-22 2:46 ` [PATCH v8 9/9] docs: ABI: testing: Document the Ampere Altra Family's SMpro sysfs interfaces Quan Nguyen 2022-04-22 2:46 ` Quan Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2d3b395d-affa-a651-c284-605b26a6f667@os.amperecomputing.com \ --to=quan@os.amperecomputing.com \ --cc=arnd@arndb.de \ --cc=corbet@lwn.net \ --cc=derek.kiernan@xilinx.com \ --cc=devicetree@vger.kernel.org \ --cc=dragan.cvetic@xilinx.com \ --cc=gregkh@linuxfoundation.org \ --cc=jdelvare@suse.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=openbmc@lists.ozlabs.org \ --cc=patches@amperecomputing.com \ --cc=phong@os.amperecomputing.com \ --cc=robh+dt@kernel.org \ --cc=thang@os.amperecomputing.com \ --cc=thu@os.amperecomputing.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.