From: Chao Yu <yuchao0@huawei.com> To: Yunlong Song <yunlong.song@huawei.com>, <jaegeuk@kernel.org>, <chao@kernel.org>, <yunlong.song@icloud.com> Cc: <miaoxie@huawei.com>, <bintian.wang@huawei.com>, <shengyong1@huawei.com>, <heyunlei@huawei.com>, <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] f2fs: fix count of seg_freed to make sec_freed correct Date: Mon, 15 Oct 2018 20:35:07 +0800 [thread overview] Message-ID: <2d4c379a-77c2-4408-2f23-36753afb95bd@huawei.com> (raw) In-Reply-To: <1539168739-79848-1-git-send-email-yunlong.song@huawei.com> On 2018/10/10 18:52, Yunlong Song wrote: > When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before > gc starts, do_garbage_collect will skip counting seg_freed++, and this > will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++. > > Signed-off-by: Yunlong Song <yunlong.song@huawei.com> > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index a07241f..dc63cd5 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1160,10 +1160,10 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > stat_inc_seg_count(sbi, type, gc_type); > > +next: > if (gc_type == FG_GC && > get_valid_blocks(sbi, segno, false) == 0) > seg_freed++; > -next: How about: if (get_valid_blocks(sbi, segno, false) == 0) goto freed; if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi)) goto next; freed: if (gc_type == FG_GC && get_valid_blocks(sbi, segno, false) == 0) seg_freed++; next: > f2fs_put_page(sum_page, 0); > } > >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com> To: Yunlong Song <yunlong.song@huawei.com>, jaegeuk@kernel.org, chao@kernel.org, yunlong.song@icloud.com Cc: miaoxie@huawei.com, bintian.wang@huawei.com, shengyong1@huawei.com, heyunlei@huawei.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix count of seg_freed to make sec_freed correct Date: Mon, 15 Oct 2018 20:35:07 +0800 [thread overview] Message-ID: <2d4c379a-77c2-4408-2f23-36753afb95bd@huawei.com> (raw) In-Reply-To: <1539168739-79848-1-git-send-email-yunlong.song@huawei.com> On 2018/10/10 18:52, Yunlong Song wrote: > When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before > gc starts, do_garbage_collect will skip counting seg_freed++, and this > will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++. > > Signed-off-by: Yunlong Song <yunlong.song@huawei.com> > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index a07241f..dc63cd5 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1160,10 +1160,10 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > stat_inc_seg_count(sbi, type, gc_type); > > +next: > if (gc_type == FG_GC && > get_valid_blocks(sbi, segno, false) == 0) > seg_freed++; > -next: How about: if (get_valid_blocks(sbi, segno, false) == 0) goto freed; if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi)) goto next; freed: if (gc_type == FG_GC && get_valid_blocks(sbi, segno, false) == 0) seg_freed++; next: > f2fs_put_page(sum_page, 0); > } > >
next prev parent reply other threads:[~2018-10-15 12:35 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 10:52 [PATCH] f2fs: fix count of seg_freed to make sec_freed correct Yunlong Song 2018-10-10 10:52 ` Yunlong Song 2018-10-15 12:35 ` Chao Yu [this message] 2018-10-15 12:35 ` Chao Yu 2018-10-24 8:08 ` [PATCH v2] " Yunlong Song 2018-10-24 8:08 ` Yunlong Song 2018-10-24 9:31 ` Chao Yu 2018-10-24 9:31 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2d4c379a-77c2-4408-2f23-36753afb95bd@huawei.com \ --to=yuchao0@huawei.com \ --cc=bintian.wang@huawei.com \ --cc=chao@kernel.org \ --cc=heyunlei@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ --cc=miaoxie@huawei.com \ --cc=shengyong1@huawei.com \ --cc=yunlong.song@huawei.com \ --cc=yunlong.song@icloud.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.