QEMU native compile issue

QEMU native compile issue

[Johnathan Mantey]

[-- Attachment #1.1.1: Type: text/plain, Size: 608 bytes --]

Friday I ran into an issue compiling qemu-native.  I tracked the issue
to the the fact that the most recent kernel creates a new definition for
SIOCGSTAMP in sockios.h.  The prior definition was in sys/socket.h.  I
have pushed a change request to the QEMU code base.  It's a one-liner:

linux-user/syscall.c:
 #include <linux/random.h>
+#include <linux/sockios.h>


-- 
Johnathan Mantey
Senior Software Engineer
*azad te**chnology partners*
Contributing to Technology Innovation since 1992
Phone: (503) 712-6764
Email: johnathanx.mantey@intel.com <mailto:johnathanx.mantey@intel.com>


[-- Attachment #1.1.2: Type: text/html, Size: 1437 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: QEMU native compile issue

[Andrew Jeffery]

Hi Johnathan,

On Tue, 27 Aug 2019, at 05:39, Johnathan Mantey wrote:
> Friday I ran into an issue compiling qemu-native. I tracked the issue 
> to the the fact that the most recent kernel creates a new definition 
> for SIOCGSTAMP in sockios.h. The prior definition was in sys/socket.h. 
> I have pushed a change request to the QEMU code base. 

Can you provide a link to the change request that you pushed?

Cheers,

Andrew

Re: QEMU native compile issue

[Johnathan Mantey]

[-- Attachment #1.1.1: Type: text/plain, Size: 894 bytes --]

I've reviewed the QEMU commits:

6d5d5dde9a linux-user: fix to handle variably sized SIOCGSTAMP with new
kernels

I didn't push the commit to somewhere useful.

On 8/26/19 4:31 PM, Andrew Jeffery wrote:
> Hi Johnathan,
>
> On Tue, 27 Aug 2019, at 05:39, Johnathan Mantey wrote:
>> Friday I ran into an issue compiling qemu-native. I tracked the issue 
>> to the the fact that the most recent kernel creates a new definition 
>> for SIOCGSTAMP in sockios.h. The prior definition was in sys/socket.h. 
>> I have pushed a change request to the QEMU code base. 
> Can you provide a link to the change request that you pushed?
>
> Cheers,
>
> Andrew

-- 
Johnathan Mantey
Senior Software Engineer
*azad te**chnology partners*
Contributing to Technology Innovation since 1992
Phone: (503) 712-6764
Email: johnathanx.mantey@intel.com <mailto:johnathanx.mantey@intel.com>


[-- Attachment #1.1.2: Type: text/html, Size: 2052 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: QEMU native compile issue

[Andrew Jeffery]

On Wed, 28 Aug 2019, at 00:09, Johnathan Mantey wrote:
> Not really. I'm not sure where the code went.
> 
>  I cloned the OpenBMC QEMU, made my change, and then pushed the change 
> to "upstream". I have SHA "650af0e183 Fix compile error when using 
> kernel 5.2" as the text.

As you noted in your follow-up email you found the fix upstream. Further, the fix
is contained in the QEMU v4.1 tag.

Upstream open-embedded has already bumped QEMU to v4.1 - I guess we
should backport that change to openbmc/openbmc and this will be resolved.
I've Cc'ed Brad so he's across it.

As an aside, while we have the openbmc/qemu repo on GitHub, it's not
integrated into openbmc/openbmc, openbmc/qemu is a bit less volatile than
Cedric's legoater/qemu aspeed-4.x branches (as it's used for OpenBMC CI
purposes), but has more models implemented than what upstream typically
has (I intend to update openbmc/qemu to 4.1 with some of the patches from
legoater/qemu aspeed-4.2 on top in the near future). The QEMU that's built as
part of the OpenBMC build process is the upstream release.

Hope that helps.

Andrew

Re: QEMU native compile issue

[Brad Bishop]

at 8:08 PM, Andrew Jeffery <andrew@aj.id.au> wrote:

> On Wed, 28 Aug 2019, at 00:09, Johnathan Mantey wrote:
>> Not really. I'm not sure where the code went.
>>
>>  I cloned the OpenBMC QEMU, made my change, and then pushed the change
>> to "upstream". I have SHA "650af0e183 Fix compile error when using
>> kernel 5.2" as the text.
>
> As you noted in your follow-up email you found the fix upstream. Further,  
> the fix
> is contained in the QEMU v4.1 tag.
>
> Upstream open-embedded has already bumped QEMU to v4.1 - I guess we
> should backport that change to openbmc/openbmc and this will be resolved.
> I've Cc'ed Brad so he's across it.

I think this was picked up with openbmc  
c68388fccb8c0b5bf4d6b8efff91203796be98b2.

If that doesn’t have what we needed...I’m blocked on doing further oe-core  
updates because of this:

https://lists.ozlabs.org/pipermail/openbmc/2019-September/017984.html

-brad

Re: QEMU native compile issue

[Johnathan Mantey]

[-- Attachment #1.1.1: Type: text/plain, Size: 1463 bytes --]

Brad,

FYI...

Commit c68388fc.... is part of my latest pull, which is 9d227052b.

The upstream fix for QEMU native is not present in any commit 9d227052b.
When you are unblocked please collect the QEMU update.

On 9/9/19 4:57 AM, Brad Bishop wrote:
> at 8:08 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>> On Wed, 28 Aug 2019, at 00:09, Johnathan Mantey wrote:
>>> Not really. I'm not sure where the code went.
>>>
>>>  I cloned the OpenBMC QEMU, made my change, and then pushed the change
>>> to "upstream". I have SHA "650af0e183 Fix compile error when using
>>> kernel 5.2" as the text.
>>
>> As you noted in your follow-up email you found the fix upstream.
>> Further, the fix
>> is contained in the QEMU v4.1 tag.
>>
>> Upstream open-embedded has already bumped QEMU to v4.1 - I guess we
>> should backport that change to openbmc/openbmc and this will be
>> resolved.
>> I've Cc'ed Brad so he's across it.
>
> I think this was picked up with openbmc
> c68388fccb8c0b5bf4d6b8efff91203796be98b2.
>
> If that doesn’t have what we needed...I’m blocked on doing further
> oe-core updates because of this:
>
> https://lists.ozlabs.org/pipermail/openbmc/2019-September/017984.html
>
> -brad

-- 
Johnathan Mantey
Senior Software Engineer
*azad te**chnology partners*
Contributing to Technology Innovation since 1992
Phone: (503) 712-6764
Email: johnathanx.mantey@intel.com <mailto:johnathanx.mantey@intel.com>


[-- Attachment #1.1.2: Type: text/html, Size: 3157 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: QEMU native compile issue

[Brad Bishop]

at 5:45 PM, Johnathan Mantey <johnathanx.mantey@intel.com> wrote:

> Brad,
>
> FYI...
>
> Commit c68388fc.... is part of my latest pull, which is 9d227052b.
>
> The upstream fix for QEMU native is not present in any commit 9d227052b.
> When you are unblocked please collect the QEMU update.

Thanks to Patrick we are unblocked now, and I pulled poky master HEAD  
yesterday.  Everything looks good now?

-brad

Re: QEMU native compile issue

[Andrew Jeffery]

On Fri, 30 Aug 2019, at 09:38, Andrew Jeffery wrote:
>  (I intend to update openbmc/qemu to 4.1 with some of the patches from
> legoater/qemu aspeed-4.2 on top in the near future). 

I've now updated openbmc/qemu master to 4.1. CI appears to be chugging
along fine, but please keep an eye out for qemu-related failures.

Andrew