* [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available
@ 2014-05-19 6:41 Ján Tomko
2014-05-19 15:03 ` Eric Blake
2014-05-20 19:13 ` Luiz Capitulino
0 siblings, 2 replies; 3+ messages in thread
From: Ján Tomko @ 2014-05-19 6:41 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, aliguori, lcapitulino
If the guest hasn't updated the stats yet, instead of returning
an error, return '-1' for the stats and '0' as 'last-update'.
This lets applications ignore this without parsing the error message.
Related libvirt patch and discussion:
https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
hw/virtio/virtio-balloon.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 971a921..6661c53 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -111,11 +111,6 @@ static void balloon_stats_get_all(Object *obj, struct Visitor *v,
VirtIOBalloon *s = opaque;
int i;
- if (!s->stats_last_update) {
- error_setg(errp, "guest hasn't updated any stats yet");
- return;
- }
-
visit_start_struct(v, NULL, "guest-stats", name, 0, errp);
visit_type_int(v, &s->stats_last_update, "last-update", errp);
@@ -361,6 +356,8 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp)
s->dvq = virtio_add_queue(vdev, 128, virtio_balloon_handle_output);
s->svq = virtio_add_queue(vdev, 128, virtio_balloon_receive_stats);
+ reset_stats(s);
+
register_savevm(dev, "virtio-balloon", -1, 1,
virtio_balloon_save, virtio_balloon_load, s);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available
2014-05-19 6:41 [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available Ján Tomko
@ 2014-05-19 15:03 ` Eric Blake
2014-05-20 19:13 ` Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2014-05-19 15:03 UTC (permalink / raw)
To: Ján Tomko, qemu-devel; +Cc: mst, aliguori, lcapitulino
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On 05/19/2014 12:41 AM, Ján Tomko wrote:
> If the guest hasn't updated the stats yet, instead of returning
> an error, return '-1' for the stats and '0' as 'last-update'.
>
> This lets applications ignore this without parsing the error message.
>
> Related libvirt patch and discussion:
> https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html
>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> hw/virtio/virtio-balloon.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available
2014-05-19 6:41 [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available Ján Tomko
2014-05-19 15:03 ` Eric Blake
@ 2014-05-20 19:13 ` Luiz Capitulino
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Capitulino @ 2014-05-20 19:13 UTC (permalink / raw)
To: Ján Tomko; +Cc: qemu-devel, aliguori, mst
On Mon, 19 May 2014 08:41:21 +0200
Ján Tomko <jtomko@redhat.com> wrote:
> If the guest hasn't updated the stats yet, instead of returning
> an error, return '-1' for the stats and '0' as 'last-update'.
>
> This lets applications ignore this without parsing the error message.
>
> Related libvirt patch and discussion:
> https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html
>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> hw/virtio/virtio-balloon.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 971a921..6661c53 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -111,11 +111,6 @@ static void balloon_stats_get_all(Object *obj, struct Visitor *v,
> VirtIOBalloon *s = opaque;
> int i;
>
> - if (!s->stats_last_update) {
> - error_setg(errp, "guest hasn't updated any stats yet");
> - return;
> - }
> -
> visit_start_struct(v, NULL, "guest-stats", name, 0, errp);
> visit_type_int(v, &s->stats_last_update, "last-update", errp);
>
> @@ -361,6 +356,8 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp)
> s->dvq = virtio_add_queue(vdev, 128, virtio_balloon_handle_output);
> s->svq = virtio_add_queue(vdev, 128, virtio_balloon_receive_stats);
>
> + reset_stats(s);
> +
> register_savevm(dev, "virtio-balloon", -1, 1,
> virtio_balloon_save, virtio_balloon_load, s);
>
Looks good to me, but I have some comments:
- I'm assuming you tested this against libivrt, right? It's good to add
a comment in the changelog mentioning that
- You have to update the documentation in docs/virtio-balloon-stats.txt
as well. There are two sections to update, the one describing the last-update
key (where you should mention what it means when last-update=0) and the
section saying that polling can be enabled even when the guest doesn't have
stats support (I'd mention that last-update=0 for that case)
- Please, rebase on top of latest master
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-20 19:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-19 6:41 [Qemu-devel] [PATCH] virtio-balloon: return empty data when no stats are available Ján Tomko
2014-05-19 15:03 ` Eric Blake
2014-05-20 19:13 ` Luiz Capitulino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.