All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Joe Perches <joe@perches.com>, Bin Liu <b-liu@ti.com>
Cc: <tony@atomide.com>, <gregkh@linuxfoundation.org>,
	<vinod.koul@intel.com>, <linux-usb@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <balbi@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size
Date: Thu, 11 May 2017 09:19:17 +0300	[thread overview]
Message-ID: <2d693d53-ba32-1549-90bd-da92f061cbed@ti.com> (raw)
In-Reply-To: <1494458188.2028.5.camel@perches.com>



On 2017-05-11 02:16, Joe Perches wrote:
> On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote:
>> On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote:
>>> We have one register for each EP to set the maximum packet size for both
>>> TX and RX.
>>> If for example an RX programming would happen before the previous TX
>>> transfer finishes we would reset the TX packet side.
>>>
>>> To fix this issue, only modify the TX or RX part of the register.
> []
>>> diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
> []
>>> @@ -389,15 +389,19 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz,
>>>   
>>>   	if (chdat->tx) {
>>>   		/* Send transfer_packet_sz packets at a time */
>>> -		musb_writel(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET,
>>> -			chdat->transfer_packet_sz);
>>> +		u32 psize = musb_readl(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET);
>>
>> checkpatch.pl complains about declaration and assignment together.
> 
> No it doesn't.

It 'only' complains about:
WARNING: Missing a blank line after declarations

which is valid.

- Péter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Joe Perches <joe@perches.com>, Bin Liu <b-liu@ti.com>
Cc: tony@atomide.com, gregkh@linuxfoundation.org,
	vinod.koul@intel.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, balbi@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size
Date: Thu, 11 May 2017 09:19:17 +0300	[thread overview]
Message-ID: <2d693d53-ba32-1549-90bd-da92f061cbed@ti.com> (raw)
In-Reply-To: <1494458188.2028.5.camel@perches.com>



On 2017-05-11 02:16, Joe Perches wrote:
> On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote:
>> On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote:
>>> We have one register for each EP to set the maximum packet size for both
>>> TX and RX.
>>> If for example an RX programming would happen before the previous TX
>>> transfer finishes we would reset the TX packet side.
>>>
>>> To fix this issue, only modify the TX or RX part of the register.
> []
>>> diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
> []
>>> @@ -389,15 +389,19 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz,
>>>   
>>>   	if (chdat->tx) {
>>>   		/* Send transfer_packet_sz packets at a time */
>>> -		musb_writel(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET,
>>> -			chdat->transfer_packet_sz);
>>> +		u32 psize = musb_readl(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET);
>>
>> checkpatch.pl complains about declaration and assignment together.
> 
> No it doesn't.

It 'only' complains about:
WARNING: Missing a blank line after declarations

which is valid.

- Péter

  reply	other threads:[~2017-05-11  6:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  8:42 [PATCH v2 00/10] usb: musb: tusb6010_omap: Convert to DMAengine Peter Ujfalusi
2017-05-10  8:42 ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 01/10] dmaengine: omap-dma: port_window support correction for both direction Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10 16:28   ` Tony Lindgren
2017-05-10  8:42 ` [PATCH v2 02/10] usb: musb: Add quirk to avoid skb reserve in gadget mode Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 03/10] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 04/10] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10 16:28   ` Tony Lindgren
2017-05-10 16:28     ` Tony Lindgren
2017-05-10 17:07   ` Bin Liu
2017-05-10 17:07     ` Bin Liu
2017-05-10 23:16     ` Joe Perches
2017-05-11  6:19       ` Peter Ujfalusi [this message]
2017-05-11  6:19         ` Peter Ujfalusi
2017-05-11 14:12         ` Bin Liu
2017-05-11 14:12           ` Bin Liu
2017-05-12  6:53           ` Peter Ujfalusi
2017-05-12  6:53             ` Peter Ujfalusi
2017-05-12 12:07             ` Bin Liu
2017-05-12 12:07               ` Bin Liu
2017-05-10  8:42 ` [PATCH v2 06/10] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 07/10] usb: musb: tusb6010_omap: Allocate DMA channels upfront Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 08/10] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10  8:42 ` [PATCH v2 09/10] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines Peter Ujfalusi
2017-05-10  8:42   ` Peter Ujfalusi
2017-05-10 16:30   ` Tony Lindgren
2017-05-10  8:51 ` [PATCH v2 10/10] usb: musb: tusb6010_omap: Convert to DMAengine API Peter Ujfalusi
2017-05-10  8:51   ` Peter Ujfalusi
2017-05-10 16:32 ` [PATCH v2 00/10] usb: musb: tusb6010_omap: Convert to DMAengine Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d693d53-ba32-1549-90bd-da92f061cbed@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.