All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory
Date: Tue, 30 Oct 2018 17:53:43 -0700	[thread overview]
Message-ID: <2d858eb1-56d6-5c3e-7c7e-9e36b1ad04fc@grimberg.me> (raw)
In-Reply-To: <20181030183252.17857-7-axboe@kernel.dk>


> It can be useful for a user to verify what type a given hardware
> queue is, expose this information in sysfs.

I assume the user is expected to understand the meaning of the
enumeration it sees in accessing this field correct?

Would be nice to output some meaningful string but I'm not
yet sure how to do that, but would be nice...

Other than that,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory
Date: Tue, 30 Oct 2018 17:53:43 -0700	[thread overview]
Message-ID: <2d858eb1-56d6-5c3e-7c7e-9e36b1ad04fc@grimberg.me> (raw)
In-Reply-To: <20181030183252.17857-7-axboe@kernel.dk>


> It can be useful for a user to verify what type a given hardware
> queue is, expose this information in sysfs.

I assume the user is expected to understand the meaning of the
enumeration it sees in accessing this field correct?

Would be nice to output some meaningful string but I'm not
yet sure how to do that, but would be nice...

Other than that,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

  reply	other threads:[~2018-10-31  0:53 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 18:32 [PATCHSET v3 0/16] blk-mq: Add support for multiple queue maps Jens Axboe
2018-10-30 18:32 ` Jens Axboe
2018-10-30 18:32 ` [PATCH 01/16] blk-mq: kill q->mq_map Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:28   ` Sagi Grimberg
2018-10-31  0:28     ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 02/16] blk-mq: abstract out queue map Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:31   ` Sagi Grimberg
2018-10-31  0:31     ` Sagi Grimberg
2018-10-31 14:17     ` Jens Axboe
2018-10-31 14:17       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 03/16] blk-mq: provide dummy blk_mq_map_queue_type() helper Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:32   ` Sagi Grimberg
2018-10-31  0:32     ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 04/16] blk-mq: pass in request/bio flags to queue mapping Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:37   ` Sagi Grimberg
2018-10-31  0:37     ` Sagi Grimberg
2018-10-31 14:18     ` Jens Axboe
2018-10-31 14:18       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 05/16] blk-mq: allow software queue to map to multiple hardware queues Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:49   ` Sagi Grimberg
2018-10-31  0:49     ` Sagi Grimberg
2018-10-31 14:19     ` Jens Axboe
2018-10-31 14:19       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:53   ` Sagi Grimberg [this message]
2018-10-31  0:53     ` Sagi Grimberg
2018-10-31 14:21     ` Jens Axboe
2018-10-31 14:21       ` Jens Axboe
2018-11-01 21:59   ` Omar Sandoval
2018-11-01 21:59     ` Omar Sandoval
2018-11-01 22:50     ` Jens Axboe
2018-11-01 22:50       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 07/16] blk-mq: support multiple hctx maps Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  0:59   ` Sagi Grimberg
2018-10-31  0:59     ` Sagi Grimberg
2018-10-31 14:23     ` Jens Axboe
2018-10-31 14:23       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 08/16] blk-mq: separate number of hardware queues from nr_cpu_ids Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:00   ` Sagi Grimberg
2018-10-31  1:00     ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 09/16] blk-mq: cache request hardware queue mapping Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:01   ` Sagi Grimberg
2018-10-31  1:01     ` Sagi Grimberg
2018-11-01  9:27   ` Hannes Reinecke
2018-11-01  9:27     ` Hannes Reinecke
2018-11-01 12:22     ` Jens Axboe
2018-11-01 12:22       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 10/16] blk-mq: cleanup and improve list insertion Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:03   ` Sagi Grimberg
2018-10-31  1:03     ` Sagi Grimberg
2018-11-01  9:28   ` Hannes Reinecke
2018-11-01  9:28     ` Hannes Reinecke
2018-10-30 18:32 ` [PATCH 11/16] blk-mq: improve plug list sorting Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:04   ` Sagi Grimberg
2018-10-31  1:04     ` Sagi Grimberg
2018-11-01  9:30   ` Hannes Reinecke
2018-11-01  9:30     ` Hannes Reinecke
2018-10-30 18:32 ` [PATCH 12/16] blk-mq: initial support for multiple queue maps Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:14   ` Sagi Grimberg
2018-10-31  1:14     ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 13/16] irq: add support for allocating (and affinitizing) sets of IRQs Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:17   ` Sagi Grimberg
2018-10-31  1:17     ` Sagi Grimberg
2018-11-02 14:37   ` Ming Lei
2018-11-02 14:37     ` Ming Lei
2018-11-02 15:09     ` Keith Busch
2018-11-02 15:09       ` Keith Busch
2018-11-03  2:22       ` Ming Lei
2018-11-03  2:22         ` Ming Lei
2018-10-30 18:32 ` [PATCH 14/16] nvme: utilize two queue maps, one for reads and one for writes Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:57   ` Sagi Grimberg
2018-10-31  1:57     ` Sagi Grimberg
2018-10-31 14:32     ` Jens Axboe
2018-10-31 14:32       ` Jens Axboe
2018-10-30 18:32 ` [PATCH 15/16] block: add REQ_HIPRI and inherit it from IOCB_HIPRI Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-31  1:58   ` Sagi Grimberg
2018-10-31  1:58     ` Sagi Grimberg
2018-10-30 18:32 ` [PATCH 16/16] nvme: add separate poll queue map Jens Axboe
2018-10-30 18:32   ` Jens Axboe
2018-10-30 18:35 ` [PATCHSET v3 0/16] blk-mq: Add support for multiple queue maps Keith Busch
2018-10-30 18:35   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d858eb1-56d6-5c3e-7c7e-9e36b1ad04fc@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.