* [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning"
@ 2018-05-22 13:36 Wei Liu
2018-05-22 13:41 ` Jan Beulich
2018-05-29 10:30 ` Juergen Gross
0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2018-05-22 13:36 UTC (permalink / raw)
To: Xen-devel
Cc: Juergen Gross, Wei Liu, Ian Jackson, Tim Deegan,
Marek Marczykowski-Górecki, Jan Beulich
This reverts commit 437e00fea04becc91c1b6bc1c0baa636b067a5cc.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Fedora 28 appears to have fixed their gcc.
Arch Linux build with gcc 8.1 passes, too.
Cc: Tim Deegan <tim@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>
---
tools/debugger/kdd/kdd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c
index 61d769ece9..1bd5dd5992 100644
--- a/tools/debugger/kdd/kdd.c
+++ b/tools/debugger/kdd/kdd.c
@@ -695,10 +695,7 @@ static void kdd_handle_read_ctrl(kdd_state *s)
KDD_LOG(s, "Request outside of known control space\n");
len = 0;
} else {
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Warray-bounds"
memcpy(buf, ((uint8_t *)&ctrl.c32) + offset, len);
-#pragma GCC diagnostic pop
}
}
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning"
2018-05-22 13:36 [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning" Wei Liu
@ 2018-05-22 13:41 ` Jan Beulich
2018-05-29 10:30 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2018-05-22 13:41 UTC (permalink / raw)
To: Wei Liu
Cc: Juergen Gross, xen-devel, Ian Jackson, Marek Marczykowski, Tim Deegan
>>> On 22.05.18 at 15:36, <wei.liu2@citrix.com> wrote:
> This reverts commit 437e00fea04becc91c1b6bc1c0baa636b067a5cc.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Fedora 28 appears to have fixed their gcc.
>
> Arch Linux build with gcc 8.1 passes, too.
Wouldn't you want to move one or both of these up into the commit
message?
In any event - thanks for following up here in place of Marek!
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning"
2018-05-22 13:36 [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning" Wei Liu
2018-05-22 13:41 ` Jan Beulich
@ 2018-05-29 10:30 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2018-05-29 10:30 UTC (permalink / raw)
To: Wei Liu, Xen-devel
Cc: Ian Jackson, Tim Deegan, Marek Marczykowski-Górecki, Jan Beulich
On 22/05/18 15:36, Wei Liu wrote:
> This reverts commit 437e00fea04becc91c1b6bc1c0baa636b067a5cc.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-29 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 13:36 [PATCH for-4.11] Revert "tools/kdd: mute spurious gcc warning" Wei Liu
2018-05-22 13:41 ` Jan Beulich
2018-05-29 10:30 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.