All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Rob Herring <robh+dt@kernel.org>
Cc: Jonathan Marek <jonathan@marek.ca>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target
Date: Fri, 28 May 2021 18:33:47 +0300	[thread overview]
Message-ID: <2dc79aad-33cd-7b17-368f-d52d60d46811@linaro.org> (raw)
In-Reply-To: <20210407150157.801210-4-dmitry.baryshkov@linaro.org>

On 07/04/2021 18:01, Dmitry Baryshkov wrote:
> Move the bus clock to mdp device node,in order to facilitate bus band
> width scaling on sdm845 target.
> 
> The parent device MDSS will not vote for bus bw, instead the vote will
> be triggered by mdp device node. Since a minimum vote is required to
> turn on bus clock, move the clock node to mdp device from where the
> votes are requested.

drm/msm patches were merged through the msm tree (targeting 5.13). 
Shouldn't we also merge these two patches (targeting 5.13 as fixes or 5.14)?

> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 7395ef20b90e..55704804c2ca 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4136,9 +4136,8 @@ mdss: mdss@ae00000 {
>   			power-domains = <&dispcc MDSS_GDSC>;
>   
>   			clocks = <&gcc GCC_DISP_AHB_CLK>,
> -				 <&gcc GCC_DISP_AXI_CLK>,
>   				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
> -			clock-names = "iface", "bus", "core";
> +			clock-names = "iface", "core";
>   
>   			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
>   			assigned-clock-rates = <300000000>;
> @@ -4166,11 +4165,12 @@ mdss_mdp: mdp@ae01000 {
>   				      <0 0x0aeb0000 0 0x2008>;
>   				reg-names = "mdp", "vbif";
>   
> -				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> +				clocks = <&gcc GCC_DISP_AXI_CLK>,
> +					 <&dispcc DISP_CC_MDSS_AHB_CLK>,
>   					 <&dispcc DISP_CC_MDSS_AXI_CLK>,
>   					 <&dispcc DISP_CC_MDSS_MDP_CLK>,
>   					 <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> -				clock-names = "iface", "bus", "core", "vsync";
> +				clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
>   
>   				assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
>   						  <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> 


-- 
With best wishes
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, Jonathan Marek <jonathan@marek.ca>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 3/4] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target
Date: Fri, 28 May 2021 18:33:47 +0300	[thread overview]
Message-ID: <2dc79aad-33cd-7b17-368f-d52d60d46811@linaro.org> (raw)
In-Reply-To: <20210407150157.801210-4-dmitry.baryshkov@linaro.org>

On 07/04/2021 18:01, Dmitry Baryshkov wrote:
> Move the bus clock to mdp device node,in order to facilitate bus band
> width scaling on sdm845 target.
> 
> The parent device MDSS will not vote for bus bw, instead the vote will
> be triggered by mdp device node. Since a minimum vote is required to
> turn on bus clock, move the clock node to mdp device from where the
> votes are requested.

drm/msm patches were merged through the msm tree (targeting 5.13). 
Shouldn't we also merge these two patches (targeting 5.13 as fixes or 5.14)?

> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 7395ef20b90e..55704804c2ca 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4136,9 +4136,8 @@ mdss: mdss@ae00000 {
>   			power-domains = <&dispcc MDSS_GDSC>;
>   
>   			clocks = <&gcc GCC_DISP_AHB_CLK>,
> -				 <&gcc GCC_DISP_AXI_CLK>,
>   				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
> -			clock-names = "iface", "bus", "core";
> +			clock-names = "iface", "core";
>   
>   			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
>   			assigned-clock-rates = <300000000>;
> @@ -4166,11 +4165,12 @@ mdss_mdp: mdp@ae01000 {
>   				      <0 0x0aeb0000 0 0x2008>;
>   				reg-names = "mdp", "vbif";
>   
> -				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> +				clocks = <&gcc GCC_DISP_AXI_CLK>,
> +					 <&dispcc DISP_CC_MDSS_AHB_CLK>,
>   					 <&dispcc DISP_CC_MDSS_AXI_CLK>,
>   					 <&dispcc DISP_CC_MDSS_MDP_CLK>,
>   					 <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> -				clock-names = "iface", "bus", "core", "vsync";
> +				clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
>   
>   				assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
>   						  <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> 


-- 
With best wishes
Dmitry

  reply	other threads:[~2021-05-28 15:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 15:01 [PATCH v2 0/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
2021-04-07 15:01 ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 1/4] drm/msm/dpu: fill missing details in hw catalog for sdm845 and sm8[12]50 Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 2/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 3/4] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-05-28 15:33   ` Dmitry Baryshkov [this message]
2021-05-28 15:33     ` Dmitry Baryshkov
2021-05-31 14:42     ` Bjorn Andersson
2021-05-31 14:42       ` Bjorn Andersson
2021-05-31 18:03       ` Dmitry Baryshkov
2021-05-31 18:03         ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 4/4] arm64: dts: sm8250: move bus clock to mdp node for sm8250 target Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-05-31 14:58   ` Bjorn Andersson
2021-05-31 14:58     ` Bjorn Andersson
2021-05-31 17:28     ` Dmitry Baryshkov
2021-05-31 17:28       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dc79aad-33cd-7b17-368f-d52d60d46811@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jonathan@marek.ca \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.