From: Suzuki K Poulose <Suzuki.Poulose@arm.com> To: Mark Rutland <mark.rutland@arm.com> Cc: Thomas Gleixner <tglx@linutronix.de>, catalin.marinas@arm.com, will.deacon@arm.com, Peter Zijlstra <peterz@infradead.org>, Sebastian Siewior <bigeasy@linutronix.de>, LKML <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() Date: Thu, 27 Apr 2017 18:03:35 +0100 [thread overview] Message-ID: <2e321402-7042-9d5b-aa85-52b0e6f1e20c@arm.com> (raw) In-Reply-To: <20170427163546.GA30972@e107814-lin.cambridge.arm.com> On 27/04/17 17:35, Suzuki K Poulose wrote: > rom f3b0809224e4915197d3ae4a38ebe7f210e74abf Mon Sep 17 00:00:00 2001 > From: Mark Rutland <mark.rutland@arm.com> > Date: Thu, 27 Apr 2017 16:48:06 +0100 > Subject: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() > Build break alert. There are some issues with patch below. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Reported-by: Catalin Marinas <catalin.marinas@arm.com> > Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Suzuki Poulose <suzuki,poulose@arm.com> > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > arch/arm64/include/asm/cpufeature.h | 5 +++-- > arch/arm64/kernel/cpu_errata.c | 13 ++++++++++++- > arch/arm64/kernel/cpufeature.c | 5 ++++- > arch/arm64/kernel/smp.c | 7 +++---- > 4 files changed, 22 insertions(+), 8 deletions(-) > > void __init enable_errata_workarounds(void) > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 94b8f7f..62bdab4 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -966,6 +966,7 @@ static void __init setup_elf_hwcaps(const struct arm64_cpu_capabilities *hwcaps) > cap_set_elf_hwcap(hwcaps); > } > > +/* Should be called with CPU hotplug lock held */ > void update_cpu_capabilities(const struct arm64_cpu_capabilities *caps, > const char *info) > { > @@ -1092,7 +1093,9 @@ void check_local_cpu_capabilities(void) > > static void __init setup_feature_capabilities(void) > { > - update_cpu_capabilities(arm64_features, "detected feature:"); > + get_online_cpus(); > + update_cpu_capabilities(arm6_features, "detected feature:"); s/arm6_features/arm64_features And we need the following hunk: diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 62bdab4..19c359a 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1086,7 +1086,7 @@ void check_local_cpu_capabilities(void) * advertised capabilities. */ if (!sys_caps_initialised) - update_cpu_errata_workarounds(); + update_secondary_cpu_errata_workarounds(); else verify_local_cpu_capabilities(); } Sorry about that. Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki.Poulose@arm.com (Suzuki K Poulose) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() Date: Thu, 27 Apr 2017 18:03:35 +0100 [thread overview] Message-ID: <2e321402-7042-9d5b-aa85-52b0e6f1e20c@arm.com> (raw) In-Reply-To: <20170427163546.GA30972@e107814-lin.cambridge.arm.com> On 27/04/17 17:35, Suzuki K Poulose wrote: > rom f3b0809224e4915197d3ae4a38ebe7f210e74abf Mon Sep 17 00:00:00 2001 > From: Mark Rutland <mark.rutland@arm.com> > Date: Thu, 27 Apr 2017 16:48:06 +0100 > Subject: [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() > Build break alert. There are some issues with patch below. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Reported-by: Catalin Marinas <catalin.marinas@arm.com> > Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Suzuki Poulose <suzuki,poulose@arm.com> > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > arch/arm64/include/asm/cpufeature.h | 5 +++-- > arch/arm64/kernel/cpu_errata.c | 13 ++++++++++++- > arch/arm64/kernel/cpufeature.c | 5 ++++- > arch/arm64/kernel/smp.c | 7 +++---- > 4 files changed, 22 insertions(+), 8 deletions(-) > > void __init enable_errata_workarounds(void) > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 94b8f7f..62bdab4 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -966,6 +966,7 @@ static void __init setup_elf_hwcaps(const struct arm64_cpu_capabilities *hwcaps) > cap_set_elf_hwcap(hwcaps); > } > > +/* Should be called with CPU hotplug lock held */ > void update_cpu_capabilities(const struct arm64_cpu_capabilities *caps, > const char *info) > { > @@ -1092,7 +1093,9 @@ void check_local_cpu_capabilities(void) > > static void __init setup_feature_capabilities(void) > { > - update_cpu_capabilities(arm64_features, "detected feature:"); > + get_online_cpus(); > + update_cpu_capabilities(arm6_features, "detected feature:"); s/arm6_features/arm64_features And we need the following hunk: diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 62bdab4..19c359a 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1086,7 +1086,7 @@ void check_local_cpu_capabilities(void) * advertised capabilities. */ if (!sys_caps_initialised) - update_cpu_errata_workarounds(); + update_secondary_cpu_errata_workarounds(); else verify_local_cpu_capabilities(); } Sorry about that. Suzuki
next prev parent reply other threads:[~2017-04-27 17:03 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-18 17:04 [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem Thomas Gleixner 2017-04-18 17:04 ` [patch V2 01/24] cpu/hotplug: Provide cpuhp_setup/remove_state[_nocalls]_cpuslocked() Thomas Gleixner 2017-04-20 11:18 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 02/24] stop_machine: Provide stop_machine_cpuslocked() Thomas Gleixner 2017-04-20 11:19 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 03/24] padata: Make padata_alloc() static Thomas Gleixner 2017-04-20 11:19 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:04 ` [patch V2 04/24] padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata() Thomas Gleixner 2017-04-20 11:20 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 05/24] x86/mtrr: Remove get_online_cpus() from mtrr_save_state() Thomas Gleixner 2017-04-20 11:20 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 06/24] cpufreq: Use cpuhp_setup_state_nocalls_cpuslocked() Thomas Gleixner 2017-04-20 11:21 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 07/24] KVM/PPC/Book3S HV: " Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-20 11:21 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 08/24] hwtracing/coresight-etm3x: " Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-20 11:22 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-20 15:14 ` [patch V2 08/24] " Mathieu Poirier 2017-04-20 15:14 ` Mathieu Poirier 2017-04-20 15:32 ` Mathieu Poirier 2017-04-20 15:32 ` Mathieu Poirier 2017-04-18 17:04 ` [patch V2 09/24] hwtracing/coresight-etm4x: " Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-20 11:22 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 10/24] perf/x86/intel/cqm: Use cpuhp_setup_state_cpuslocked() Thomas Gleixner 2017-04-20 11:23 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 11/24] ARM/hw_breakpoint: " Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-19 17:54 ` Mark Rutland 2017-04-19 17:54 ` Mark Rutland 2017-04-19 18:20 ` Thomas Gleixner 2017-04-19 18:20 ` Thomas Gleixner 2017-04-20 11:23 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 12/24] s390/kernel: Use stop_machine_cpuslocked() Thomas Gleixner 2017-04-20 11:24 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 13/24] powerpc/powernv: " Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-20 11:24 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 14/24] cpu/hotplug: Use stop_machine_cpuslocked() in takedown_cpu() Thomas Gleixner 2017-04-20 11:25 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 15/24] x86/perf: Drop EXPORT of perf_check_microcode Thomas Gleixner 2017-04-20 11:25 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:04 ` [patch V2 16/24] perf/x86/intel: Drop get_online_cpus() in intel_snb_check_microcode() Thomas Gleixner 2017-04-20 11:26 ` [tip:smp/hotplug] " tip-bot for Sebastian Andrzej Siewior 2017-04-18 17:04 ` [patch V2 17/24] PCI: Use cpu_hotplug_disable() instead of get_online_cpus() Thomas Gleixner 2017-04-18 17:04 ` Thomas Gleixner 2017-04-20 11:27 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:05 ` [patch V2 18/24] PCI: Replace the racy recursion prevention Thomas Gleixner 2017-04-18 17:05 ` Thomas Gleixner 2017-04-20 11:27 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:05 ` [patch V2 19/24] ACPI/processor: Use cpu_hotplug_disable() instead of get_online_cpus() Thomas Gleixner 2017-04-20 11:28 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:05 ` [patch V2 20/24] perf/core: Remove redundant get_online_cpus() Thomas Gleixner 2017-04-20 11:28 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-04-18 17:05 ` [patch V2 21/24] jump_label: Pull get_online_cpus() into generic code Thomas Gleixner 2017-04-18 17:05 ` [patch V2 22/24] jump_label: Provide static_key_slow_inc_cpuslocked() Thomas Gleixner 2017-04-18 17:05 ` [patch V2 23/24] perf: Avoid cpu_hotplug_lock r-r recursion Thomas Gleixner 2017-04-18 17:05 ` [patch V2 24/24] cpu/hotplug: Convert hotplug locking to percpu rwsem Thomas Gleixner 2017-04-20 11:30 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner 2017-05-10 4:59 ` [patch V2 24/24] " Michael Ellerman 2017-05-10 8:49 ` Thomas Gleixner 2017-05-10 16:30 ` Steven Rostedt 2017-05-10 17:15 ` Steven Rostedt 2017-05-11 5:49 ` Michael Ellerman 2017-04-25 16:10 ` [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem Mark Rutland 2017-04-25 16:10 ` Mark Rutland 2017-04-25 17:28 ` Sebastian Siewior 2017-04-25 17:28 ` Sebastian Siewior 2017-04-26 8:59 ` Mark Rutland 2017-04-26 8:59 ` Mark Rutland 2017-04-26 9:40 ` Suzuki K Poulose 2017-04-26 9:40 ` Suzuki K Poulose 2017-04-26 10:32 ` Mark Rutland 2017-04-26 10:32 ` Mark Rutland 2017-04-27 8:27 ` Sebastian Siewior 2017-04-27 8:27 ` Sebastian Siewior 2017-04-27 9:57 ` Mark Rutland 2017-04-27 9:57 ` Mark Rutland 2017-04-27 10:01 ` Thomas Gleixner 2017-04-27 10:01 ` Thomas Gleixner 2017-04-27 12:30 ` Mark Rutland 2017-04-27 12:30 ` Mark Rutland 2017-04-27 15:48 ` [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() (was: Re: [patch V2 00/24] cpu/hotplug: Convert get_online_cpus() to a percpu_rwsem) Mark Rutland 2017-04-27 15:48 ` Mark Rutland 2017-04-27 16:35 ` Suzuki K Poulose 2017-04-27 16:35 ` Suzuki K Poulose 2017-04-27 17:03 ` Suzuki K Poulose [this message] 2017-04-27 17:03 ` [PATCH] arm64: cpufeature: use static_branch_enable_cpuslocked() Suzuki K Poulose 2017-04-27 17:17 ` Mark Rutland 2017-04-27 17:17 ` Mark Rutland 2017-04-28 14:24 ` [RFC PATCH] trace/perf: cure locking issue in perf_event_open() error path Sebastian Siewior 2017-04-28 14:27 ` Sebastian Siewior 2017-05-01 12:57 ` [tip:smp/hotplug] perf: Reorder cpu hotplug rwsem against cred_guard_mutex tip-bot for Thomas Gleixner 2017-05-01 12:58 ` [tip:smp/hotplug] perf: Push hotplug protection down to callers tip-bot for Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2e321402-7042-9d5b-aa85-52b0e6f1e20c@arm.com \ --to=suzuki.poulose@arm.com \ --cc=bigeasy@linutronix.de \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.