* [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules
@ 2014-12-01 13:00 Michal Simek
2014-12-02 9:31 ` Prabhakar Lad
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-12-01 13:00 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Andrew Morton, Laura Abbott, Olof Johansson, Catalin Marinas,
Will Deacon, Vladimir Zapolskiy, Prabhakar"
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Modules can use this function for creating pool.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
I am pushing Zynq OCMC driver which is using this function.
---
lib/genalloc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/genalloc.c b/lib/genalloc.c
index cce4dd68c40d..2e65d206b01c 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -598,6 +598,7 @@ struct gen_pool *devm_gen_pool_create(struct device *dev, int min_alloc_order,
return pool;
}
+EXPORT_SYMBOL(devm_gen_pool_create);
/**
* dev_get_gen_pool - Obtain the gen_pool (if any) for a device
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules
2014-12-01 13:00 [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules Michal Simek
@ 2014-12-02 9:31 ` Prabhakar Lad
2014-12-02 9:36 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Prabhakar Lad @ 2014-12-02 9:31 UTC (permalink / raw)
To: Michal Simek
Cc: LKML, monstr, Andrew Morton, Laura Abbott, Olof Johansson,
Catalin Marinas, Will Deacon, Vladimir Zapolskiy
Hi Michal,
Thanks for the patch.
On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> Modules can use this function for creating pool.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> I am pushing Zynq OCMC driver which is using this function.
>
> ---
> lib/genalloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
don’t you need to add an entry in include/linux/genalloc.h ?
Thanks,
--Prabhakar Lad
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index cce4dd68c40d..2e65d206b01c 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -598,6 +598,7 @@ struct gen_pool *devm_gen_pool_create(struct device *dev, int min_alloc_order,
>
> return pool;
> }
> +EXPORT_SYMBOL(devm_gen_pool_create);
>
> /**
> * dev_get_gen_pool - Obtain the gen_pool (if any) for a device
> --
> 1.8.2.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules
2014-12-02 9:31 ` Prabhakar Lad
@ 2014-12-02 9:36 ` Michal Simek
2014-12-02 9:42 ` Prabhakar Lad
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2014-12-02 9:36 UTC (permalink / raw)
To: Prabhakar Lad, Michal Simek
Cc: LKML, monstr, Andrew Morton, Laura Abbott, Olof Johansson,
Catalin Marinas, Will Deacon, Vladimir Zapolskiy
On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
> Hi Michal,
>
> Thanks for the patch.
>
> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Modules can use this function for creating pool.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> I am pushing Zynq OCMC driver which is using this function.
>>
>> ---
>> lib/genalloc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
> don’t you need to add an entry in include/linux/genalloc.h ?
Not sure what exactly you mean. declaration is there.
include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,
And all EXPORT_SYMBOL() are out of headers directly below function
which you want to export.
Can you please clarify what you did mean by that?
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules
2014-12-02 9:36 ` Michal Simek
@ 2014-12-02 9:42 ` Prabhakar Lad
0 siblings, 0 replies; 4+ messages in thread
From: Prabhakar Lad @ 2014-12-02 9:42 UTC (permalink / raw)
To: Michal Simek
Cc: LKML, monstr, Andrew Morton, Laura Abbott, Olof Johansson,
Catalin Marinas, Will Deacon, Vladimir Zapolskiy
Hi Michal,
On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
>> Hi Michal,
>>
>> Thanks for the patch.
>>
>> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>>> Modules can use this function for creating pool.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>> I am pushing Zynq OCMC driver which is using this function.
>>>
>>> ---
>>> lib/genalloc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>> don’t you need to add an entry in include/linux/genalloc.h ?
>
> Not sure what exactly you mean. declaration is there.
> include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,
>
> And all EXPORT_SYMBOL() are out of headers directly below function
> which you want to export.
>
> Can you please clarify what you did mean by that?
>
Oops missed it, since it was a exported function I was expecting a entry
in a header file, but yes the entry exists already so,
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Thanks,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-02 9:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-01 13:00 [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules Michal Simek
2014-12-02 9:31 ` Prabhakar Lad
2014-12-02 9:36 ` Michal Simek
2014-12-02 9:42 ` Prabhakar Lad
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.