From: John Harrison <john.c.harrison@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: IGT-Dev@Lists.FreeDesktop.Org, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH v3 i-g-t 12/15] tests/i915/gem_exec_fence: Configure correct context
Date: Thu, 13 Jan 2022 13:23:42 -0800 [thread overview]
Message-ID: <2e41be37-fe29-36e4-b55e-d50c0b2c3948@intel.com> (raw)
In-Reply-To: <20220113210617.GA31450@jons-linux-dev-box>
On 1/13/2022 13:06, Matthew Brost wrote:
> On Thu, Jan 13, 2022 at 11:59:44AM -0800, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The update to use intel_ctx_t missed a line that configures the
>> context to allow hanging. Fix that.
>>
>> Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f
> Typically I thought the Fixes comment was the sha from "git log
> --oneline" + first line of commit message from that surrounded by ("").
>
> So:
> Fixes: <small sha> ("<message>")
Oops, yeah. Not sure what happened here. Brain fart most likely ;).
John.
>
> With that fixed:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> ---
>> tests/i915/gem_exec_fence.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
>> index 196236b27..5e45d0518 100644
>> --- a/tests/i915/gem_exec_fence.c
>> +++ b/tests/i915/gem_exec_fence.c
>> @@ -3139,7 +3139,7 @@ igt_main
>> igt_hang_t hang;
>>
>> igt_fixture {
>> - hang = igt_allow_hang(i915, 0, 0);
>> + hang = igt_allow_hang(i915, ctx->id, 0);
>> intel_allocator_multiprocess_start();
>> }
>>
>> --
>> 2.25.1
>>
WARNING: multiple messages have this Message-ID (diff)
From: John Harrison <john.c.harrison@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: IGT-Dev@Lists.FreeDesktop.Org, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [igt-dev] [PATCH v3 i-g-t 12/15] tests/i915/gem_exec_fence: Configure correct context
Date: Thu, 13 Jan 2022 13:23:42 -0800 [thread overview]
Message-ID: <2e41be37-fe29-36e4-b55e-d50c0b2c3948@intel.com> (raw)
In-Reply-To: <20220113210617.GA31450@jons-linux-dev-box>
On 1/13/2022 13:06, Matthew Brost wrote:
> On Thu, Jan 13, 2022 at 11:59:44AM -0800, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The update to use intel_ctx_t missed a line that configures the
>> context to allow hanging. Fix that.
>>
>> Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f
> Typically I thought the Fixes comment was the sha from "git log
> --oneline" + first line of commit message from that surrounded by ("").
>
> So:
> Fixes: <small sha> ("<message>")
Oops, yeah. Not sure what happened here. Brain fart most likely ;).
John.
>
> With that fixed:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> ---
>> tests/i915/gem_exec_fence.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
>> index 196236b27..5e45d0518 100644
>> --- a/tests/i915/gem_exec_fence.c
>> +++ b/tests/i915/gem_exec_fence.c
>> @@ -3139,7 +3139,7 @@ igt_main
>> igt_hang_t hang;
>>
>> igt_fixture {
>> - hang = igt_allow_hang(i915, 0, 0);
>> + hang = igt_allow_hang(i915, ctx->id, 0);
>> intel_allocator_multiprocess_start();
>> }
>>
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-01-13 21:23 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 19:59 [Intel-gfx] [PATCH v3 i-g-t 00/15] Fixes for i915_hangman and gem_exec_capture John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 01/15] tests/i915/i915_hangman: Add descriptions John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 02/15] lib/hang: Fix igt_require_hang_ring to work with all engines John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 03/15] tests/i915/i915_hangman: Update capture test to use engine structure John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 19:58 ` [Intel-gfx] " Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 04/15] tests/i915/i915_hangman: Explicitly test per engine reset vs full GPU reset John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 05/15] tests/i915/i915_hangman: Add uevent test & fix detector John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 06/15] tests/i915/i915_hangman: Use the correct context in hangcheck_unterminated John.C.Harrison
2022-01-13 20:00 ` Matthew Brost
2022-01-13 20:00 ` [igt-dev] " Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 07/15] lib/store: Refactor common store code into helper function John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 20:10 ` [Intel-gfx] " Matthew Brost
2022-01-13 20:27 ` John Harrison
2022-01-13 20:27 ` John Harrison
2022-01-13 20:23 ` [Intel-gfx] " Matthew Brost
2022-01-13 20:23 ` Matthew Brost
2022-01-13 20:40 ` [Intel-gfx] " John Harrison
2022-01-13 20:40 ` John Harrison
2022-01-13 20:50 ` [Intel-gfx] [PATCH i-g-t] " John.C.Harrison
2022-01-13 20:50 ` [igt-dev] " John.C.Harrison
2022-01-13 20:53 ` [Intel-gfx] " Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 08/15] tests/i915/i915_hangman: Add alive-ness test after error capture John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 20:18 ` [Intel-gfx] " Matthew Brost
2022-01-13 20:18 ` [igt-dev] " Matthew Brost
2022-01-13 23:24 ` [Intel-gfx] [PATCH i-g-t] " John.C.Harrison
2022-01-13 23:24 ` [igt-dev] " John.C.Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 09/15] tests/i915/i915_hangman: Remove reliance on context persistance John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 20:30 ` [Intel-gfx] " Matthew Brost
2022-01-13 20:30 ` Matthew Brost
2022-01-13 20:42 ` [Intel-gfx] " John Harrison
2022-01-13 20:38 ` Matthew Brost
2022-01-13 20:38 ` Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 10/15] tests/i915/i915_hangman: Run background task on all engines John.C.Harrison
2022-01-13 20:48 ` Matthew Brost
2022-01-13 20:48 ` [igt-dev] " Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 11/15] tests/i915/i915_hangman: Don't let background contexts cause a ban John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 21:01 ` [Intel-gfx] " Matthew Brost
2022-01-13 21:01 ` Matthew Brost
2022-01-13 21:19 ` [Intel-gfx] " John Harrison
2022-01-13 21:19 ` John Harrison
2022-01-13 21:26 ` [Intel-gfx] [PATCH i-g-t] " John.C.Harrison
2022-01-13 22:30 ` Matthew Brost
2022-01-13 22:30 ` [igt-dev] " Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 12/15] tests/i915/gem_exec_fence: Configure correct context John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 21:06 ` [Intel-gfx] " Matthew Brost
2022-01-13 21:23 ` John Harrison [this message]
2022-01-13 21:23 ` John Harrison
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 13/15] lib/i915: Add helper for non-destructive engine property updates John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 22:33 ` [Intel-gfx] " Matthew Brost
2022-01-13 22:33 ` Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 14/15] tests/i915/i915_hangman: Configure engine properties for quicker hangs John.C.Harrison
2022-01-13 22:38 ` Matthew Brost
2022-01-13 19:59 ` [Intel-gfx] [PATCH v3 i-g-t 15/15] tests/i915/gem_exec_capture: Restore engines John.C.Harrison
2022-01-13 19:59 ` [igt-dev] " John.C.Harrison
2022-01-13 23:04 ` [Intel-gfx] " Matthew Brost
2022-01-13 23:04 ` Matthew Brost
2022-01-13 22:23 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fixes for i915_hangman and gem_exec_capture (rev6) Patchwork
2022-01-13 22:53 ` Matthew Brost
2022-01-13 23:15 ` John Harrison
2022-01-13 23:25 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Fixes for i915_hangman and gem_exec_capture (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e41be37-fe29-36e4-b55e-d50c0b2c3948@intel.com \
--to=john.c.harrison@intel.com \
--cc=IGT-Dev@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.