All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com,
	petkan@nucleusys.com, kuba@kernel.org, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address
Date: Sat, 3 Oct 2020 11:24:34 +0530	[thread overview]
Message-ID: <2e4f7bdb-76c0-9ee4-88bf-5d31ded17116@gmail.com> (raw)
In-Reply-To: <20201002.153849.1212074263659708172.davem@davemloft.net>


On 03-10-2020 04:08, David Miller wrote:
> From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> Date: Fri, 2 Oct 2020 17:04:13 +0530
>
>> But this patch is about ensuring that an uninitialized variable's
>> value (whatever that may be) is not set as the ethernet address
>> blindly (without any form of checking if get_registers() worked
>> as expected, or not).
> Right, and if you are going to check for errors then you have to
> handle the error properly.
>
> And the proper way to handle this error is to set a random ethernet
> address on the device.

Yes, I've understood that now.
I've prepared and tested a v3 accordingly, and will have it sent in soon enough.
Thank you so much for this!  :)

Thanks,
Anant


WARNING: multiple messages have this Message-ID (diff)
From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: petkan@nucleusys.com,
	syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuba@kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address
Date: Sat, 3 Oct 2020 11:24:34 +0530	[thread overview]
Message-ID: <2e4f7bdb-76c0-9ee4-88bf-5d31ded17116@gmail.com> (raw)
In-Reply-To: <20201002.153849.1212074263659708172.davem@davemloft.net>


On 03-10-2020 04:08, David Miller wrote:
> From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> Date: Fri, 2 Oct 2020 17:04:13 +0530
>
>> But this patch is about ensuring that an uninitialized variable's
>> value (whatever that may be) is not set as the ethernet address
>> blindly (without any form of checking if get_registers() worked
>> as expected, or not).
> Right, and if you are going to check for errors then you have to
> handle the error properly.
>
> And the proper way to handle this error is to set a random ethernet
> address on the device.

Yes, I've understood that now.
I've prepared and tested a v3 accordingly, and will have it sent in soon enough.
Thank you so much for this!  :)

Thanks,
Anant

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-10-03  5:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  7:32 [Linux-kernel-mentees][PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address Anant Thazhemadam
2020-10-01  7:32 ` [Linux-kernel-mentees] [PATCH " Anant Thazhemadam
2020-10-02  2:15 ` [Linux-kernel-mentees][PATCH " David Miller
2020-10-02  2:15   ` [Linux-kernel-mentees] [PATCH " David Miller
2020-10-02 11:34   ` Anant Thazhemadam
2020-10-02 11:34     ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-02 11:54     ` Greg KH
2020-10-02 11:54       ` [Linux-kernel-mentees] " Greg KH
2020-10-02 12:05       ` Anant Thazhemadam
2020-10-02 12:05         ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-02 14:29         ` Petko Manolov
2020-10-02 14:29           ` [Linux-kernel-mentees] " Petko Manolov
2020-10-03  5:51           ` Anant Thazhemadam
2020-10-03  5:51             ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-02 22:38     ` David Miller
2020-10-02 22:38       ` [Linux-kernel-mentees] " David Miller
2020-10-03  5:54       ` Anant Thazhemadam [this message]
2020-10-03  5:54         ` Anant Thazhemadam
2020-10-03 19:38 ` [Linux-kernel-mentees][PATCH " Joe Perches
2020-10-03 19:38   ` [Linux-kernel-mentees] [PATCH " Joe Perches
2020-10-03 20:58   ` Anant Thazhemadam
2020-10-03 20:58     ` [Linux-kernel-mentees] " Anant Thazhemadam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e4f7bdb-76c0-9ee4-88bf-5d31ded17116@gmail.com \
    --to=anant.thazhemadam@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=petkan@nucleusys.com \
    --cc=syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.