* [PATCH] travis.yml: Use clang++ in the Clang tests
@ 2020-05-18 8:33 Thomas Huth
2020-05-18 8:33 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2020-05-18 8:33 UTC (permalink / raw)
To: qemu-devel, Alex Bennée; +Cc: Philippe Mathieu-Daudé
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 1ec8a7b465..564be50a3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -205,14 +205,15 @@ jobs:
# Test with Clang for compile portability (Travis uses clang-5.0)
- name: "Clang (user)"
env:
- - CONFIG="--disable-system"
+ - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
compiler: clang
- name: "Clang (main-softmmu)"
env:
- - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
+ - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
+ --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
compiler: clang
before_script:
@@ -222,7 +223,8 @@ jobs:
- name: "Clang (other-softmmu)"
env:
- - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
+ - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
+ --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
compiler: clang
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] travis.yml: Use clang++ in the Clang tests
2020-05-18 8:33 [PATCH] travis.yml: Use clang++ in the Clang tests Thomas Huth
@ 2020-05-18 8:33 ` Thomas Huth
2020-05-18 9:15 ` Philippe Mathieu-Daudé
2020-05-18 12:44 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2020-05-18 8:33 UTC (permalink / raw)
To: qemu-devel, Alex Bennée; +Cc: Philippe Mathieu-Daudé
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 1ec8a7b465..564be50a3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -205,14 +205,15 @@ jobs:
# Test with Clang for compile portability (Travis uses clang-5.0)
- name: "Clang (user)"
env:
- - CONFIG="--disable-system"
+ - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
compiler: clang
- name: "Clang (main-softmmu)"
env:
- - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
+ - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
+ --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
compiler: clang
before_script:
@@ -222,7 +223,8 @@ jobs:
- name: "Clang (other-softmmu)"
env:
- - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
+ - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
+ --host-cc=clang --cxx=clang++"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
compiler: clang
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] travis.yml: Use clang++ in the Clang tests
2020-05-18 8:33 [PATCH] travis.yml: Use clang++ in the Clang tests Thomas Huth
2020-05-18 8:33 ` Thomas Huth
@ 2020-05-18 9:15 ` Philippe Mathieu-Daudé
2020-05-18 12:44 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-18 9:15 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Alex Bennée
On 5/18/20 10:33 AM, Thomas Huth wrote:
> Our configure script does not look for clang++ automatically, so we
> should use --cxx=clang++ to make sure that we test our C++ code with
> Clang, too. And while we're at it, also use --host-cc=clang here
> to avoid that we use the normal "cc" as host C compiler.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .travis.yml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 1ec8a7b465..564be50a3c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -205,14 +205,15 @@ jobs:
> # Test with Clang for compile portability (Travis uses clang-5.0)
> - name: "Clang (user)"
> env:
> - - CONFIG="--disable-system"
> + - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
> compiler: clang
>
>
> - name: "Clang (main-softmmu)"
> env:
> - - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
> + - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
> + --host-cc=clang --cxx=clang++"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
> compiler: clang
> before_script:
> @@ -222,7 +223,8 @@ jobs:
>
> - name: "Clang (other-softmmu)"
> env:
> - - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
> + - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
> + --host-cc=clang --cxx=clang++"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
> compiler: clang
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] travis.yml: Use clang++ in the Clang tests
2020-05-18 8:33 [PATCH] travis.yml: Use clang++ in the Clang tests Thomas Huth
2020-05-18 8:33 ` Thomas Huth
2020-05-18 9:15 ` Philippe Mathieu-Daudé
@ 2020-05-18 12:44 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-05-18 12:44 UTC (permalink / raw)
To: Thomas Huth; +Cc: Philippe Mathieu-Daudé, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> Our configure script does not look for clang++ automatically, so we
> should use --cxx=clang++ to make sure that we test our C++ code with
> Clang, too. And while we're at it, also use --host-cc=clang here
> to avoid that we use the normal "cc" as host C compiler.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-18 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 8:33 [PATCH] travis.yml: Use clang++ in the Clang tests Thomas Huth
2020-05-18 8:33 ` Thomas Huth
2020-05-18 9:15 ` Philippe Mathieu-Daudé
2020-05-18 12:44 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.