* [PATCH] mac80211: he_support was not set when bringing up a HE mesh interface
@ 2019-12-13 9:26 John Crispin
2019-12-13 9:32 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: John Crispin @ 2019-12-13 9:26 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Pradeep Kumar Chitrapu, Sven Eckelmann, John Crispin
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
The he_support flag inside bss_conf was not set when a HE mesh interface
gets created. This causes the drivers to not set the HW up correctly.
Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh")
Cc: Sven Eckelmann <seckelmann@datto.com>
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
---
net/mac80211/mesh.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
index d09b3c789314..98d70f4ef6a4 100644
--- a/net/mac80211/mesh.c
+++ b/net/mac80211/mesh.c
@@ -551,6 +551,8 @@ int mesh_add_he_cap_ie(struct ieee80211_sub_if_data *sdata,
sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
return 0;
+ sdata->vif.bss_conf.he_support = 1;
+
if (skb_tailroom(skb) < ie_len)
return -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: he_support was not set when bringing up a HE mesh interface
2019-12-13 9:26 [PATCH] mac80211: he_support was not set when bringing up a HE mesh interface John Crispin
@ 2019-12-13 9:32 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2019-12-13 9:32 UTC (permalink / raw)
To: John Crispin; +Cc: linux-wireless, Pradeep Kumar Chitrapu, Sven Eckelmann
> From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>
> The he_support flag inside bss_conf was not set when a HE mesh interface
> gets created. This causes the drivers to not set the HW up correctly.
This is all wrong ... it doesn't even explain the change.
Also, the subject? Really? I know you can all do better.
> Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh")
>
> Cc: Sven Eckelmann <seckelmann@datto.com>
The fixes should also be part of the footer.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-13 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 9:26 [PATCH] mac80211: he_support was not set when bringing up a HE mesh interface John Crispin
2019-12-13 9:32 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.