All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: Alexander.Deucher@amd.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit'
Date: Wed, 26 May 2021 15:59:00 +0200	[thread overview]
Message-ID: <2e692137-b837-adea-6e64-ab1c2a091555@gmail.com> (raw)
In-Reply-To: <20210525184431.1170373-1-andrey.grodzovsky@amd.com>



Am 25.05.21 um 20:44 schrieb Andrey Grodzovsky:
> Problem:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:332:1: warning: unused label 'exit' [-Wunused-label]
> exit:
> ^~~~~
>
> Fix: Put #ifdef CONFIG_64BIT around exit
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c547c78f3513..a10b4a7ccf5d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -330,7 +330,9 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos,
>   	}
>   	spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
>   
> +#ifdef CONFIG_64BIT
>   exit:
> +#endif
>   	drm_dev_exit(idx);
>   }
>   


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: Alexander.Deucher@amd.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit'
Date: Wed, 26 May 2021 15:59:00 +0200	[thread overview]
Message-ID: <2e692137-b837-adea-6e64-ab1c2a091555@gmail.com> (raw)
In-Reply-To: <20210525184431.1170373-1-andrey.grodzovsky@amd.com>



Am 25.05.21 um 20:44 schrieb Andrey Grodzovsky:
> Problem:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:332:1: warning: unused label 'exit' [-Wunused-label]
> exit:
> ^~~~~
>
> Fix: Put #ifdef CONFIG_64BIT around exit
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c547c78f3513..a10b4a7ccf5d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -330,7 +330,9 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos,
>   	}
>   	spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
>   
> +#ifdef CONFIG_64BIT
>   exit:
> +#endif
>   	drm_dev_exit(idx);
>   }
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-05-26 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 18:44 [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit' Andrey Grodzovsky
2021-05-25 18:44 ` Andrey Grodzovsky
2021-05-26 13:59 ` Christian König [this message]
2021-05-26 13:59   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e692137-b837-adea-6e64-ab1c2a091555@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.