From: Ray Jui <ray.jui@broadcom.com>
To: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Arnd Bergmann <arnd@arndb.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Bharat Gooty <bharat.gooty@broadcom.com>
Subject: Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
Date: Tue, 19 Jan 2021 09:44:18 -0800 [thread overview]
Message-ID: <2ea086ec-9af4-aaab-9ebf-a8e5986c9063@broadcom.com> (raw)
In-Reply-To: <20210119053444.23108-1-rayagonda.kokatanur@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
On 1/18/2021 9:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Add a non-empty dma-ranges so that dma address translation
> happens.
>
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> index aef8f2b00778..5401a646c840 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> @@ -4,11 +4,16 @@
> */
> usb {
> compatible = "simple-bus";
> - dma-ranges;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
>
> + /*
> + * Internally, USB bus to the interconnect can only address up
> + * to 40-bit
> + */
> + dma-ranges = <0 0 0 0 0x100 0x0>;
> +
Should have had my signed-off since during our internal review, I added
the above comment to explain why we set it to 40-bit here despite the
USB controller itself is capable of addressing 64-bit as Arnd pointed out.
Well, the following ack should do it too, thanks.
Acked-by: Ray Jui <ray.jui@broadcom.com>
> usbphy0: usb-phy@0 {
> compatible = "brcm,sr-usb-combo-phy";
> reg = <0x0 0x00000000 0x0 0x100>;
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4151 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <ray.jui@broadcom.com>
To: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Arnd Bergmann <arnd@arndb.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Bharat Gooty <bharat.gooty@broadcom.com>
Subject: Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
Date: Tue, 19 Jan 2021 09:44:18 -0800 [thread overview]
Message-ID: <2ea086ec-9af4-aaab-9ebf-a8e5986c9063@broadcom.com> (raw)
In-Reply-To: <20210119053444.23108-1-rayagonda.kokatanur@broadcom.com>
[-- Attachment #1.1: Type: text/plain, Size: 1601 bytes --]
On 1/18/2021 9:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Add a non-empty dma-ranges so that dma address translation
> happens.
>
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> index aef8f2b00778..5401a646c840 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> @@ -4,11 +4,16 @@
> */
> usb {
> compatible = "simple-bus";
> - dma-ranges;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
>
> + /*
> + * Internally, USB bus to the interconnect can only address up
> + * to 40-bit
> + */
> + dma-ranges = <0 0 0 0 0x100 0x0>;
> +
Should have had my signed-off since during our internal review, I added
the above comment to explain why we set it to 40-bit here despite the
USB controller itself is capable of addressing 64-bit as Arnd pointed out.
Well, the following ack should do it too, thanks.
Acked-by: Ray Jui <ray.jui@broadcom.com>
> usbphy0: usb-phy@0 {
> compatible = "brcm,sr-usb-combo-phy";
> reg = <0x0 0x00000000 0x0 0x100>;
>
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4151 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-19 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 5:34 [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation Rayagonda Kokatanur
2021-01-19 5:34 ` Rayagonda Kokatanur
2021-01-19 8:45 ` Arnd Bergmann
2021-01-19 8:45 ` Arnd Bergmann
2021-01-19 17:44 ` Ray Jui [this message]
2021-01-19 17:44 ` Ray Jui
2021-01-20 18:45 ` Florian Fainelli
2021-01-20 18:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea086ec-9af4-aaab-9ebf-a8e5986c9063@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.gooty@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.